From: Aaron Conole <aconole@redhat.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "ferruh.yigit\@intel.com" <ferruh.yigit@intel.com>,
"nikhil.rao\@intel.com" <nikhil.rao@intel.com>,
"pallantlax.poornima\@intel.com" <pallantlax.poornima@intel.com>,
"dev\@dpdk.org" <dev@dpdk.org>,
"jananeex.m.parthasarathy\@intel.com"
<jananeex.m.parthasarathy@intel.com>,
"reshma.pattan\@intel.com" <reshma.pattan@intel.com>,
"stable\@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf
Date: Mon, 01 Apr 2019 16:37:00 -0400 [thread overview]
Message-ID: <f7tlg0t1mz7.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <8ed852bffa7d6fda3a20019be2b4542542312983.camel@marvell.com> (Jerin Jacob Kollanukkaran's message of "Sat, 30 Mar 2019 14:15:47 +0000")
Jerin Jacob Kollanukkaran <jerinj@marvell.com> writes:
> On Wed, 2019-03-13 at 10:35 -0400, Aaron Conole wrote:
>>
>> > For all cases I expect truncation trigger a functional error which
>> > should be
>> > already handled properly, like in this case 'rte_vdev_init()' will
>> > fail in
>> > second call if buffer is small.
>>
>> And give the user a bad error ("I said net_null1038123825, not
>> net_null10
>> - bug in dpdk!").
>>
>> > There may be cases to check the return value, but that should be
>> > the case with
>> > 'sprintf' as well, changing API to 'snprintf' shouldn't require
>> > additional check
>> > by default.
>>
>> I agree, that's true. I think it's the right thing to do here,
>> though.
>
> Aaron,
>
> Are you expecting next version of this patch? Or I can merge this
> patch?
Go ahead and merge.
next prev parent reply other threads:[~2019-04-01 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:43 [dpdk-dev] " Pallantla Poornima
2019-02-08 21:19 ` Aaron Conole
[not found] ` <7AE31235A30B41498D1C31348DC858BD5B534A73@IRSMSX103.ger.corp.intel.com>
2019-03-12 7:41 ` Parthasarathy, JananeeX M
2019-03-12 14:44 ` Aaron Conole
2019-03-13 11:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-13 13:43 ` Aaron Conole
2019-03-13 14:07 ` Ferruh Yigit
2019-03-13 14:35 ` Aaron Conole
2019-03-30 14:15 ` Jerin Jacob Kollanukkaran
2019-03-30 14:15 ` Jerin Jacob Kollanukkaran
2019-04-01 20:37 ` Aaron Conole [this message]
2019-04-01 20:37 ` Aaron Conole
2019-04-02 1:35 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-04-02 1:35 ` Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tlg0t1mz7.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=jerinj@marvell.com \
--cc=nikhil.rao@intel.com \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).