From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56BE4A0526; Wed, 8 Jul 2020 15:45:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0BF41DC12; Wed, 8 Jul 2020 15:45:24 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 9B2581DBBC for ; Wed, 8 Jul 2020 15:45:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594215923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+360Jfsl+Ls2KjUcteGaZtUCFxC5Nn53fwaNQXaMvr4=; b=iXD7m6NeB3LNeEIYEnwViXGYRYtcrA2ohzzzulDG/apqTiyB/QBYO7jgwAxBRty95QKBfa H8q67x0/8J6723LDwgwoeVtezOrY0CRfWByG5U2dYxZpqbjpGJmRKXV7hSVTI4UkD0OVkQ 15ltHI2l7Ta0P30XWXkhibaiIUV1bzo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-MKjuZAqOO4u80Bpwo4OFog-1; Wed, 08 Jul 2020 09:45:21 -0400 X-MC-Unique: MKjuZAqOO4u80Bpwo4OFog-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 430E4108B; Wed, 8 Jul 2020 13:45:20 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-181.rdu2.redhat.com [10.10.114.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80D702DE6D; Wed, 8 Jul 2020 13:45:08 +0000 (UTC) From: Aaron Conole To: "Kinsella\, Ray" Cc: David Marchand , dev@dpdk.org, thomas@monjalon.net, dodji@redhat.com, Neil Horman References: <20200708102212.3311-1-david.marchand@redhat.com> <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu> Date: Wed, 08 Jul 2020 09:45:07 -0400 In-Reply-To: <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu> (Ray Kinsella's message of "Wed, 8 Jul 2020 14:09:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" "Kinsella, Ray" writes: > + Aaron > > On 08/07/2020 11:22, David Marchand wrote: >> abidiff can provide some more information about the ABI difference it >> detected. >> In all cases, a discussion on the mailing must happen but we can give >> some hints to know if this is a problem with the script calling abidiff, >> a potential ABI breakage or an unambiguous ABI breakage. >> >> Signed-off-by: David Marchand >> --- >> devtools/check-abi.sh | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh >> index e17fedbd9f..521e2cce7c 100755 >> --- a/devtools/check-abi.sh >> +++ b/devtools/check-abi.sh >> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do >> error=1 >> continue >> fi >> - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then >> + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { >> + abiret=$? >> echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" >> error=1 >> - fi >> + echo >> + if [ $(($abiret & 3)) != 0 ]; then >> + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org." >> + fi >> + if [ $(($abiret & 4)) != 0 ]; then >> + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." >> + fi >> + if [ $(($abiret & 8)) != 0 ]; then >> + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." >> + fi >> + echo >> + } >> done >> >> [ -z "$error" ] || [ -n "$warnonly" ] >> > > This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis. > At the moment it takes time to find the failure reason in the Travis log. That's a problem even for non-ABI failures. I was considering pulling the travis log for each failed build and attaching it, but even that isn't a great solution (very large emails aren't much easier to search). I'm open to suggestions. > Ray K