From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 84A2CA0C46;
	Tue,  7 Sep 2021 15:44:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 147B3410EF;
	Tue,  7 Sep 2021 15:44:05 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mails.dpdk.org (Postfix) with ESMTP id B6C10410ED
 for <dev@dpdk.org>; Tue,  7 Sep 2021 15:44:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1631022242;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=bX9nzrsfMn+VyzGS1Le86Iww8aTRBRxv8R5zqzYS/a8=;
 b=EHaUX/WZV0mBafJjr+Z/LqQVm8EvKelnVcqjzwDuC2DYPo/APLusiMc/uBVzmm9N5N7F7Z
 2pM2A0tVTMVvmhwhzBPb6dpLv6PuO+wenuJcu/coWxj9iqnoIYcE/U8+t/ZbsMt7NXvM+T
 9GyXp9DX0pSxVrJYbPINFSro9rbzmn8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-181-5arAPLSxOO-aWcI-vibj_Q-1; Tue, 07 Sep 2021 09:44:00 -0400
X-MC-Unique: 5arAPLSxOO-aWcI-vibj_Q-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17C72188E3FD;
 Tue,  7 Sep 2021 13:43:59 +0000 (UTC)
Received: from RHTPC1VM0NT (unknown [10.22.9.155])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id F3C09196E2;
 Tue,  7 Sep 2021 13:43:57 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Jie Zhou <jizh@linux.microsoft.com>
Cc: dev@dpdk.org,  dmitry.kozliuk@gmail.com,  roretzla@microsoft.com,
 navasile@linux.microsoft.com,  dmitrym@microsoft.com,
 pallavi.kadam@intel.com,  talshn@nvidia.com,  thomas@monjalon.net
References: <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com>
 <1630729155-24584-1-git-send-email-jizh@linux.microsoft.com>
 <1630729155-24584-14-git-send-email-jizh@linux.microsoft.com>
Date: Tue, 07 Sep 2021 09:43:56 -0400
In-Reply-To: <1630729155-24584-14-git-send-email-jizh@linux.microsoft.com>
 (Jie Zhou's message of "Fri, 3 Sep 2021 21:19:15 -0700")
Message-ID: <f7tsfyg4i1v.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
Subject: Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit
 tests on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Jie Zhou <jizh@linux.microsoft.com> writes:

> Enable a subset of unit tests on Windows. Currently not all the
> dependencies (e.g. libraries and some functionalities) of all unit
> tests are supported on Windows yet.
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---

Hi Jie,

How is it expected that a developer will add unit tests here?  For
example, let's pretend I develop some new test.  Do I insert it into the
non-windows section or the 'all' section?  Will it ever be moved common
(for example, do windows development team aim to provide some additional
test / review cycles for new tests added)?  This have some implication
on how developers need to add tests - maybe there can be a documented
process for getting code more common (between windows / linux /
freebsd)?

-Aaron

PS: I would suggest a possible route is to update to the doc proposed in
http://patches.dpdk.org/project/dpdk/patch/20210714164047.511561-1-aconole@redhat.com/
but it still isn't merged.