From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 47C77A059F;
Fri, 10 Apr 2020 16:05:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2EC391D16C;
Fri, 10 Apr 2020 16:05:21 +0200 (CEST)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
[205.139.110.61]) by dpdk.org (Postfix) with ESMTP id AC8CD1D167
for <dev@dpdk.org>; Fri, 10 Apr 2020 16:05:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586527519;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=Iu0E+yh7jba1cMwVfH/CAcKq9vCSVHnJXLm8gd2EYjI=;
b=ca6JeK6aW9BOTDSOagwa3VUiOo9RKgt/nX/NDMs99YbWbbtWH5mCDOeD54CfUgiP9/7tuf
RYgE3UWwr6SRBCVD64beOJfsfymPNfroGaAqS0UxtrEZ2FvrDV18RdyX56SuqL073EihtR
QYTly4OdB05i4gbA/WsQ7sKjU+6Qew0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-428-RmoxAASiPIiZICy2wbB_xw-1; Fri, 10 Apr 2020 10:05:12 -0400
X-MC-Unique: RmoxAASiPIiZICy2wbB_xw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
[10.5.11.15])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23310107ACC9;
Fri, 10 Apr 2020 14:05:11 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (ovpn-116-136.phx2.redhat.com
[10.3.116.136])
by smtp.corp.redhat.com (Postfix) with ESMTPS id F2F1A94B40;
Fri, 10 Apr 2020 14:05:06 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
David Marchand <david.marchand@redhat.com>, Gavin Hu <gavin.hu@arm.com>
References: <20200409180332.592074-1-thomas@monjalon.net>
<20200410102951.1398001-1-thomas@monjalon.net>
Date: Fri, 10 Apr 2020 10:05:00 -0400
In-Reply-To: <20200410102951.1398001-1-thomas@monjalon.net> (Thomas Monjalon's
message of "Fri, 10 Apr 2020 12:29:50 +0200")
Message-ID: <f7tsghb77xv.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc
file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Thomas Monjalon <thomas@monjalon.net> writes:
> Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat
> in app/test/meson.build and then adding it as a build dependency.
> This causes build loop if the timestamp of this file keeps changing.
>
> It is fixed by hiding hugepage check in a shell script.
>
> Fixes: 77784ef0fba8 ("test: allow no-huge mode for fast-tests")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> Reviewed-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> Acked-by: Aaron Conole <aconole@redhat.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>
> v2: use variable as pointed by Lukasz
> v3: avoid TOCTOU issue as suggested by David
> =09I'm afraid it requires to re-confirm every reviews above.
Still looks good to me.