Re: [dpdk-dev] [dpdk-stable] [PATCH] nfp: restore the unlink operation

[Aaron Conole <aconole@redhat.com>]

Ferruh Yigit <ferruh.yigit@intel.com> writes:

> On 5/14/2018 3:46 PM, Aaron Conole wrote:
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.  When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>
> This patch is for stable tree.
>
> Which stable branches are effected? Only 18.02?

At this time, just 18.02

>
> And a generic stable tree question, is there a easy way to find out which stable
> versions has a fix? For this example which versions get "nfp: allow for non-root
> user" fix?

I'm not sure if there is something in
http://dpdk.org/browse/tools/stable-scripts/ that might automatically
find the dependency?

>> 
>> Fixes: 515933ad8385 ("nfp: allow for non-root user")
>> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Eelco Chaudron <echaudro@redhat.com>
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>>  drivers/net/nfp/nfp_nfpu.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>> index ae2e07220..c003640c7 100644
>> --- a/drivers/net/nfp/nfp_nfpu.c
>> +++ b/drivers/net/nfp/nfp_nfpu.c
>> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>>  	close(desc->lock);
>>  
>>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
>> +	unlink(lockname);
>>  	return 0;
>>  }
>>