Depends-on

Depends-on

[Morten Brørup]

Aaron,

I have been trying to submit a patch with a dependency on another patch, but it keeps failing, and the error message "Apply patch set 140352 failed: 404 Not Found" isn't very helpful.

Could you please take a look at it and let me know what's going on:
https://patchwork.dpdk.org/project/dpdk/patch/20240528070546.92511-1-mb@smartsharesystems.com/


Med venlig hilsen / Kind regards,
-Morten Brørup

Re: Depends-on

[Aaron Conole]

Morten Brørup <mb@smartsharesystems.com> writes:

> Aaron,
>
> I have been trying to submit a patch with a dependency on another
> patch, but it keeps failing, and the error message "Apply patch set
> 140352 failed: 404 Not Found" isn't very helpful.
>
> Could you please take a look at it and let me know what's going on:
> https://patchwork.dpdk.org/project/dpdk/patch/20240528070546.92511-1-mb@smartsharesystems.com/

Sure - I'll take a look.

From the github robot side, it looks like we currently only support
dependencies via a series- request.

I'll try to spend some time and add patch based support, but I think
there was some weird tricky stuff going on.

>
> Med venlig hilsen / Kind regards,
> -Morten Brørup

RE: Depends-on

[Morten Brørup]

> From: Aaron Conole [mailto:aconole@redhat.com]
> Sent: Wednesday, 29 May 2024 16.34
> 
> Morten Brørup <mb@smartsharesystems.com> writes:
> 
> > Aaron,
> >
> > I have been trying to submit a patch with a dependency on another
> > patch, but it keeps failing, and the error message "Apply patch set
> > 140352 failed: 404 Not Found" isn't very helpful.
> >
> > Could you please take a look at it and let me know what's going on:
> > https://patchwork.dpdk.org/project/dpdk/patch/20240528070546.92511-1-
> mb@smartsharesystems.com/
> 
> Sure - I'll take a look.

Thank you.

> 
> From the github robot side, it looks like we currently only support
> dependencies via a series- request.

Oh, I didn't notice.

A previous version of the patch depended on the series, and passed github, but failed at IOL and Intel (like this version did):
https://patchwork.dpdk.org/project/dpdk/patch/20240527131659.80164-1-mb@smartsharesystems.com/

> 
> I'll try to spend some time and add patch based support, but I think
> there was some weird tricky stuff going on.

Series support suffices for this patch, so figuring out what is wrong with that will make me happy. :-)

Re: Depends-on

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi all,

Found my way to this thread based on the CI testing call yesterday, as I am
about to put together the blurb for the dpdk website testing page that
documents support (or lack thereof) for depends-on in CI.

On Wed, May 29, 2024 at 10:40 AM Morten Brørup <mb@smartsharesystems.com>
wrote:

> > From: Aaron Conole [mailto:aconole@redhat.com]
> > Sent: Wednesday, 29 May 2024 16.34
>
> >
> > I'll try to spend some time and add patch based support, but I think
> > there was some weird tricky stuff going on.
>
> Series support suffices for this patch, so figuring out what is wrong with
> that will make me happy. :-)
>
>
It probably doesn't make sense to add depends on individual patch support,
as the PW maintainer and Thomas agreed on depends on series support only
going forward.

https://github.com/getpatchwork/git-pw/issues/71#issuecomment-1938927101

[-- Attachment #2: Type: text/html, Size: 1535 bytes --]

Re: Depends-on

[Aaron Conole]

Patrick Robb <probb@iol.unh.edu> writes:

> *
> Hi all,
>
> Found my way to this thread based on the CI testing call yesterday, as I am about to put
> together the blurb for the dpdk website testing page that documents support (or lack
> thereof) for depends-on in CI. 

Thanks.

> On Wed, May 29, 2024 at 10:40 AM Morten Brørup <mb@smartsharesystems.com> wrote:
>
>  > From: Aaron Conole [mailto:aconole@redhat.com]
>  > Sent: Wednesday, 29 May 2024 16.34
>
>  > 
>  > I'll try to spend some time and add patch based support, but I think
>  > there was some weird tricky stuff going on.
>
>  Series support suffices for this patch, so figuring out what is wrong with that will make
>  me happy. :-)
>
> It probably doesn't make sense to add depends on individual patch support, as the PW
> maintainer and Thomas agreed on depends on series support only going forward. 
>
> https://github.com/getpatchwork/git-pw/issues/71#issuecomment-1938927101