From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49FA5A0547; Wed, 21 Apr 2021 14:58:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 072EC41AC8; Wed, 21 Apr 2021 14:58:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CA087410F9 for ; Wed, 21 Apr 2021 14:58:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619009890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bzj866F792GRYjHFFJkiBetpy4dcavuoAGpxbkZOY04=; b=cQZfrNA89kLVBc5Ao13B3j01KcvajjuzGxRDyQ8DOu4f2YlZvwtlf52bmBFgevwMCUqyNb nxCHY8dQo+EphoaQKpqc2ekUO0c2f1/8iz+6yaxfZTHW2TezCjaqxWteZIk8oB/AG/FGXh EDvmHo0Zy2Ks0VjpwytL703F7Z0dt48= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-atDmn5HKOnGyLisMVfVKFw-1; Wed, 21 Apr 2021 08:58:05 -0400 X-MC-Unique: atDmn5HKOnGyLisMVfVKFw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B534C1052284; Wed, 21 Apr 2021 12:57:16 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-115-145.rdu2.redhat.com [10.10.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B40B26268F; Wed, 21 Apr 2021 12:57:15 +0000 (UTC) From: Aaron Conole To: Ali Alnubani Cc: NBU-Contact-Thomas Monjalon , Cristian Dumitrescu , "dev\@dpdk.org" References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <2003889.D9zfWNbQnx@thomas> Date: Wed, 21 Apr 2021 08:57:14 -0400 In-Reply-To: (Ali Alnubani's message of "Wed, 21 Apr 2021 07:49:39 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ali Alnubani writes: > Hi, > >> -----Original Message----- >> From: dev On Behalf Of Thomas Monjalon >> Sent: Tuesday, April 20, 2021 10:58 PM >> To: Cristian Dumitrescu >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 12/04/2021 01:23, Cristian Dumitrescu: >> > Each table entry is made up of match fields and action data, with the >> > latter made up of the action ID and the action arguments. The approach >> > of having the user specify explicitly the endianness of the action >> > arguments is difficult to be picked up by P4 compilers, as the P4 >> > compiler is generally unaware about this aspect. >> > >> > This commit introduces the auto-detection of the endianness of the >> > action arguments by examining the endianness of the their destination: >> > network byte order (NBO) when they get copied to headers and host byte >> > order (HBO) when they get copied to packet meta-data or mailboxes. >> > >> > The endianness specification of each action argument as part of the >> > rule specification, e.g. H(...) and N(...) is removed from the rule >> > file and auto-detected based on their destination. The DMA instruction >> > scope is made internal, so mov instructions need to be used. The >> > pattern of transferring complete headers from table entry action args >> > to headers is detected, and the associated set of mov instructions >> > plus header validate is internally detected and replaced with the >> > internal-only DMA instruction to preserve performance. >> > >> > Signed-off-by: Cristian Dumitrescu >> >> Series applied, thanks >> >> > > I believe this patchset is causing the build failures in https://bugs.dpdk.org/show_bug.cgi?id=683. Where do you see those build errors? Compiler version, etc? For example: https://github.com/ovsrobot/dpdk/actions/runs/767327010 This build was successful after rerunning with the prerequisite patch applied to mainline. I am concerned why the CI didn't catch this. > Regards, > Ali