From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Michael Santana <msantana@redhat.com>,
David Marchand <dmarchan@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds
Date: Fri, 02 Aug 2019 16:43:33 -0400 [thread overview]
Message-ID: <f7twofv5mdm.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <3128132.jsL9bJ4oNI@xps> (Thomas Monjalon's message of "Fri, 02 Aug 2019 22:32:06 +0200")
Thomas Monjalon <thomas@monjalon.net> writes:
> 31/07/2019 16:50, Aaron Conole:
>> From: Michael Santana <msantana@redhat.com>
>> --- a/app/test/meson.build
>> +++ b/app/test/meson.build
>> +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL')
>> + test_deps += 'mempool_ring'
>> +endif
>> +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL')
>> + test_deps += 'mempool_stack'
>> +endif
>> +if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD')
>> + test_deps += 'pmd_skeleton_event'
>> +endif
>> if dpdk_conf.has('RTE_LIBRTE_PDUMP')
>> test_deps += 'pdump'
>> endif
>
> As these libraries are dynamically loadable as plugins,
> it should be explained in comments that this explicit linking
> is an exception to allow the developer run the unit tests
> without intalling the libraries.
> Otherwise, other applications will copy it.
Okay. I'll add it.
next prev parent reply other threads:[~2019-08-02 20:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:50 [dpdk-dev] [PATCH 0/2] Enable fast-unit tests under travis Aaron Conole
2019-07-31 14:50 ` [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds Aaron Conole
2019-07-31 15:36 ` Bruce Richardson
2019-07-31 16:07 ` Aaron Conole
2019-07-31 16:10 ` Aaron Conole
2019-08-01 9:19 ` Bruce Richardson
2019-08-01 15:40 ` Aaron Conole
2019-08-01 16:51 ` Bruce Richardson
2019-08-01 16:52 ` Bruce Richardson
2019-08-02 20:32 ` Thomas Monjalon
2019-08-02 20:43 ` Aaron Conole [this message]
2019-07-31 14:50 ` [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci Aaron Conole
2019-07-31 20:54 ` Michael Santana Francisco
2019-08-02 13:34 ` Aaron Conole
2019-08-02 13:40 ` Michael Santana Francisco
2019-08-02 20:27 ` Thomas Monjalon
2019-08-02 20:59 ` Aaron Conole
2019-08-02 21:05 ` Thomas Monjalon
2019-08-02 21:07 ` Aaron Conole
2019-08-02 14:18 ` [dpdk-dev] [PATCH 0/2] Enable fast-unit tests under travis David Marchand
2019-08-02 21:25 ` [dpdk-dev] [PATCH v2 " Aaron Conole
2019-08-02 21:25 ` [dpdk-dev] [PATCH v2 1/2] tests: Fix unit tests for shared builds Aaron Conole
2019-08-02 21:51 ` Thomas Monjalon
2019-08-02 21:25 ` [dpdk-dev] [PATCH v2 2/2] ci: enable unit tests under travis-ci Aaron Conole
2019-08-02 22:00 ` [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis Thomas Monjalon
2019-08-05 6:26 ` David Marchand
2019-08-05 12:52 ` David Marchand
2019-08-05 13:56 ` Michael Santana Francisco
2019-08-05 14:18 ` Aaron Conole
2019-08-05 14:21 ` Thomas Monjalon
2019-08-07 14:06 ` Michael Santana Francisco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7twofv5mdm.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmarchan@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=msantana@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).