From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6BEE5A10DA
	for <public@inbox.dpdk.org>; Fri,  2 Aug 2019 22:43:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5D9681C2B6;
	Fri,  2 Aug 2019 22:43:37 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 040A41C212
 for <dev@dpdk.org>; Fri,  2 Aug 2019 22:43:35 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 13F3190C99;
 Fri,  2 Aug 2019 20:43:35 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.67])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 2315C5C207;
 Fri,  2 Aug 2019 20:43:34 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Michael Santana <msantana@redhat.com>,
 David Marchand <dmarchan@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>
References: <20190731145030.19956-1-aconole@redhat.com>
 <20190731145030.19956-2-aconole@redhat.com> <3128132.jsL9bJ4oNI@xps>
Date: Fri, 02 Aug 2019 16:43:33 -0400
In-Reply-To: <3128132.jsL9bJ4oNI@xps> (Thomas Monjalon's message of "Fri, 02
 Aug 2019 22:32:06 +0200")
Message-ID: <f7twofv5mdm.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Fri, 02 Aug 2019 20:43:35 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas Monjalon <thomas@monjalon.net> writes:

> 31/07/2019 16:50, Aaron Conole:
>> From: Michael Santana <msantana@redhat.com>
>> --- a/app/test/meson.build
>> +++ b/app/test/meson.build
>> +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL')
>> +	test_deps += 'mempool_ring'
>> +endif
>> +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL')
>> +	test_deps += 'mempool_stack'
>> +endif
>> +if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD')
>> +	test_deps += 'pmd_skeleton_event'
>> +endif
>>  if dpdk_conf.has('RTE_LIBRTE_PDUMP')
>>  	test_deps += 'pdump'
>>  endif
>
> As these libraries are dynamically loadable as plugins,
> it should be explained in comments that this explicit linking
> is an exception to allow the developer run the unit tests
> without intalling the libraries.
> Otherwise, other applications will copy it.

Okay.  I'll add it.