From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A8D1A046B for ; Thu, 25 Jul 2019 15:28:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09F311C339; Thu, 25 Jul 2019 15:28:02 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 850D91C316; Thu, 25 Jul 2019 15:28:00 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9DECC3082138; Thu, 25 Jul 2019 13:27:59 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-123-51.rdu2.redhat.com [10.10.123.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2054960606; Thu, 25 Jul 2019 13:27:57 +0000 (UTC) From: Aaron Conole To: hgovindh Cc: Remy Horton , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , dev@dpdk.org, stable@dpdk.org In-Reply-To: <20190724164354.18811-1-hariprasad.govindharajan@intel.com> (hgovindh's message of "Wed, 24 Jul 2019 17:43:54 +0100") References: <20190724164354.18811-1-hariprasad.govindharajan@intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Thu, 25 Jul 2019 09:27:56 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 25 Jul 2019 13:27:59 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hgovindh writes: > Fix unaligned memory access when reading IPv6 header which > leads to segmentation fault by changing aligned memory read > to unaligned memory read. > > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > Cc: maciej.czekaj@caviumnetworks.com > Cc: stable@dpdk.org > Signed-off-by: hgovindh > --- > examples/l3fwd/l3fwd_em.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c > index fa8f82be6..f0c443dae 100644 > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > @@ -285,7 +285,7 @@ em_get_ipv6_dst_port(void *ipv6_hdr, uint16_t portid, void *lookup_struct) > * Get part of 5 tuple: dst IP address lower 96 bits > * and src IP address higher 32 bits. > */ > - key.xmm[1] = *(xmm_t *)data1; > + key.xmm[1] = _mm_loadu_si128((xmm_t *)data1); Nak. Please use a generic unaligned load, rather than an intel specific one. Otherwise, supported platforms like arm64 will have broken builds. Additionally, which chip and compiler did you use to get this error? > > /* > * Get part of 5 tuple: dst port and src port