From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 11B48A0471
for <public@inbox.dpdk.org>; Thu, 20 Jun 2019 02:05:42 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A53CA1D08D;
Thu, 20 Jun 2019 02:05:41 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id D53621D08C
for <dev@dpdk.org>; Thu, 20 Jun 2019 02:05:40 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id D3B5530821AE;
Thu, 20 Jun 2019 00:05:39 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (ovpn-124-68.rdu2.redhat.com
[10.10.124.68])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 93DD119C79;
Thu, 20 Jun 2019 00:05:38 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>
Cc: akhil.goyal@nxp.com, dev@dpdk.org, ferruh.yigit@intel.com,
thomas@monjalon.net, amr.mokhtar@intel.com, kamilx.chalupnik@intel.com
References: <1560444716-18594-2-git-send-email-nicolas.chautru@intel.com>
<1560964274-83070-1-git-send-email-nicolas.chautru@intel.com>
<1560964274-83070-4-git-send-email-nicolas.chautru@intel.com>
Date: Wed, 19 Jun 2019 20:05:37 -0400
In-Reply-To: <1560964274-83070-4-git-send-email-nicolas.chautru@intel.com>
(Nicolas Chautru's message of "Wed, 19 Jun 2019 10:11:14 -0700")
Message-ID: <f7ty31xjf3i.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.47]); Thu, 20 Jun 2019 00:05:40 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v6 3/3] baseband/turbo_sw: meson build
support for PMD driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Nicolas Chautru <nicolas.chautru@intel.com> writes:
> Turbo_sw PMD driver now building with meson/ninja
> with or without SDK libraries.
>
> Acked-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
It seems strange to ack your own patch.
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
Something is wrong with this series:
https://travis-ci.com/ovsrobot/dpdk/builds/116170401
We cannot enable this on AARCH64 builds - it seems that it wants to take
advantage of facilities that are x86 specific (like SSE 4.2)
> drivers/baseband/meson.build | 2 +-
> drivers/baseband/turbo_sw/meson.build | 30 ++++++++++++++++++++++++++++++
> meson_options.txt | 2 ++
> 3 files changed, 33 insertions(+), 1 deletion(-)
> create mode 100644 drivers/baseband/turbo_sw/meson.build
>
> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
> index 52489df..40a87d2 100644
> --- a/drivers/baseband/meson.build
> +++ b/drivers/baseband/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
>
> -drivers = ['null']
> +drivers = ['null', 'turbo_sw']
>
> config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> driver_name_fmt = 'rte_pmd_@0@'
> diff --git a/drivers/baseband/turbo_sw/meson.build b/drivers/baseband/turbo_sw/meson.build
> new file mode 100644
> index 0000000..9b4fe34
> --- /dev/null
> +++ b/drivers/baseband/turbo_sw/meson.build
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +
> +path = get_option('flexran_sdk')
> +
> +if dpdk_conf.has('RTE_BBDEV_SDK_AVX2')
> + lib = cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: false)
> + if not lib.found()
> + build = false
> + else
> + ext_deps += cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: true)
> + ext_deps += cc.find_library('libcrc', dirs: [path + '/lib_crc'], required: true)
> + ext_deps += cc.find_library('librate_matching', dirs: [path + '/lib_rate_matching'], required: true)
> + ext_deps += cc.find_library('libcommon', dirs: [path + '/lib_common'], required: true)
> + ext_deps += cc.find_library('libstdc++', required: true)
> + ext_deps += cc.find_library('libirc', required: true)
> + ext_deps += cc.find_library('libimf', required: true)
> + ext_deps += cc.find_library('libipps', required: true)
> + ext_deps += cc.find_library('libsvml', required: true)
> + includes += include_directories(path + '/lib_turbo')
> + includes += include_directories(path + '/lib_crc')
> + includes += include_directories(path + '/lib_rate_matching')
> + includes += include_directories(path + '/lib_common')
> + endif
> +endif
> +
> +deps += ['bbdev', 'bus_vdev', 'ring']
> +name = 'bbdev_turbo_sw'
> +allow_experimental_apis = true
> +sources = files('bbdev_turbo_software.c')
> diff --git a/meson_options.txt b/meson_options.txt
> index 16d9f92..92d3e97 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -10,6 +10,8 @@ option('enable_kmods', type: 'boolean', value: true,
> description: 'build kernel modules')
> option('examples', type: 'string', value: '',
> description: 'Comma-separated list of examples to build by default')
> +option('flexran_sdk', type: 'string', value: '',
> + description: 'Path to FlexRAN SDK optional Libraries for BBDEV device')
> option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'shared',
> description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')
> option('include_subdir_arch', type: 'string', value: '',