From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6D9543AA3; Wed, 7 Feb 2024 19:40:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8618F4027D; Wed, 7 Feb 2024 19:40:37 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2057.outbound.protection.outlook.com [40.107.96.57]) by mails.dpdk.org (Postfix) with ESMTP id 7FB8D4026E for ; Wed, 7 Feb 2024 19:40:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWBhx7bdKP7v/lSp0sSpQk36LXGmAppBy38J9WERCsxHXcQJpc+w5bG91KEiLA0kmqtzK4B2EoK7rYbdCohhSNlCirj6911ZjB3v+KuY1GGRvlDbcryX9ZKUg1UIak2xNrBQyGg/horafo5ohgYMmDko1tyxcfMNE16N+lp74IYHDeHt+PS2IwvkOo7wfOC1Igt2kwya1QsaxYB2ApldnoDQQeBrR27aux1g8Q2PhqsPbddypwOWJmiivt5i2gdRIsx4S8bTcScmyw4KwfT8mEK32TCfJsSYqnFf6sT5FHmw3CAM72aQII1jDDGISG7SuV4sRnxpne7ZBfESem/7Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+5NLalVjyje0RQpSAYpkF7/06dzVEz3TJO2MyM1qGto=; b=fIKfoIDIzNRocpXBrj/V2XM4tZIV7HyeWgjexP1H4zk2b/x9Zq+Yb8bFFrJ7EyivKvu8DJrV0l+Di768JP/afcwi7aZGZvCkVoVJnHkzcBfo6e4dHP6C+u7kmQ0MThymU8eLdbv+aj64KL8JbuLth795HhtS/50X0whcBt/MqgUrNQ2L46qIBbXRG1nf8Pe2q9Ynp7qUTLy1959sB3fjSoA7J1GlPyLCiMW1rMo7RwVxk6AFSlTutTjDUS5qdJgweqPNAWga9DdkXLpVA3rLcPrlkrfztes1DvFFh3d7/jjmM2VCydny5JwBrzrbJXhil17sEBAASKP9DacrP7MppQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+5NLalVjyje0RQpSAYpkF7/06dzVEz3TJO2MyM1qGto=; b=g+T04ZWqSirH1aBNkA2DbnVDBT/Z3JBM9RDUycyW6khTV7SaZgRu3Sd1RX2ZqtEJ5qfkbVeoBthJWImOmBkcwrF7jmrL8QlBWo3YJjwxqIMXcnxlE202kztq8Iw+i/rIMldPDuGfxnEpE8DVQEujokShzuZ0PggNl2ADesYlX14= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4293.namprd12.prod.outlook.com (2603:10b6:610:7e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 18:40:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 18:40:34 +0000 Message-ID: Date: Wed, 7 Feb 2024 18:40:31 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] net/mana: use a MR variable on the stack instead of allocating it Content-Language: en-US To: longli@microsoft.com, Andrew Rybchenko Cc: dev@dpdk.org References: <1706577886-29483-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1706577886-29483-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0165.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4293:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bc264f7-6305-4884-8221-08dc280c4513 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 811Ozfj4A0irDxRU9oFRnj4HNkriPLwINacokDnTMLraAM8Po5JHs4WGhoL625kNoZp0Hq2lRLl10+3lgNdfiFhOoYnPK5UipBC9ZxMj6HoeUpKI0PJ7sa3oGk+uklobFw3cNO4ReBPkxf8HDU3/6fC9IzYamXo9LQes9iyDSjpIrX+ABBsBmJVRuielYCLuXlNTjEWBBro070AKiQuMdJLezvvxa39P2ZNDsiivK5VmJhHytuGc3lChvPDzYyAN+4XkWBOKQq6ScK1pRs5L5QCt5CJJeqXllBL0uRauN5pyydfzCNAHBejkbo4tyK+A8yBWjOriYDyT4cgI5b4ragMfefbf1d9GON4FOTxKCV6RMYrvLHucW3DgEShT+hzg3WI45rv8LYiFaaAZH6RAd/b1njszAEt16VF1xbyUjWYfD5KZr8wdENGICw72Qx1t2BjD0ObATO8qISdQ3vxb8XtVG++op4hGMSOK3u35MqUdEJywzuF7GaQ6jVto7nRFOfY0EUklFlTllTvd6K/ADAXvMZQU7R8ImcgVohOzvnAXJLNUpU8iaBFh8lSeScuGwTod9PoXFypQZT5taM3wNv1kqhNmQ2BnHsJMRK79x/w9BVyNpbk/tPCpg5zc1pj+vRm6IY2zvO34usEcmsm7UQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(39860400002)(376002)(396003)(136003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(316002)(41300700001)(8676002)(8936002)(6486002)(36756003)(4326008)(66946007)(86362001)(2906002)(66476007)(5660300002)(44832011)(6916009)(66556008)(478600001)(31696002)(53546011)(2616005)(38100700002)(45080400002)(6506007)(6666004)(83380400001)(26005)(6512007)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c20zMUZzeEpwSy9TbGV1MmQ5ZGNaN0E2bmhSenhkajFvdU9BRkdKcEdXZ0NH?= =?utf-8?B?ZzAzOEhWUngyRFBkTHYwRldHaGVsVS9MUFRNVzlteEIya2RMU0tTWkNPeGoz?= =?utf-8?B?ekFYSEo0NmxxRUpVeE8rSi9SZmMwK3A1MG9RQ3FFQTRTeFdWVXBLM2NudEha?= =?utf-8?B?SkJ2QUJoeDRWZWJBY2lGaHZnK1VTRC8xTDBOVWZBY3B6Sm9jUVNCcnlGL1o0?= =?utf-8?B?MWludlMrQm1VUGVzditmam81ZzF1UHhiN0UzMm5YYVlYRWtUVWoyYmNVanlS?= =?utf-8?B?TkUvTmhHWGM3L2FSQlR0cXo3bk1mQnk1aXNkZ1UwWjA2M243WGk1Y1I1dEEr?= =?utf-8?B?Lys5dTUxb2RNRjBpSUd1UkY3dnhmdlZDc1hYVzlna0l4djNwbUtiUjh1dFNB?= =?utf-8?B?YzhIWnlKK3BUZUtQR0VqTys0RDAwaUNOeFlZSEF4alZIa1RTazV6dm50YjBy?= =?utf-8?B?TmdGY2VYYzFpeDJMaE5odytNekNGdzFhRld4cFcrSUtvcGhCbUxsa1ZiaW9x?= =?utf-8?B?UjI2WXIrTEErRXNHMmo4ekw1Wlo3Y2ltWGFPN0hPNGdYQmx5OXZvTlFLRFlM?= =?utf-8?B?c0dFQ3RkdWQwanBwcWJNS0ZGWkNFdHBtdXhoRUZmZ0NjK0M5S3NONWhwcWd4?= =?utf-8?B?RTdxcEcxZnZZS1UvRStOUUxxTmtZUXZRaGF6Vmx5U203SkV4WDNwazFzYkJI?= =?utf-8?B?bzBrbzA0NThmUUY2MGs4N1NoV3B0enNZaXg1L0toNmtsL1V2Ynpwa0l2eFkr?= =?utf-8?B?VDlWcFFBU3RxYlR2cG81RUhTYTZHSk9YZWNWMWlDWTNQN2VrTGlTZmNsTWg5?= =?utf-8?B?d0svZnBYY29nelZPV053Q1JoZmxTdVJ4YWRhb3NOaHRBaHBpcU44K1dQTzQ0?= =?utf-8?B?YU9EdHBGS2hNNmM2NkhJZGpXYlkwdHNhQWlXeEJjMmVtaXlHKzdIMjFvQ1JX?= =?utf-8?B?cmtXdFAwcDEwOU1yQ1FtMFNTclBTN2dsczdXTVRKdkE5aVgxLzJ3SXlFWFRh?= =?utf-8?B?REVLb1JrWUZiT1ZNcG5BRFRRV2pzRU5ncytidm9PVFRCTWxkbURGbG00RldP?= =?utf-8?B?TCtIOVVPUUQvcWx3T290Snk5eWNxN2dkaVBqbUJjbWdHRmdvVnFNcWJMc3NV?= =?utf-8?B?bUtrY0dCS3U5RkIvSi9NdWZlenZkcDBSU2oxSFFCVWlnY2xxcE90Mm9xM3Rs?= =?utf-8?B?aTJIT0V6aHRtcWtrcDZ4SlVKRkNacjlXN3FmNmd1L1ZRVHZTOVlFTVdtc2Y4?= =?utf-8?B?TzByenB6eUVuZ3czcGp4bHU4dSthMXNkWm1EUUZ0dW4xWDV3MklNOHVtcEUz?= =?utf-8?B?UWFiM1lTMEZzbkhQV3gxQnA1TjdkLzRwL0V4cnU1bXc0VHY5bWhyN2tYZDd1?= =?utf-8?B?SlUxWXRXVi9oSDRCYlRXNFQwdlBDTVlaOStrVEJrNU9uVEdCOW9lcjk0amww?= =?utf-8?B?M2I0aDBSeHYySVlGMjVDRkRwaU0xYnQrQkJKdjFKSXpsWkowdWlsVDdoUzFk?= =?utf-8?B?ZG9tQk5TWGlVMENpeVZCZlZ3NUlybCtkb2VKVERBM2lvSGc4T25hOGp5UmpX?= =?utf-8?B?azNKazJJM2hQdUdhVGQ2djJXM3Z3eXNWV0JtNWRxcmZBRDZSclRIcFVBWHdF?= =?utf-8?B?MU4zdVgvKzZ2VGt3YWhxZ00xeDR5Q3pqR3VtRUNtQVBROGFPSVVrMjZWWG9k?= =?utf-8?B?REJzazNrcUF6bHR6U1JSRHVxeTNqenVrNVN2SEhPekF1M1FhWkFiWFpyVzlX?= =?utf-8?B?QTJHUXVQYUcxVk5QMUJ0ZFRidnRiUEpVVHRnenhqMGw2YTN6SFhsUTNYSVhr?= =?utf-8?B?cVhvKy9KSmhUVEZRRGNiVzR2U0xNSzMyYk1aaS85bVVGSnY2TzJvUjRUVzNu?= =?utf-8?B?aVRZL1VBcktQV2xTQ3R6R3VTcXZKYTA0cFlwMGZaK2pmZjdFQ1g3NUk5QnVv?= =?utf-8?B?VmNKTHBZUkVsRzVGK1ZWUFh0dFA3UXZadEdkeG16SlVHc2VpeXhlaGpJbW8r?= =?utf-8?B?QkRBdS9vSVEwcFh0MTMrTmk3cWRyemd4SzdkNTY4NlNESWxQcm1GY09hSzJa?= =?utf-8?B?dHkwcWRtU0RKU2hla3J2VC9EMGxVZWFMd0Z0RCtMUlZiWnBRU1pyYlg1RTZQ?= =?utf-8?Q?DC3oHRcOzFbDX3g/HdFgj7Mlq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bc264f7-6305-4884-8221-08dc280c4513 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 18:40:34.5724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fJvUjRAs7VYDVtSV1JVg9Ewhn9Gu68ie1X8E+MWBJXFa4ogNubu1cN+p+9V4rVxX X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4293 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2024 1:24 AM, longli@linuxonhyperv.com wrote: > From: Long Li > > The content of the MR is copied to the cache trees, it's not necessary to > allocate a MR to do this. Use a variable on the stack instead. > > This also fixes the memory leak in the code where a MR is allocated but > never freed. > patch title describes what is done, but not gives information about reasoning and impact. Is this a performance improvement (if so how much), or is this a fix for the memory leak (if so we need fixes tag for backport), or just a refactoring? > Signed-off-by: Long Li > --- > drivers/net/mana/mr.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/mana/mr.c b/drivers/net/mana/mr.c > index d6a5ad1460..c9d0f7ef5a 100644 > --- a/drivers/net/mana/mr.c > +++ b/drivers/net/mana/mr.c > @@ -40,7 +40,7 @@ mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > struct ibv_mr *ibv_mr; > struct mana_range ranges[pool->nb_mem_chunks]; > uint32_t i; > - struct mana_mr_cache *mr; > + struct mana_mr_cache mr; > int ret; > > rte_mempool_mem_iter(pool, mana_mempool_chunk_cb, ranges); > @@ -75,14 +75,13 @@ mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > DP_LOG(DEBUG, "MR lkey %u addr %p len %zu", > ibv_mr->lkey, ibv_mr->addr, ibv_mr->length); > > - mr = rte_calloc("MANA MR", 1, sizeof(*mr), 0); > - mr->lkey = ibv_mr->lkey; > - mr->addr = (uintptr_t)ibv_mr->addr; > - mr->len = ibv_mr->length; > - mr->verb_obj = ibv_mr; > + mr.lkey = ibv_mr->lkey; > + mr.addr = (uintptr_t)ibv_mr->addr; > + mr.len = ibv_mr->length; > + mr.verb_obj = ibv_mr; > > rte_spinlock_lock(&priv->mr_btree_lock); > - ret = mana_mr_btree_insert(&priv->mr_btree, mr); > + ret = mana_mr_btree_insert(&priv->mr_btree, &mr); > rte_spinlock_unlock(&priv->mr_btree_lock); > if (ret) { > ibv_dereg_mr(ibv_mr); > @@ -90,7 +89,7 @@ mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > return ret; > } > > - ret = mana_mr_btree_insert(local_tree, mr); > + ret = mana_mr_btree_insert(local_tree, &mr); > if (ret) { > /* Don't need to clean up MR as it's already > * in the global tree