From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77E6D43871; Tue, 9 Jan 2024 11:35:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19807402EF; Tue, 9 Jan 2024 11:35:15 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2064.outbound.protection.outlook.com [40.107.237.64]) by mails.dpdk.org (Postfix) with ESMTP id 517624021F for ; Tue, 9 Jan 2024 11:35:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BOdZw/h8VvCRJLWXjsFU6kd0bHSv/7A/dPLuIJWJZMaTmcVOtCg69xkD4w5IC1veBjQBrLRHeuDSsHjRaAddfSBlTXq1Yu0nXekcKgfxfAbSe7AE2WbKkRtr7dxXDoSxd5s/BaHGgvnPhsonhLHHWB6yqS2zF0pLhmwwGaX43S7CE4KmpBEepMeXKqwNGVPYHYQcFBplEHAQOIlbQSDeGEiia1mP2ai1Gl0wekIW+GA37faenfLLXpiSv/T09sipRa5d20QuOg5hNaqpsnKIxMdACw2aalZ1n7ZPVyhKx8uWBOG0CcVg6fBWWQ/pKkhEMdtkBmaoAkTltvkZbvfURA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skVF6Tnl80XjzqE+Tmnjv88n41iwQU6+hHoKn5aGGI4=; b=kLk4JqyJl/r0rUezifC7CyXi9gS1SRdG0nwelFnf+H4aqdykGHCG3DLCHXOaugcxdURfqZr2hBzR/b6gYnf4vmOmyWZI+usZiNeykALGGSsSiPO4KleCynzLhMqKEKYu46UjpuuybmEMKUEqNL9vc87Vq6NKOBhCOzJboRI58qwlO962A+7yYXESihqYdwTFAelXxHkB1SRB7IiaPP/1wSHPMCZoHV4XB6C5h2bl9zgXvawMW2iOQNcrZhWVlhLAOAF/E+AqOKJJA6v7UC0lT5tVF7QFqZVSyFQ8a4paP9BfqS0BQXBCeQqK7a1tFjExDR2QW1Lh2DHlLLGJHlqVOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skVF6Tnl80XjzqE+Tmnjv88n41iwQU6+hHoKn5aGGI4=; b=tt7JYSIhuo03lA+Dn3vp9CMNdVv9Ypf5iPii96miEAVZbdNcC7F2fbjwFDVuBQ5u9XaOXUB88pe4Ml31RbKajIQLKhPzpfIH8QsgKg2B1tLEaG2P7CUySunW9Ue464oLrhQvFuXm6MH7eSwExQWWHflfJMhHIC1tjd3BD07d7LI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5778.namprd12.prod.outlook.com (2603:10b6:208:391::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.25; Tue, 9 Jan 2024 10:35:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 10:35:12 +0000 Message-ID: Date: Tue, 9 Jan 2024 10:35:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/axgbe: read and save the port property register Content-Language: en-US To: Venkat Kumar Ande , dev@dpdk.org Cc: Selwin.Sebastian@amd.com References: <20240105113250.11492-1-venkatkumar.ande@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240105113250.11492-1-venkatkumar.ande@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5778:EE_ X-MS-Office365-Filtering-Correlation-Id: fce4ae87-7c30-4b96-beaa-08dc10fea8d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y7gzPwGk5TsLb/P9JQX6kBIQU+ItzCvRppV4J+Kfo/EB1POH/e0Hu5Q/aABu3QEm3Dwgpoj5cTKlEAm4gTypP7cAHdTw7sYLOyaiAbvBYG2g+sRLp9l1+DnXA/ydCjGB37IY7qR8W8HmTOwA0HAnffhroQz1CeEYQ6/O+ZxzQhePZwTI1QdjqrcEUd6OW1duvJFCZ8Z7/JqoXsHYlAu6kP+s75dQpn9JHQ5zTF+DTksFEh2DgCpRV600VLagMRbemK9dAop5DFqcApauhVWjM0IdgQrcl0RbEvDOz96MUTPuPUsRdS4l0MMCZh4K7BLOmSgliVeIAUO3y+mb1iuMw6Onp9XJqJhUtgrgvaxWGjIOFSROgoHZnUP+eph9B3uD+bQJBqVjRKk5jyjggQQ4o49Uo+Y/4iVz+kRZGBcV8W43Ue7o30mDES8OALsbHqsQFVHe1K1PZ0pEvDCoOibvLVNCwS1KlWaHHliNRTT0bsLaIr8tldw9ESCXX2KQhHo/vRHg0Dq2EZ0hlewmNvDNXiUzegS41nRrO3QxD7Ze2hSkNf29cB7KRfpkweueyhayqKU396Es0CID9mOeTbAwPSWTqepXPJKN/MDUz/tv/nzd2xrdKmqAOXilKEgQX2YuWAL/kMVwmUm3fO69FbYzzg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(136003)(39860400002)(396003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(31686004)(83380400001)(6512007)(26005)(86362001)(36756003)(31696002)(38100700002)(4326008)(44832011)(5660300002)(6666004)(6506007)(53546011)(2616005)(66476007)(316002)(8936002)(8676002)(66946007)(66556008)(2906002)(41300700001)(478600001)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enpsLzQveVhiQU9wRU1UZCtUbUZVQ04wejcwMEhua1BDdlIvLzdtM1ZLa01I?= =?utf-8?B?ejJiZ0l0WVROUmFBdjRkR0tpVnM2eU5yc0dnQTdVakZva0tTcnAwM3dHL3k1?= =?utf-8?B?OHJyTE9YM1IrNWl6SDFmTXFWUGRoWGV2M2kweWtuWXZKaDJjRHRwbWpoTTlU?= =?utf-8?B?Q0xJYlVOODdUNERFY3g2cXJSUWtwZHBvZ3pvM01TNXp3VE9DZGVNYkFPcUdS?= =?utf-8?B?czFzSEJhNUZORm83UmdjRU4veHhML1ZvbFZ4ejlsT0JpMnpCSUlkZ2xtVUUr?= =?utf-8?B?dGF2S3JvODZQbmNkQ2NwYWxCdjF2eEUyRExMaW9LN2c1VE53ZnZ3TENJb3dT?= =?utf-8?B?YzAxZWs2VXVKNFR0RDgzU2lqSEVDb0NLeC9vTm5rTDU0c2k3ODcwYjRYenFh?= =?utf-8?B?WCs0WTNvQzNxQmR6K25oLzkvMk1tZENlM1dyZXdVM2xWdlBaVjhxKzU4MnB4?= =?utf-8?B?a1BpbjdhbitvM2J6by96SFZ1WGZQQ1NmRnJZa2RTYUtuKzIycDRJRHkyNm5H?= =?utf-8?B?Vjl6Q1czZi9xZVdHZ0M3dEFpZXhhRjJ6M3JxYUJFN2J5SytHaW5GKzNhYnFQ?= =?utf-8?B?K3NicllIYkxRUTZ3M0hxY2tldHpycTdFbHdmazhScFVQZ245VE9lL2RUNE5q?= =?utf-8?B?VzdIN0NYTmRnNXEwMDA5Mk0vY0ZSUGZlVWhIcUk2LzFqRWtBc05TZ2tCUHpY?= =?utf-8?B?RXRPZUYwMDFFQnF2aFU0UEUxZjlrOXo5MnY4QmVkNGhOcUpCTjlMc1Q2RVZQ?= =?utf-8?B?UkRoM3hrUmpoMUdiRmM0NitDNjc3djNkSUd3eWFXZ0lDNjNYT2tERHl6dEFj?= =?utf-8?B?QlUwaVRFYVR6QUFyK2VsVERKTVlRaVJkeXF6NzlLZFBLZ0luRFl0bDNySSt2?= =?utf-8?B?V1piRDlhbU1BdDY5dFg1MGdWaWEwME1VeURKVVk2T2lSRnE0TkZDaVNHYm1C?= =?utf-8?B?aDVBUERnUUl2SVoyOTJGRW5pSXRuYkE0WmF5UmlOLzQxeUVPanMyMGJtbHNa?= =?utf-8?B?R1hQaWUrUjBSTmk2bE1iK2poTnNPZ0NuajA4SjQ5M0svbHFKdEtIZittdzFR?= =?utf-8?B?R2ZjaDNpWjdYbnFIeEpCVzZqbFlHNXFtMTVzZWlxUnNLc3kvWDlWY2tUTldC?= =?utf-8?B?L09ZeDRIa0R5LytSZ3ZRelZKREd6VE1YbkpIaW1QOU1JMU9vSnRuQm9xUjQr?= =?utf-8?B?QkZZOW1KY1d5RU02ckg5bWV5R1Q3UTlNbUJ4a0NHeE42UUpYUGFncmFkYkNG?= =?utf-8?B?S1lNejlXNnczNnJZb3orT1VQNzZWOFpKNGRncGJvNXpzQWp2TVZLOXFiZ0Y4?= =?utf-8?B?RkdGYXV0Qzl0cytVYllZMTZaY2cyRmpjZVRjT1NlRTA0cGQrVThDamdRbmRF?= =?utf-8?B?ejIxcUhpQks1OGZkZWZKeU5oY0xOaGxLMzB6ZENFR2NzVnRFT2pxdU4wT1Br?= =?utf-8?B?WFpJRFF5cit6QWVSQnJxTW9CWk82a3E2V005c0xkYllrcmNPQzRXN2NWZEVG?= =?utf-8?B?bVc2NFgxMzVvLzZFSG1tVjIyQlpIdGpsb0llcGZ3WTgxUFYvQmpscW52YWU0?= =?utf-8?B?S3RBRU92TTZMeXg5b1pjOWh1NGZUWGg2ZXZGTHdBSUxXZFdBUHFROU5zdFJM?= =?utf-8?B?elBwczRFbS9RRXZFT01hZWxzaDFyc1B4ZHhrRWUyN2cybVVKMlZnNmlER1Bl?= =?utf-8?B?NUkrTzQ1a00zTXlIZURPd3Bac1BwOHVuZjhyTEc0b1k4bllBM3RyMFhDY1FG?= =?utf-8?B?WmJrM0xUS1lweDFWSk9KS0hEdWppZ3FyeVRQK0VhRXBKbm9waU03QTVmczdu?= =?utf-8?B?bDJJb3pJVWtkam5UTjlRZVBFc0cvSG12OXV6TkZpZmtHM2IvWU5mR25ZK2RU?= =?utf-8?B?Q0trdXAybHBrZW1IdGdDZ01ERjQ4T3N0Y0pXeGxIR0Q4dFhGNzFYSWF5RFNT?= =?utf-8?B?eHBVT2ZEdS9GVmtzQXMxWlN2QlB0MFhGZWh5a01nbGRDZGNydEpoNUY5S1FW?= =?utf-8?B?MzlkbURKNlFkVWEwaWU0Uk1PZ2xoY3JZMTAzT2RZVksvSE5OMy9QMmw5aWpx?= =?utf-8?B?U1dwNkJUQm0wb0gwTTZJbGZvemM3UWYyOENhZ0s3Q0VTa3IzVkl3Wk1oOXEx?= =?utf-8?Q?znfVczISAR92QMj6bS/+vCsSl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fce4ae87-7c30-4b96-beaa-08dc10fea8d4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 10:35:12.2895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F0aA8YaNOzu3NNNxIac8FqNTq04ssMK8jVs1uBGVatEuLm+/mKSPcpaaO21Uf2fn X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5778 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/5/2024 11:32 AM, Venkat Kumar Ande wrote: > From: Venkat Kumar Ande > > Read and save the port property registers once during the device probe > and then use the saved values as they are needed. > Hi Venkat, Can you please describe what is the motivation/reason for the change? Is it addressing a functional problem or refactoring for coming feature etc...? > Signed-off-by: Venkat Kumar Ande > --- > drivers/net/axgbe/axgbe_ethdev.c | 21 +++++---- > drivers/net/axgbe/axgbe_ethdev.h | 7 +++ > drivers/net/axgbe/axgbe_phy_impl.c | 68 ++++++++++++------------------ > 3 files changed, 48 insertions(+), 48 deletions(-) > > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index f174d46143..3450374535 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -2342,23 +2342,28 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) > pdata->arcache = AXGBE_DMA_OS_ARCACHE; > pdata->awcache = AXGBE_DMA_OS_AWCACHE; > > + /* Read the port property registers */ > + pdata->pp0 = XP_IOREAD(pdata, XP_PROP_0); > + pdata->pp1 = XP_IOREAD(pdata, XP_PROP_1); > + pdata->pp2 = XP_IOREAD(pdata, XP_PROP_2); > + pdata->pp3 = XP_IOREAD(pdata, XP_PROP_3); > + pdata->pp4 = XP_IOREAD(pdata, XP_PROP_4); > + <...>