From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 23A512BC5 for ; Wed, 7 Dec 2016 15:18:12 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP; 07 Dec 2016 06:18:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39805836" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2016 06:18:09 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-16-git-send-email-wenzhuo.lu@intel.com> Cc: "Chen Jing D(Mark)" From: Ferruh Yigit Message-ID: Date: Wed, 7 Dec 2016 14:18:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481081535-37448-16-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 15/32] net/i40e: add VF vlan strip func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 14:18:14 -0000 On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Add a function to configure vlan strip enable/disable for specific > SRIOV VF device. > > Signed-off-by: Chen Jing D(Mark) > --- <...> > + > +/* Set vlan strip on/off for specific VF from host */ > +int > +rte_pmd_i40e_set_vf_vlan_stripq(uint8_t port, uint16_t vf_id, uint8_t on) > +{ > + struct rte_eth_dev *dev; > + struct i40e_pf *pf; > + struct i40e_vsi *vsi; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + > + if (vf_id > pf->vf_num - 1 || !pf->vfs) { > + PMD_DRV_LOG(ERR, "Invalid argument."); > + return -EINVAL; > + } > + > + vsi = pf->vfs[vf_id].vsi; > + > + if (vsi) > + return i40e_vsi_config_vlan_stripping(vsi, !!on); > + else if vd_if is valid, can vsi be NULL? If so this check may be required in some prev patches too. > + return -EINVAL; > +} > diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h > index ca5e05a..043ae62 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.h > +++ b/drivers/net/i40e/rte_pmd_i40e.h > @@ -187,4 +187,24 @@ int rte_pmd_i40e_set_vf_multicast_promisc(uint8_t port, > int rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id, > struct ether_addr *mac_addr); > > +/** > + * Enable/Disable vf vlan strip for all queues in a pool > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param vf > + * ID specifying VF. > + * @param on > + * 1 - Enable VF's vlan strip on RX queues. > + * 0 - Disable VF's vlan strip on RX queues. > + * > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if hardware doesn't support this feature. Is this error type returned? > + * - (-ENODEV) if *port* invalid. > + * - (-EINVAL) if bad parameter. > + */ <...>