From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0073.outbound.protection.outlook.com [104.47.40.73]) by dpdk.org (Postfix) with ESMTP id E765E5598 for ; Fri, 25 Nov 2016 11:41:37 +0100 (CET) Received: from BN6PR03CA0046.namprd03.prod.outlook.com (10.175.124.32) by BY2PR0301MB0741.namprd03.prod.outlook.com (10.160.63.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.13; Fri, 25 Nov 2016 10:41:36 +0000 Received: from BL2FFO11FD037.protection.gbl (2a01:111:f400:7c09::183) by BN6PR03CA0046.outlook.office365.com (2603:10b6:404:10c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8 via Frontend Transport; Fri, 25 Nov 2016 10:41:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD037.mail.protection.outlook.com (10.173.161.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.734.4 via Frontend Transport; Fri, 25 Nov 2016 10:41:34 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:942; Count:13 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id uAPAfWNO006856; Fri, 25 Nov 2016 03:41:33 -0700 To: Ben Walker References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-4-git-send-email-benjamin.walker@intel.com> CC: From: Shreyansh Jain Message-ID: Date: Fri, 25 Nov 2016 16:14:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479931644-78960-4-git-send-email-benjamin.walker@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131245440951471121; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(336004)(377454003)(24454002)(189002)(199003)(229853002)(39400400001)(39380400001)(36756003)(230700001)(76176999)(39410400001)(54356999)(50986999)(31696002)(189998001)(38730400001)(104016004)(86362001)(47776003)(68736007)(31686004)(81166006)(8936002)(65956001)(65806001)(8676002)(7846002)(81156014)(356003)(105606002)(33646002)(106466001)(305945005)(6666003)(6916009)(2950100002)(65826007)(110136003)(97736004)(4001350100001)(23746002)(92566002)(5660300001)(626004)(77096005)(2906002)(50466002)(64126003)(85426001)(83506001)(4326007)(39450400002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0741; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD037; 1:E8RJhxeo9Sq4aBUFdpdmabsaFFIAxu0AS9Q7FGEu2sceFD7fc/TFVD89+A+UYVDEOlIHt3EJaLDcjM5KJYBp84xm9E+nk5uMifduIssmjS7QaJxdHl2BSF/BcZ+bK++WIzwvnlOoqHIGhqrKQZ8rUwfpJs1igSkziN4AEQwlNI1wvIpEiNUel0X++eoZ8nerBMO28e9Pjd4gUndQW0F8zUR+K3GNnRjhVa8Dl9/BTeeBTRVYTgG8RdkPqKErGhHr/7pDqurBHhAC2LBFsQYnDgfcP0NWBeFo5cZ+FN3fYf68e8ryWlhb4DBa+1kbV4lZJeYl9dQcLLL8PzFqB99AMBOJ5jiorcyt549/U/qkxp/xhClvqxcRJlL+w84Q+6i/pRKEgS97h7DfKXGYii+xvllt65ZVB1myQPgd2Z8JaIxnxo+fRoVX6d3dmApG1UC+Pa01k0DR+7wtTqA/dzuiPgOpgIX4SHU1jhALgRYmw3pMuneviEME+3AjQRXNEnF7oUbu2R3UnJIZLwe23a52BxJ/jbeuaB+Rc2Xeyz4j3sqUo9HuER8auFOmbHwoZcQ7Jdv5VVHKRFtZs11i2fkR8svEnhEnAn96qzl2lLeBEt2pYKPKXl2qxppIVYXqWD5vvoqmgCi5mkoKTVon00CBXqFsksuf/fWQ06DEiOiS6WE= X-MS-Office365-Filtering-Correlation-Id: a327647f-5b49-40e1-4c11-08d4151fa0c4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 3:yBJ9vHLvvrTC9k53L0Y2u3wNRVtZV2ii0oHWqw9kSAT0F61LLpcN8TgMZvZEd+m7NKPnbMMS90V45U5CUK9uKcbMf7Tt7b6kV+fWQv1aNIKeTGUbdU7GfqgVvQkMl+R2lGIwmE5oQgBWabirTrcj17Lz60ChDPmARj0kvCL6KoI+dUoWkYqbWIU6POtgpry+uMXv6K1T3mHBwDR58pPir5Az7wr63EXy1McL5QGptfA6TCWU4+mv2pzSyAN+CQ8lQHjt4ACsgAdL8mj/f6sbTGprgdhUSsvQBRK77IvORcYxNo1vdtWi0SqpNm2khj+wWdB1clt7P7cuGU7TI6mItoDmymbISREmtPcvSCiWghl0Iih/dZRfCgWpZEbJCgHD X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 25:sTf14FS0WsUg4QOYQ+mfumZRqY8sWbyFVgDphCzizPv7BCLQW/1sn0uHnk3nL7bRP/N/bSJl0Z2sOlaoSWfwck3E32TYL+Oa9gDetlhZvORPdShdVieLZUSDp050oZKmXAK0EzmQwGhrsvLy5vm/aMOE+LqOXYU1s2cRDaucgfDtGfiB15iVf7egDjq3H9/FJF6HA0kfxSHKpQ4dNag8AzGpf1L0GAmo9Mxg4k+2f3SagPhgpm5eyyzPX4614+e6ECD3T06W6nSKttgir81DjwvUAGQytuipA69q/h8+DbtnbXOJ2JpR7HbE3cwBJh0SR18YeyIPYy0KA0q+51G9gucBpMnSMo1Wc3bSRWG80NAYkUv8aMsci3OPMTqlrcCCrrXVIQdw41sFR7PMaXjWBQL6YV/r019jw7He01PWTEaE7sPrknL5pO7Z6vFiLf7ftbWy/Mxu8R3vy1zx3QS8DMuUcykjOXGAc9+bwZjwi11FvmTvI5+MDy+RKariUzTRkWzZ6wzcmHX25NnmaJCui5xFcpYlhicYeyMfU+OuFBxQMsuDtGrWs83cwmSu9mJi+fg0PSx5zr0pGT1BbeHeiRbShZMUVI7mHqjsnIomYH+RJaYl5Il/7swHKQ5IJBJ3rURHs3YFxuTd95xKUQzpk2nJE0nSQRu2bKBSDsDfmbyKlsgNZI6AChU2hJplRQMHVW3rYIWyB5L9/fQ23sKXoAIAjyn3nm2m9WFxJEsD8HONiVstybM/V/E/zwrVIrZGPqkfY6NrVYMNubqUxb37lOODWMqSeIqhMWyWtpERWJs= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 31:rsi5L3/1Wee/NYfRB5KVmUkOSqnalwv60XV6PP00LxeG8AkWzAa8rhN1EVTADIN7B6pQgZlVx8KLrT+BiegFLw5uI399eAyT4zLf003vU8qe72OxyZKc7pWjVsr6hzcjY3FrPlzZqFGrqiuQ3bCeTYAqrQLzQ4ohCAbiZqWCBQ+LD3LJn54QQwlk4vxNWr4Nifhz30ZwERAcEPJhIg4ZtKRY5vTnd4tXRK5H2jfxRbl5u5YCda0BwP1YRHCmNiWIcpdor53YKbngAUYdwrOreQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123559025)(20161123561025)(20161123565025)(20161123563025); SRVR:BY2PR0301MB0741; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 4:MG05Vr3wbos9rvgYEwR6ydE1G5T9ool4KtRYiUOTkfz2B/1fahssAYTTXPaMGcPXq8icjWPlJSMmnoOfTS6f63Ykh2K+iu12omtmf7kk34H5Oz9rN4rcxVHLt6aPvUQCmkY4zLusbcIOmzyrsWtpBAti93vUUsHD1anQeFEgw2dd/wdb5rVBT1yxoQsAvqSpZLU+ewb+IMLDiwdU/beyOqBJZJmV02Y/nb2O+NSyO+w3EWLiiZJWEhjctWawKSJbPK9uxdFMNa3qanzm0PHrv2b1ezv27oecyxuBGo7ZKdpdWuhqNvEER2IhDLClFVJ0/FGWx10a0KGUMN297UNBpYAPAZwqYvOZ5OWcUEv0tV1zQ/SPCpIQ0B3N0gKvX4BUol80VM6zUMHCrV9LFNSf1js/B4vTi4f33ly7XEjdbzaCGp+w4OchnxVyP0cNkj7m1rCFxUADedOvbDXAy4RSeB896XRRM1obNClh2/nsLRwbE42T5UCu9nLI7519saSnibwRf5EjpgR5VDFG+aE6+w/QYQ7nKoBmslW1dowf8apc3y9y+53NNCr9SUfUXxN6YVIOX0/7poYmCUEt/rQ7U7X2cXW+qk1xLzUfImwFbipfOAIxiL9aZfMRtOV5UUoWeB24FOn4VkaS7+DZ45ifzypwDrFHx9m06RIKOVfDCJDr1wQf0pI4FX5eB+lGIbcYVfb00bIztMgoUdkR5telA5SGFEEtP7h4wjTD3O9wLQhxQ138eCMCTn0xEcONtD+z X-Forefront-PRVS: 01371B902F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB0741; 23:4phRwSvGL3bWjcp4Ih/LIwSPhy5rEh00N2m?= =?Windows-1252?Q?4xpTfRbLgfif1RcE4vMyE6U5vzZzZ6q/608rUDYVWdhBZPkWo5K+T2tb?= =?Windows-1252?Q?IgOvqY+sRyzu6k7pFzBdbqDH9COXjlrfWBQWl1ED9Qu5yEmdPktc24aa?= =?Windows-1252?Q?z594KHVRlgW9/v9jmlgzbV+nfVeGRsyIQfD4FSCpVx+ub8bhZ0uQVJvl?= =?Windows-1252?Q?tFCbPyK5ibobkf4/8+m+Zi5yZ8FDe+ztiwF3bb5iMJ5q26ThT9Aj6CjK?= =?Windows-1252?Q?J++zCwnDG5HtYQQmclh1df6PRWA2hMINbZtWurzVp3mGnzGozyIuLPwf?= =?Windows-1252?Q?GeBDYQD6PhKlOB1teybLKjuCbnD4ZK56zq96TVgiT8trJUWzxV/855Z7?= =?Windows-1252?Q?hcIDsUKtGJUf3LIIqmHWTp746NwB4TF1cfS9kSHwRPkfxBAxE1ssI0XZ?= =?Windows-1252?Q?1NQpN+UPCi7TCOGnirvU02ItmmhXX6K4NWCJCEtx/WMWarYXG1ZK8018?= =?Windows-1252?Q?pJ29lQ86zt0E2IT6vBrocRvJp6QDuTI05DWJi6kotR5oTUO+XCLCa19+?= =?Windows-1252?Q?2ret4OWhlUim+hg8DQ0AEYX78Riid+212l2WIoC1Bf73b1luxxIyBUrQ?= =?Windows-1252?Q?9O6BNV2NEq6xQCDTWRpXrrJvgXf7R63wa66o147vodhcuARvUaTTdA+4?= =?Windows-1252?Q?iKoI8/ES1WlCU3e6URwX+Z1MkdMTTdd6FdRAXcC1BSOSizNyjESRzSiZ?= =?Windows-1252?Q?2jNMAwafCGtskD0Rs6quNc030DORw47nyWPN+uLQhj4fvG5hTkp4aRJh?= =?Windows-1252?Q?SDGKbl6F85KJMmj0FonLbgbgd3NV5skYPrec7jQzaV1OvowljQwByuoE?= =?Windows-1252?Q?o4CfnsU2Uw323z4Z8WQZX4gdKy1ezXKRchVpZNXa3D6dWhQg0L1Uo6XU?= =?Windows-1252?Q?inBx2yFVNsvb7tKTDGOpvLPMM47IUdyGF+fdJtU/YdW6e5+rKNC6xYFs?= =?Windows-1252?Q?wIlu0M49Pfhi7pcGll3848rhM/5iqQRryLNty2F9MgYcpMZaU3jqvOwW?= =?Windows-1252?Q?W1QZZsShl6Ey4TcS5qJQEkTVEaPGr0+ewntC3P4eh8PprwatM1/+ZE8H?= =?Windows-1252?Q?pjifTTI60DZOaCv6Pj4Ndqwax5u80Y6xjJUnY5EePxI+NRPwn9EPx6HA?= =?Windows-1252?Q?tpvIi34U1Zg5r/LP8jExsnZ5o5Zw3H2vTNRN0ayXDM8ndj/90nUCpNuJ?= =?Windows-1252?Q?x31sX2kf3+VIaGGJOpH2FHMLGgcAAB6TVngRzFQuC+xkY+VHUDyKDhdU?= =?Windows-1252?Q?664xWdq72fnZ+5eIcuNlq9g5WjaVNSk9eeYSRpUvXa2gi2LxmNQ1JboW?= =?Windows-1252?Q?UcmJV6KGogBo44txZQ1QWCLbdOVqV0Gdd4ZH6W3Z/qZUPw/6v6u3yu6+?= =?Windows-1252?Q?w5MowpwEvQH94Pum+3GN6LQF0BGUS0/JJEkUZkC7/9mbN+4Mx1m+527A?= =?Windows-1252?Q?h0bjV+LsuZGLlIUOuSfgdsk2t0W2D5oSURo1Wkf2SoVzJIK0xxcCHhjI?= =?Windows-1252?Q?YIx3jEsp0X0HIY3U=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 6:YA/WaRM6ZhxvYam506bsGmpi7Zv0ZKX+twP8BGOQQ+MseWDXVeIG/05HUEiZIkdpYDkvA30bWG9ROz44YSdyd0ASBvHkMER9uOLlqZoLroEv2QqGLFebc8gDz/OCSC21KNMTVqPwuckh6h1cZIhT1rFC/unjIqElIO49tA0cFLnpRjga08bM9kEuFjgQQC3XVb9yUc0EPBPdUO9Ev4F/zj3oeaWzX1q5XQgfn2q7duAsgSnAIlrCWan7i6BLKhuhmMo+8VsHTi2GQJPbHuGp5QbYiV51Xb+hWGLXPQvLts8ixtlcpfv3mmZXywprUgCPzbBCRmBSxJuZvUZH9OjTRXLBS0+R7JawIdyjxlwr3ZuiV1YvH07DQCf/eMzJBTrzzx27ElUw8yPenlU9Q6D1fWjaoqlmkZd1g0uhvG5FIHOjW/PtIg6LpuD02KkvEUcT; 5:JYOL1zzX3GqYxs2LU8jKs+Rfri5tjjmrrw1JUUZAj6ulGHmw5LsTx8enA+FfIPaneJbchy9Pf4SaNNTB8vKtShMR6tql4HQWEd/Pu8catjvE91D/Ng2m04zBHIvAU8zk6rfbuUu8dHx8WIHw1KTrv7/f4gucGLz8WkqvUg96/0LsZALw6iwzDyE9Zci9TYjR; 24:/FKAj9nJH2zwZilnl3MaMxjRysASuToKfgRSe5/efbeNWkCVxUECirKIbLUWLw+A725O3SXpm85mG9UAyP7G+UfM27UuVH9gqatJUcMOMbk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 7:rBY/JtB/Tt7GwWQ94wJwqkPrzy/ySK8Rr4rad7EDkjxTksd1OFTnxwJ8rG+BAHpTJijHlhoXHPAOn7fKCzy/XiUm8u+fKD+/BtSjYg8OBqZm3ExjaJ4Cf1GAV2GO/NHVbQJ36jknxpc7oaw6wpnn9Fb07tDpX+h1kHcSSIiM2bM3dchBmhQxcL8qQ/76n/qAbNC+QUkXl5ZpBnInIJYL03UXPO/uG2vdPUc8NWFz3lS0tWm3SrLJY23zqLK/BUbOlA39g0qUNprSatugRtIRjprhXGE23Kq7kc0ZGOBDDJC6GB5AKmmDIPNs2o4WTjGpM+qJ2IOrMNfuQrWfGedE3iSRyR6+XU32KvztvMthQUnCfGgbgriZxYCJjsJWhGdeaKLqi+U06PPm+nyYNJztcBDNvZDschAlGfkImQ3gIIJ1AA0gyKRJbzyV74MthbdLKyM4NJx6O+l3HEQm/32ySg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2016 10:41:34.9755 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0741 Subject: Re: [dpdk-dev] [PATCH v2 4/7] pci: rte_eal_pci_scan now handles removal of PCI devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 10:41:38 -0000 Hi Ben, On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > rte_eal_pci_scan can be called repeatedly to re-scan the PCI > bus. If a device was removed from the system, the associated > driver will automatically be unloaded. > > Signed-off-by: Ben Walker > --- [...] While reviewing, I found that there are some checkpatch warnings on this patch: --->8--- ### [PATCH v2 4/7] pci: rte_eal_pci_scan now handles removal of PCI devices WARNING:LONG_LINE_COMMENT: line over 80 characters #76: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:490: + /* Search the device list for devices that are no longer present on the system WARNING:LONG_LINE_STRING: line over 80 characters #105: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:519: + RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" was removed.\n", WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #111: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:525: + * Unload it. */ WARNING:LONG_LINE_STRING: line over 80 characters #112: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:526: + RTE_LOG(DEBUG, EAL, " Unload driver: %x:%x %s\n", WARNING:LONG_LINE: line over 80 characters #113: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:527: + dev->id.vendor_id, dev->id.device_id, WARNING:LONG_LINE_COMMENT: line over 80 characters #117: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:531: + /* It doesn't matter what remove returns - WARNING:LONG_LINE_COMMENT: line over 80 characters #118: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:532: + * we're removing the device either way. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #118: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:532: + * we're removing the device either way. */ WARNING:LONG_LINE: line over 80 characters #125: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:539: + if (dev->driver->drv_flags & RTE_PCI_DRV_NEED_MAPPING) total: 0 errors, 9 warnings, 69 lines checked --->8---