From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FB7D42C03; Thu, 1 Jun 2023 15:43:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96AE240DDC; Thu, 1 Jun 2023 15:43:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A3073406BA for ; Thu, 1 Jun 2023 15:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685626991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZHk9x0UJfY0Km1KHH1Nk5/mtuNF182MReE+fH6BQTk=; b=gZxVl1UNjrD7NX6SoXPFSkR06SokkTrWvV5ba/E9QfFur2fkHxALyVczB4nkSygSr7mYdU cd+nzHZnpthZA7YzG3R28eO7Yd7qtZQ5f0dF5up46gRInXvibnXknHzfbpKL9XEHXujs9N lO3kznWQGaK6GzteBJMb6cfnXKujCrY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-65-NzSkAa-EMFq2y2RLy7gj-g-1; Thu, 01 Jun 2023 09:43:08 -0400 X-MC-Unique: NzSkAa-EMFq2y2RLy7gj-g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 891F61C041A8; Thu, 1 Jun 2023 13:43:07 +0000 (UTC) Received: from [10.39.208.25] (unknown [10.39.208.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E7E8492B0A; Thu, 1 Jun 2023 13:43:04 +0000 (UTC) Message-ID: Date: Thu, 1 Jun 2023 15:43:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 04/28] vhost: add helper of IOTLB entries coredump To: David Marchand Cc: dev@dpdk.org, chenbo.xia@intel.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-5-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/23 10:46, David Marchand wrote: > On Thu, May 25, 2023 at 6:26 PM Maxime Coquelin > wrote: >> @@ -149,8 +177,8 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net *dev, struct vhost_virtqueue >> rte_rwlock_write_lock(&vq->iotlb_lock); >> >> RTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) { >> - mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false, >> - hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr)); >> + vhost_user_iotlb_set_dump(dev, node); > > vhost_user_iotlb_clear_dump ? Yes, good catch! Will be fixed in v4. Thanks, Maxime > >> + >> TAILQ_REMOVE(&vq->iotlb_list, node, next); >> vhost_user_iotlb_pool_put(vq, node); >> } > >