From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3DF5A04B5; Wed, 28 Oct 2020 21:24:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10DC34C9B; Wed, 28 Oct 2020 21:24:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 5AEBB4C97 for ; Wed, 28 Oct 2020 21:24:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603916660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ijN1aeOaUO4Dx/zccLUkmtzKm6KZibIAGIJUukqAEBs=; b=dtjgC1g2xKE/k2+n16zeeMJUBz3lIgD6TVDrOYCOzHPRktWn/A4wqtRUYlDH8AOmUn3TKo FKH+KbN7xD0OUpRsRkI+d+1DaVCizVZfMEe6DqgIPf4B5kOCJrxA3QoWveHI+rxPIv9Bc/ ZH+C8IpV5zEq7xEzAwVYNNgEQON2LBs= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-XlsY2qM3PrKcDFuofUXoOQ-1; Wed, 28 Oct 2020 16:24:18 -0400 X-MC-Unique: XlsY2qM3PrKcDFuofUXoOQ-1 Received: by mail-ot1-f72.google.com with SMTP id x12so126032otq.11 for ; Wed, 28 Oct 2020 13:24:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ijN1aeOaUO4Dx/zccLUkmtzKm6KZibIAGIJUukqAEBs=; b=eggbLybxwJiL5jQyng5yPh/oRBC9L4d/xNhnU83SvhwUYNm35fB82jUvJsj+BPUz/P lffNlzPnGi6naAaIXCJhzdkbf8vplfXPLuYaTG+r6qrt3Y5S6YQ0I/3ad4KV75cwP067 tcFMLrEebbgsJO1X4EdLjoBLwNZy7XB/kdTxEIErChZ9e7lXp2bEbGfZ3uTJtZjb90WX tGTjqskR04qRWDheRxhxtmep2JhGcj1QvMvsW1DijKma74/OxyEgliM91Wv5a5BfpDmX Hhe0HBGRmAKfs622VVxka+X6NoLZZo9SaWDnfSGNXReL0cVrhTDpDxKFXkzbUy5eUVj/ BqHg== X-Gm-Message-State: AOAM5314Yky+4RIxo0F7IWxu8ZIzoEdmwfuqzR31FaF/i6f/AhXJlDqT mF2z2n28QCcUe4fn4YXhLk64gsiVLSC0OHeTH3sYdSRcSkPh/bxRhwTxd1+oKVBmLMfaxunaxs7 /gd8= X-Received: by 2002:aca:5b85:: with SMTP id p127mr613560oib.34.1603916657620; Wed, 28 Oct 2020 13:24:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdzpsjTTQ5u9Xo15YTZJaj8aX9jJJYrhbm2ZrQZSFoWTcYHLQS7GKv99adV73inxvsFls40A== X-Received: by 2002:aca:5b85:: with SMTP id p127mr613549oib.34.1603916657445; Wed, 28 Oct 2020 13:24:17 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id t16sm141099otq.78.2020.10.28.13.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 13:24:16 -0700 (PDT) To: "Chautru, Nicolas" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Cc: "david.marchand@redhat.com" References: <1603496581-35966-1-git-send-email-nicolas.chautru@intel.com> <1603496581-35966-5-git-send-email-nicolas.chautru@intel.com> <2cd1a627-1353-7ff0-3b6d-58ef3f535611@redhat.com> From: Tom Rix Message-ID: Date: Wed, 28 Oct 2020 13:24:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 4/7] app/bbdev: define wait for offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/20 9:04 AM, Chautru, Nicolas wrote: >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:33 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.goyal@nxp.com >> Cc: david.marchand@redhat.com >> Subject: Re: [PATCH v5 4/7] app/bbdev: define wait for offload >> >> >> On 10/23/20 4:42 PM, Nicolas Chautru wrote: >>> Replacing magic number for default wait time for hw offload. >>> >>> Signed-off-by: Nicolas Chautru >>> Acked-by: Liu Tianjiao >>> --- >>> app/test-bbdev/test_bbdev_perf.c | 9 +++++---- >>> 1 file changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/app/test-bbdev/test_bbdev_perf.c >>> b/app/test-bbdev/test_bbdev_perf.c >>> index f30cbdb..39f06db 100644 >>> --- a/app/test-bbdev/test_bbdev_perf.c >>> +++ b/app/test-bbdev/test_bbdev_perf.c >>> @@ -25,6 +25,7 @@ >>> >>> #define MAX_QUEUES RTE_MAX_LCORE >>> #define TEST_REPETITIONS 1000 >>> +#define WAIT_OFFLOAD_US 1000 >> Why wasn't 200 used ? >> >> Tom > 1ms is a more typical expectation for workload (TTI in numerology 0 for 5GNR and LTE). That's fine, i was only commenting because it changed. Tom > > >>> #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC #include >> >>> @@ -4451,7 +4452,7 @@ typedef int (test_case_function)(struct >> active_device *ad, >>> time_st->enq_acc_total_time += stats.acc_offload_cycles; >>> >>> /* give time for device to process ops */ >>> - rte_delay_us(200); >>> + rte_delay_us(WAIT_OFFLOAD_US); >>> >>> /* Start time meas for dequeue function offload latency */ >>> deq_start_time = rte_rdtsc_precise(); @@ -4542,7 +4543,7 >> @@ typedef >>> int (test_case_function)(struct active_device *ad, >>> time_st->enq_acc_total_time += stats.acc_offload_cycles; >>> >>> /* give time for device to process ops */ >>> - rte_delay_us(200); >>> + rte_delay_us(WAIT_OFFLOAD_US); >>> >>> /* Start time meas for dequeue function offload latency */ >>> deq_start_time = rte_rdtsc_precise(); @@ -4630,7 +4631,7 >> @@ typedef >>> int (test_case_function)(struct active_device *ad, >>> time_st->enq_acc_total_time += stats.acc_offload_cycles; >>> >>> /* give time for device to process ops */ >>> - rte_delay_us(200); >>> + rte_delay_us(WAIT_OFFLOAD_US); >>> >>> /* Start time meas for dequeue function offload latency */ >>> deq_start_time = rte_rdtsc_precise(); @@ -4713,7 +4714,7 >> @@ typedef >>> int (test_case_function)(struct active_device *ad, >>> time_st->enq_acc_total_time += stats.acc_offload_cycles; >>> >>> /* give time for device to process ops */ >>> - rte_delay_us(200); >>> + rte_delay_us(WAIT_OFFLOAD_US); >>> >>> /* Start time meas for dequeue function offload latency */ >>> deq_start_time = rte_rdtsc_precise();