From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0082.outbound.protection.outlook.com [104.47.34.82]) by dpdk.org (Postfix) with ESMTP id 752D51B2C4 for ; Tue, 10 Oct 2017 18:55:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qsuITwCP7GDHrjMpJVb16oycF53jxLk4s3sCE5ProAA=; b=AOppR6XgbK21A13nWq6wLK9k/vJet40cc0Wg4h9htaZTDL7Vt4s8JbAhP+2DVkEfGnMI9RBXjx1BJOPXPKrFPrUqTv8bsXp2NxJ37fZ1m3vBmHjfMrMB2VNIEma5/3hph7ZftiyKE5t2r0FD2sewq/ecCH7R5BIkxPBT+RuWCxw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [IPv6:2401:4900:1985:da4d:a124:6786:bc05:1a61] (2401:4900:1985:da4d:a124:6786:bc05:1a61) by CY4PR07MB3095.namprd07.prod.outlook.com (10.172.115.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 10 Oct 2017 16:55:36 +0000 To: Thomas Monjalon References: <20171010070155.17412-1-shreyansh.jain@nxp.com> <2102754.igz1rhL23C@xps> <7387c315-fd0f-a5a2-fdd9-1ae9aed69e9b@caviumnetworks.com> <1821646.02OIGBtUFx@xps> Cc: dev@dpdk.org, Shreyansh Jain , ferruh.yigit@intel.com, hemant.agrawal@nxp.com From: santosh Message-ID: Date: Tue, 10 Oct 2017 22:25:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1821646.02OIGBtUFx@xps> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [2401:4900:1985:da4d:a124:6786:bc05:1a61] X-ClientProxiedBy: PN1PR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (10.174.150.15) To CY4PR07MB3095.namprd07.prod.outlook.com (10.172.115.9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f967b20-2db3-4d3b-908b-08d50fffbc1d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY4PR07MB3095; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3095; 3:KqOz7KhGYSnFs8douwd15pgDsIrbY/7S5TMhcN2wKfAHtEUVJrGptD2g/J9KD5cDXUOm4zPEwRJmGB1uLiuBca+mOL4isOQeZdu+54cC6oquI/myxF1+4RaZAj3ZVIZ8kX4LBNPun2NZ+F8kT/asHDmv8TUI09k94ykZZwjzmcqZLBIjGbSSIPCC7aQA0sEplUKvwXGDZQeIT0LodEDuOEWE5hQ5GPl+6CT2qvoPMBOeotK+YWyXGTUx3iE6UZmI; 25:fYpucdKL/sCqhD6Ii2cZNgGPBOl9JMu+C0igfhWtEcU35E+SP52HFjv6d6kHtT4IqUz5655RC241EPHcq2sK5DdIxDZyAPmVAVqEFKp5Sxihe0/pJTpg/AxlQy8Hngw5GqyaKbhVOB8mcAJ+ImqgoEqC2wRb4/OoDmbDE0EndEgKtqZizvx2ZIlRaFYz+9KIdMsW6yTSuXOmjA+afSFC7CQ8EtOD90DVN80zsGbRUdakCk5N3eDaZ3n7sTi0HqVy0I3O1WK/s/fzm/Payuahns+6ted6b5eD6gRCilpZLptRaBsy+VBJnOoPr8Q3ej+kP9P/5kwZWMT0cJ0HQSbVGQ==; 31:KKIJ347bNxFc0cdk5KG+KJL2Sxd7eTJoY5L2llOHCWKX4g2FxDIox0HV0McMLOzoq7BHfIa85du8W3ZFDwuUgOaWVAkJhIbjAWKiMGvTW4FsfDz2/dmJ+6vImxqmkFqa2KYKP08a8KHey5MiCLkbTDkqu1e46mm2MrFUUxMY1Ut+3QQarGNfpqpnGQ39DTgzAIRXNW5kriCGLrfiewp6OfdzV9Ho+ZKynwf1zpgR/OI= X-MS-TrafficTypeDiagnostic: CY4PR07MB3095: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3095; 20:cfZrRb169sDGdf+22NwS/LkLYsMbTv409Mk0VZvdavgGTsFRojfOumVAz+arMCpm/O3x4ljh5Lk8sRAmUptkvlWUVjqfUNd4v+V//c1Q23TmzoSwq5n1GFFJ4tidsAwTFHetaprns7a0OTk1L+qaqdON0TVwaVQLFNVmEgoTfFY2t1ONG/Y7GM6TG+gVwsRuHDBBCfQbiq4+v5U4Aa1RnG0UfEm55kLSsrV9yth86DPxUK+rPZAn191OxWjGtIscQQBct1VJSudyHQ/ik82fRnFwdUbA+AoqjqtcOPUtRDQtjyot/BR7y7aPJV9Mh6za2mwioHyQ+p+XrffsVzN1khXlR1vcHpX9HhjYK40g0T39VxB29YQxLmycbc2JOOmUx8lTfOGja8nVpP0HaIx6h4Ufzhh1CTItTbc97OoCW2XjiqpCiaiUkpRJLKUK1xQcWIKqx9jGKO3Xgo//V38fMoVPHveXB9dbTjzRB38Xn2IKnzRu9SABTwt4vDMDd4j2e6VThDO18Lc4ftSJ233GOd+NdEF4wrwIIxn4c2A3x0Lvd1UtPegWmHbGUIYUta94oxtoYRV3cCF9yBWmfRPXI6mYwqUtYsuq8qpbAEjAJDI=; 4:i0/lJcva2y4CaaolRPdpt/LUERgklpesvFZnJfe4uFoakqxQI8C2p0Dj/7E0Pv4nZWb02HUjgPtxvsIgzD6RE9nRAuDw12ixTxnPD5xHKQ6hM7bHFSxDfQUrnEWcIZagLFrhXC9nIcggOIjwBbaf5zutX3RlzRHu562eooTQXtV7KtusgxeJJKXDvTBzMJ7qg5RDx9Bk1woQUdBN6t19ct9HQGfj2kps36bj2yPX+kYTMvxvvV7XKiKoPPs725lcUqRlhv1dp2lJjmqktPgoLWJQEzH2P0p4d4Ycf4XRCDA= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(3002001)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3095; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3095; X-Forefront-PRVS: 04569283F9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6059001)(376002)(346002)(377454003)(24454002)(189002)(199003)(25786009)(81156014)(81166006)(8676002)(8936002)(2950100002)(42882006)(4326008)(6246003)(7736002)(305945005)(8656003)(5660300001)(65956001)(65806001)(47776003)(6916009)(101416001)(86152003)(58126008)(83506001)(23746002)(53376002)(229853002)(316002)(50986999)(53936002)(76176999)(6306002)(54356999)(65826007)(50466002)(33646002)(105586002)(106356001)(31686004)(93886005)(6666003)(64126003)(36756003)(31696002)(478600001)(68736007)(966005)(6486002)(1706002)(72206003)(230700001)(189998001)(97736004)(2906002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3095; H:[IPv6:2401:4900:1985:da4d:a124:6786:bc05:1a61]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR07MB3095; 23:WRcwsXpybzSmTSjXZGFwQ7WXCDlbgWoEktsvZ?= =?Windows-1252?Q?C1GqrMYkGDXv2AaKFM9nmc6X/BXTIGbtIgOR4coTo5EVdNd8i9u4Z+yf?= =?Windows-1252?Q?ZD7dbRiA1gRHjS52ugejZb1RhE7h5lWXrqwEW5mEq1ry32VQKOaU2Ktk?= =?Windows-1252?Q?kRgfb4+0c3QvH/EXHpzXGzBpGcziF84dGBSvQ8dBJCOBWti5K5lR27YE?= =?Windows-1252?Q?J7MLZculPWHjlZblw4eU/mnIYy5+JzaMoncRCsDD/Aky/Sn8ESTtaLpn?= =?Windows-1252?Q?EM+bve6+I43SV9Lq9bch4mZnY8DJecgKyFPpQ/V2TLlXOGFv3po+qkQA?= =?Windows-1252?Q?ULwHvF389zowxTSUQo0JzWofXGB/2cUrLBeSQF0xEMpWBvB2FMUZk0ll?= =?Windows-1252?Q?N4oB8pqiGDRnmxiO5Y3HC+/hTkkIs8KZKuLSoqqM2ZR88ojmckEsl4RP?= =?Windows-1252?Q?nnEguUNViJ8Ld62HjRH1/sPXwNd24NkkVf6JiLNguXUxxxE47qi9A7ri?= =?Windows-1252?Q?WRG/VZlIgg2F0w8/5n3hH7+/wPxFJLv2IIvT9jw1EbY+c9TbdzLfwk6f?= =?Windows-1252?Q?XNvrOfMd8kQ8kTDhAE6fEUmYUjCW1fWSku4E5GK69QIu6uJuU3xpkCOV?= =?Windows-1252?Q?fEs33+aHJF17zQJkT2A626NL9Otmq3UhZ9+dlXSEKmNiliA58Zv73BEk?= =?Windows-1252?Q?vehnzemochodBaSdDENbLAptfyaGX7Xh80K5K0TwfgPMc/cmnJXm8HWa?= =?Windows-1252?Q?mUYhrxlWa3zROtWCJGNHroXVDFq1ChJtgkb1ik2DXalTCEl1wZ/eozA0?= =?Windows-1252?Q?9FmrIIIC5AV9uWTN0HX8R3Mg+pNlgsraS1zdeNa2tQ4W/syPDPSsKcL9?= =?Windows-1252?Q?M0iH5p7EONwmfId1QVo0vvjSL8qD1KSIvrhjoGTjlhk+3KAf4PHb7KJT?= =?Windows-1252?Q?y+cnfgsRnm7kos/kY1mrA7IInA6DV8nC52lyonM6WjG7e7eGSxTDTlaH?= =?Windows-1252?Q?gRREprssyGUsuuhb9XmxseSZD5LXnK7GBsbZee9mDehmQDoQa+il7GzT?= =?Windows-1252?Q?k8GmGKeWT+VCTN2/R8QTmyD/1dOgvib00cbyLtWlomvKnuGmY/ZAGOZj?= =?Windows-1252?Q?o9PkrTDtuhVRGSHrjDO+gxVju/LdZanM6M0NM2925knt97mWne7LfVkL?= =?Windows-1252?Q?5nGKSM5EHZfxE82vU5s8bRJoD0fkR09S/rRUU9AaXtC3jun9mxcnYegF?= =?Windows-1252?Q?lBRD2knSsPneCqYG0YU6TOpqLF2Wp8Ax/cZZDJTIgybmwFquM2rvqXkR?= =?Windows-1252?Q?HkXk2dtarQlll9HvccTZj29NMkLZVOgV6K86VYQcL2xBjSaVwCaoPK1W?= =?Windows-1252?Q?5aCWI9IRkFo025DQCKJ64+sVGDvwDA+fX5dV0Qa8oI9FqNAJySu2TAdG?= =?Windows-1252?Q?ScIFI5FqcE7VWMNabDcMoL3iHwYl4uNzwv3HXSxb+dnVD8SGjzLTgZbF?= =?Windows-1252?Q?Jf3Ifc=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3095; 6:j7EeyfGF0tHv92bXAz78iEUUk1L0M1C7wACqPxGHwt4rd/vmXhCXbcHF1KwsUOxMkFB1ANK9xz/KuzANzL065AI83VxNrbi8XfSPSsoUjO9hIeGsSEiv/Eed4Gq6WnFSyPs3J47qMPV2YmSx6l+8h8D8kEBBjLDbKUDOVblMHivhlkkvREvIZuzuGavxZQuKhzY2oWeGdQPVbh8E9jGR9k4ciZRigMVi03yZw6WbSQRK4FHFmlxKnZljDBEmerdNfuLM8PEGgQ/nTF7vMt0RQ/OM5EJmoYJakhhXnwaDso/n+SNgWMZpeobveRglMTVCyT3y0uTqgzjejboVLnXAEg==; 5:GrsS+hODODY6glSHJOmhnvvKcTWNXvaCu58+hIBEDbYRqN+Oiz5s7HOYhFA/g4bpx79CXNOcjFh1rVR1W3Oin39K2gxx8FJjV3Uv5tbrL5j8ykq1dGi3pay/ZhR6rvLy16e8h11aQWh62dl4mL8gzEMVaqWQT7XiUO0uBwWoVQI=; 24:8Q9u8eOIAygInP0OB8UGadZTx3uLNiMrHDkOmWdiRRUg9I8BThCNhR+rcPQKOotKJNfMi29glsdxAsh2BuAgn1x9oggirqmNmzKchFO1l3M=; 7:hKGhEouvAJ6S0DnLzxoLP7N5Oakw0IIzjN1gUexABiEWHdG3ykYbdhFi74XFfmBUDsY+94H9pfInmZqSEUJjNIOWPhHFiRsj1K9c/JVB6ZrmniRk06uLNZsGlWIIqDhB7TR9qcLpWyhk+JGOuQcbwg3NyiPvx4wmhdpvjP0aGDnae+H/h+bvkgkTftkOl00t1OpRQsJkzarIsQKjUbvq1Zm11Otx5UII/EH6268YDbo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 16:55:36.2893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3095 Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 16:55:41 -0000 On Tuesday 10 October 2017 09:47 PM, Thomas Monjalon wrote: > 10/10/2017 16:05, santosh: >> Hi Thomas, >> >> On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: >>> 10/10/2017 09:01, Shreyansh Jain: >>>> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") >>>> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") >>> These lines should appear after the explanation. >>> >>>> Cc: shreyansh.jain@nxp.com >>>> >>>> With the IOVA auto detection changes, bus scan is performed before >>>> memory initialization. DPAA bus scan must not use rte_malloc in >>>> its path. >>> If the scan has been broken by IOVA detection, you should reference >>> IOVA in Fixes line, not DPAA. >>> >> hmm.. IOVA not breaking scanning!, Refer this [1]. > It is breaking. A break is a behaviour or interface change. > When moving init order, you break behaviour. > I don't say it is bad. > I say only it is the primary cause of this change. disagree!. Why so: Legacy PCI/bus scan implementation don't use rte_ lib as they don;t need to.. Refer [1] for detailing. However, dpaa is and that we agree to align with legacy. So its a open question : Who fixes who? > The Fixes: line is also a help when backporting patches. > This patch needs to be backported only if IOVA patch is also backported. IMO, would prefer backport: rather fixes: tag in above case, more verbose I guess. >> We(me/hemant) has discussed about same on thread[1] and agreed to >> do respective changes and remove rte_ memory dependency from code base >> at scan time.. >> >> Thanks. >> >> [1] http://dpdk.org/dev/patchwork/patch/26764/ > You already discussed about this issue, fine. > > Santosh, as you insist to talk again about it, one more comment: > > It is very good to have discussions on the mailing list. Thanks, That makes me think that I didn't break, indeed did what was needed in agnostic way. > It would be perfect if all these informations were explicitly given > in the commit messages. > For instance, saying that the scan cannot use rte_malloc anymore is > a valuable tip for other developpers. Agree, but scan wasn;t using for PCI/bus case.. so one can;t be sure whether to mention or not..