From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 52B662C60 for ; Mon, 18 Mar 2019 18:15:28 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id n19so13832379wmi.1 for ; Mon, 18 Mar 2019 10:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=jHlyyrLXsvraVcBT803dDPVQPQTDoldNhv8PWwsJ+V4=; b=p6hBsiOtvZ42Nkd5GimI7e37fp+3CcjAm1OHL0nlIBX95pNZ1PsSBbiJB2Ql2P8HtA EgkbkdpDuFAemV5iMZ09HO0Rtv4fIqm+C62O+i5WzvtPX+GJs0OJEir6k8+m+q0p1LzZ 2XYrC2fh0eG0aW+2YjoS1qn773HvxWfe+AQlB+4bnO6NaVJWBVk7oJCqWrG6P5iUr0Hv qx/WrH+6YqJau9O67moRpVayypsNPCEgh6HtttRG0uj+TOW50VElt3a0eJNfJ9R94McZ G/8VFSTSjv1bZwPQ2sdhWJgAj47FjJMUd5zoh+zNOxVL8SuuWnIIOZQ0MSMxcRIaXzb3 qdVg== X-Gm-Message-State: APjAAAU3k+Vyol+uzqYXr2UDXJc+9XaSTCytVRYhTTlJMvCXVihT6PQ6 xAh4tOynl4lDe3na11gAWeU= X-Google-Smtp-Source: APXvYqxKbl03pIGH1kGgbzlqFmi5k+aP9j9njR+qAnd1qr7SrMnC4JStk0rcZaskftmjeQQb3Nwj4g== X-Received: by 2002:a1c:e70d:: with SMTP id e13mr161977wmh.78.1552929327882; Mon, 18 Mar 2019 10:15:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id z7sm3822954wmk.8.2019.03.18.10.15.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 10:15:26 -0700 (PDT) Message-ID: From: Luca Boccassi To: Jerin Jacob Kollanukkaran , Thomas Monjalon , Bruce Richardson Cc: "dev@dpdk.org" Date: Mon, 18 Mar 2019 17:15:25 +0000 In-Reply-To: <20190318162804.28974-1-jerinj@marvell.com> References: <20190318162804.28974-1-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 17:15:28 -0000 On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob >=20 > Remove the following meson build warnings >=20 > 1) WARNING: Project specifies a minimum meson_version '>=3D 0.47.1' > but uses features which were added in newer versions: > * 0.48.0: {'console arg in custom_target'} >=20 > 2) config/arm/meson.build:153: WARNING: Trying to compare values of > different types (list, str) using =3D=3D. >=20 > Signed-off-by: Jerin Jacob > --- > config/arm/meson.build | 4 ++-- > meson.build | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 8e892fa77..170a4981a 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,8 +116,8 @@ else > cmd_output =3D > cmd.stdout().to_lower().strip().split(' ') > endif > # Set to generic if variable is not found > - machine =3D get_variable('impl_' + cmd_output[0], > 'generic') > - if machine =3D=3D 'generic' > + machine =3D get_variable('impl_' + cmd_output[0], > ['generic']) > + if machine[0] =3D=3D 'generic' > machine =3D impl_generic > cmd_output =3D cmd_generic > endif > diff --git a/meson.build b/meson.build > index 69833de82..f1abf1e59 100644 > --- a/meson.build > +++ b/meson.build > @@ -5,7 +5,7 @@ project('DPDK', 'C', > version: '19.05.0-rc0', > license: 'BSD', > default_options: ['buildtype=3Drelease', > 'default_library=3Dstatic'], > - meson_version: '>=3D 0.47.1' > + meson_version: '>=3D 0.48.0' > ) > =20 > # set up some global vars for compiler, platform, configuration, > etc. Bumping minimum dependency requirements needs an approval from the tech board. Incidentally we just got it, and the bump to 0.47.1 just happened. You can remove this and ignore the warning about the console arg - it's harmless if ran on a previous version which does not support it. --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7BAABA05FE for ; Mon, 18 Mar 2019 18:15:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EA92324D; Mon, 18 Mar 2019 18:15:29 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 52B662C60 for ; Mon, 18 Mar 2019 18:15:28 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id n19so13832379wmi.1 for ; Mon, 18 Mar 2019 10:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=jHlyyrLXsvraVcBT803dDPVQPQTDoldNhv8PWwsJ+V4=; b=p6hBsiOtvZ42Nkd5GimI7e37fp+3CcjAm1OHL0nlIBX95pNZ1PsSBbiJB2Ql2P8HtA EgkbkdpDuFAemV5iMZ09HO0Rtv4fIqm+C62O+i5WzvtPX+GJs0OJEir6k8+m+q0p1LzZ 2XYrC2fh0eG0aW+2YjoS1qn773HvxWfe+AQlB+4bnO6NaVJWBVk7oJCqWrG6P5iUr0Hv qx/WrH+6YqJau9O67moRpVayypsNPCEgh6HtttRG0uj+TOW50VElt3a0eJNfJ9R94McZ G/8VFSTSjv1bZwPQ2sdhWJgAj47FjJMUd5zoh+zNOxVL8SuuWnIIOZQ0MSMxcRIaXzb3 qdVg== X-Gm-Message-State: APjAAAU3k+Vyol+uzqYXr2UDXJc+9XaSTCytVRYhTTlJMvCXVihT6PQ6 xAh4tOynl4lDe3na11gAWeU= X-Google-Smtp-Source: APXvYqxKbl03pIGH1kGgbzlqFmi5k+aP9j9njR+qAnd1qr7SrMnC4JStk0rcZaskftmjeQQb3Nwj4g== X-Received: by 2002:a1c:e70d:: with SMTP id e13mr161977wmh.78.1552929327882; Mon, 18 Mar 2019 10:15:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id z7sm3822954wmk.8.2019.03.18.10.15.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 10:15:26 -0700 (PDT) Message-ID: From: Luca Boccassi To: Jerin Jacob Kollanukkaran , Thomas Monjalon , Bruce Richardson Cc: "dev@dpdk.org" Date: Mon, 18 Mar 2019 17:15:25 +0000 In-Reply-To: <20190318162804.28974-1-jerinj@marvell.com> References: <20190318162804.28974-1-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190318171525.rHLLO8XSZ_LxOHql6UwgAhU-AlJxhGwqq0ZlKTaYzZE@z> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob >=20 > Remove the following meson build warnings >=20 > 1) WARNING: Project specifies a minimum meson_version '>=3D 0.47.1' > but uses features which were added in newer versions: > * 0.48.0: {'console arg in custom_target'} >=20 > 2) config/arm/meson.build:153: WARNING: Trying to compare values of > different types (list, str) using =3D=3D. >=20 > Signed-off-by: Jerin Jacob > --- > config/arm/meson.build | 4 ++-- > meson.build | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 8e892fa77..170a4981a 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,8 +116,8 @@ else > cmd_output =3D > cmd.stdout().to_lower().strip().split(' ') > endif > # Set to generic if variable is not found > - machine =3D get_variable('impl_' + cmd_output[0], > 'generic') > - if machine =3D=3D 'generic' > + machine =3D get_variable('impl_' + cmd_output[0], > ['generic']) > + if machine[0] =3D=3D 'generic' > machine =3D impl_generic > cmd_output =3D cmd_generic > endif > diff --git a/meson.build b/meson.build > index 69833de82..f1abf1e59 100644 > --- a/meson.build > +++ b/meson.build > @@ -5,7 +5,7 @@ project('DPDK', 'C', > version: '19.05.0-rc0', > license: 'BSD', > default_options: ['buildtype=3Drelease', > 'default_library=3Dstatic'], > - meson_version: '>=3D 0.47.1' > + meson_version: '>=3D 0.48.0' > ) > =20 > # set up some global vars for compiler, platform, configuration, > etc. Bumping minimum dependency requirements needs an approval from the tech board. Incidentally we just got it, and the bump to 0.47.1 just happened. You can remove this and ignore the warning about the console arg - it's harmless if ran on a previous version which does not support it. --=20 Kind regards, Luca Boccassi