DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>, dev@dpdk.org
Cc: fiona.trahe@intel.com, ray.kinsella@intel.com,
	akhil.goyal@nxp.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function
Date: Thu, 7 May 2020 12:05:58 +0100	[thread overview]
Message-ID: <f92f9408-0c06-fb93-c99a-2a4080e80efe@ashroe.eu> (raw)
In-Reply-To: <20200507105703.11804-2-arkadiuszx.kusztal@intel.com>



On 07/05/2020 11:57, Arek Kusztal wrote:
> This patch adds versioned function rte_cryptodev_info_get()
> to prevent some issues with ABI policy.
> Node v21 works in same way as before, returning driver capabilities
> directly to the API caller. These capabilities may include new elements
> not part of the v20 ABI.
> Node v20 function maintains compatibility with v20 ABI releases
> by stripping out elements not supported in v20 ABI. Because
> rte_cryptodev_info_get is called by other API functions,
> rte_cryptodev_sym_capability_get function is versioned the same way.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> v2:
> - changed version numbers of symbols to 20.0.2
> v3:
> - added v2/v3 informations
> - changed version numbers of symbols to 21
> v4:
> - fixed clang build by movind binding default symbol
> - implemented mailing list comments
> - added abidiff tool suppression entries
> v5:
> - fixed meson build
> 
>  devtools/libabigail.abignore                   |   8 ++
>  lib/librte_cryptodev/meson.build               |   1 +
>  lib/librte_cryptodev/rte_cryptodev.c           | 147 ++++++++++++++++++++++++-
>  lib/librte_cryptodev/rte_cryptodev.h           |  34 +++++-
>  lib/librte_cryptodev/rte_cryptodev_version.map |   7 ++
>  5 files changed, 191 insertions(+), 6 deletions(-)
> 
[SNIP]

Acked-by: Ray Kinsella <mdr@ashroe.eu>

  reply	other threads:[~2020-05-07 11:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 10:57 [dpdk-dev] [PATCH v5 1/2] cryptodev: add chacha20-poly1305 aead algorithm Arek Kusztal
2020-05-07 10:57 ` [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function Arek Kusztal
2020-05-07 11:05   ` Ray Kinsella [this message]
2020-05-09 21:11     ` Akhil Goyal
2020-05-11  6:12       ` Ray Kinsella
2020-05-11  7:47       ` Ray Kinsella
2020-05-11  8:18         ` Akhil Goyal
2020-05-11 11:38           ` Akhil Goyal
2020-05-11 16:09           ` Ray Kinsella
2020-05-07 18:12   ` Trahe, Fiona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f92f9408-0c06-fb93-c99a-2a4080e80efe@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=ray.kinsella@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).