From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DA7841B7B; Thu, 12 Oct 2023 14:52:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C4104028C; Thu, 12 Oct 2023 14:52:44 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2080.outbound.protection.outlook.com [40.107.13.80]) by mails.dpdk.org (Postfix) with ESMTP id 0F0794028A for ; Thu, 12 Oct 2023 14:52:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfR0RxBQ+2rRFM/pZrtTJ03koUjEdq5yOVk/oHW6pjM=; b=aSw0lf1rwdtUSyDWKwKErrJOuBcSRkZIuqt9KlZtT6TDp1qcl+lcOOhkYyu+eRdfcxMvZ46i6nUB7PG4BDzk521uWIHhj53jcn/uFXlPVkfCY7L7gmBRsuC4a7uwqT8fUnjxiRmsJDNZ7/9R21cLiGcQGESfiNUjIlrwzPzsBGI= Received: from DU6P191CA0044.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::24) by DBAPR08MB5687.eurprd08.prod.outlook.com (2603:10a6:10:1b1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Thu, 12 Oct 2023 12:52:32 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:53f:cafe::a9) by DU6P191CA0044.outlook.office365.com (2603:10a6:10:53f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Thu, 12 Oct 2023 12:52:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.27 via Frontend Transport; Thu, 12 Oct 2023 12:52:32 +0000 Received: ("Tessian outbound d219f9a4f5c9:v211"); Thu, 12 Oct 2023 12:52:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4b2f990d13bc088e X-CR-MTA-TID: 64aa7808 Received: from e67ab16eb494.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 205AE21F-81E2-4F45-99B3-D67F0B4A1542.1; Thu, 12 Oct 2023 12:52:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e67ab16eb494.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Oct 2023 12:52:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtEwwCO7SFLXM4z7/rZc9Ya02o8oIBZ9CKWtn/p4Cql7/FKZchOrQXpESbEzBLoDnfv6wu34EFK9gJXWxs/aoVmFiAYZbwCh1ScM2l4bNiXfjqefvD7K5PKf1HwrlFDrhJBo6EV36yN48w+7f3zuyZByMn0Cirx5JgcLtaPRqMCB7wPrYqcjUA+38i+lvU2jIHvMctEkeyRfzBod5Y8Or4ugtBhavT5x7EOfAIgGAMY4xi/FRhS6vF5FEp63ObjCCCyBPTsbnlI4A/vxT1pcmVm/3EUNdpRZDYdzFCbJzuDI1+2I34ndy5bGTvNxuDKmOkuaQ4zo0sl6pYKK0EwFKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfR0RxBQ+2rRFM/pZrtTJ03koUjEdq5yOVk/oHW6pjM=; b=elUghyFWZyN1LEy+7qx8IakbG/9fOZ4i5LhtUEDfeoFDl+PVH0fYXRuzVAwR9HJpStihRwUhe0cTX+Yy7KJgtXNMrKhj5He2fp07YA/o0C5JuVSrGLtOyAF6KgZgDj2M8Hd2r+jJL4LnA3xw35ecTKHRisXbivLtPAj2udgbywg0ENcZ0Ihivun72Le3YISsHdO9MmcMOmu0LC917o6I9K3jap1+wD24P7iaUjliwCeX/SScrB0ivnHhneHShYK4n+1Po3V/25TbQ0VEkqPcNgaxxJsS7BLtEvkbFE9hRm4b7HiilWD0D1xZfdEFwGUPvw7Xe4bH0urtju0n1caqyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfR0RxBQ+2rRFM/pZrtTJ03koUjEdq5yOVk/oHW6pjM=; b=aSw0lf1rwdtUSyDWKwKErrJOuBcSRkZIuqt9KlZtT6TDp1qcl+lcOOhkYyu+eRdfcxMvZ46i6nUB7PG4BDzk521uWIHhj53jcn/uFXlPVkfCY7L7gmBRsuC4a7uwqT8fUnjxiRmsJDNZ7/9R21cLiGcQGESfiNUjIlrwzPzsBGI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) by GVXPR08MB8233.eurprd08.prod.outlook.com (2603:10a6:150:3f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 12:52:23 +0000 Received: from DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::7e:f225:af56:ae16]) by DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::7e:f225:af56:ae16%5]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 12:52:23 +0000 Message-ID: Date: Thu, 12 Oct 2023 13:52:21 +0100 User-Agent: Mozilla Thunderbird Cc: nd@arm.com, dev@dpdk.org Subject: Re: [PATCH v3 1/2] doc: increase python max line length to 100 Content-Language: en-US To: =?UTF-8?Q?Juraj_Linke=C5=A1?= , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, stephen@networkplumber.org References: <20230926121013.23351-1-juraj.linkes@pantheon.tech> <20230928121830.62608-1-juraj.linkes@pantheon.tech> From: Paul Szczepanek In-Reply-To: <20230928121830.62608-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0450.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::23) To DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB4PR08MB8151:EE_|GVXPR08MB8233:EE_|DBAEUR03FT059:EE_|DBAPR08MB5687:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f8c646-53c0-4d66-d32c-08dbcb221987 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: w3nGVyJTgVvWNC/UdJt2YZAXRYMmfXpXa1iu8nRX4ZezHPaOJHc2nsnSaRfBqUxvbE8JokXKSkSednPMO8yj3506LHsUXmzNgiK40VZ3fU5Krt9osajgnSGxD7Jv1XQB3EsLwguafSvtXocWF/tbJEDbanJT1rird24pY7tPKU+OSCnkysyOwNJOtMHx1BYYsxKlbgCNjJN2FzanWnB4hhe2kRt+h7d+Ed2Zd2/V6vvzWSpI7Uky4FHFB3wDV2Zf6gMGA3s6zTMcDCPxLJrMYgf5cqgWo7i+TWrC/VpEKlxOFjNA42M/839QsgOaJVpfy998NC75qcZlhRlo2UEKEkyNybt18UODio1GJFn7Z4TvYv4Z7QITy3njZQC9PWsbhXiH/RZwwBZvCit9tTWzmUSi5Go1gk/WuNlS8Xv2aKTrK0j3HwaCJg1K9McT69R1kVr8YsprH+LWlhVXm4PfOBUJPYHIdVyQbsqtjOvvwfsCb5zC9snhc7BznQ2MmTc7u97JYbRQDZHTfjnmu++ChKWEis9hMT901BnehU8BawYBIDhr1Owo777mztzLWjsxw6hdiINQPWnhfomd3CSbzNgDZLpvQesrbtCEMoBlUee3HBw//Lsd7+B+9DTsQgkx X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR08MB8151.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(366004)(346002)(376002)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(2906002)(86362001)(36756003)(31696002)(38100700002)(316002)(2616005)(66946007)(66556008)(66476007)(41300700001)(26005)(31686004)(966005)(6486002)(6506007)(6512007)(53546011)(478600001)(5660300002)(83380400001)(44832011)(4326008)(8676002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8233 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f8808aba-3f6b-4c29-0a04-08dbcb221455 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v91nToBBCOPLrexCll4ZKXIx95TX7Jm1RdXdYx3JzzLbf1kiPyRxgGKcDp3cn0AwcKiGub5nGnR7Putd4lFIhqi+17UXEDfUUD7bS3hHLiICSSo97WbY3vwCYrBGlqozFidW+k+0ySSwcXUEJZROF2BlxSSHGeiMNv6/U3HxJ95QfpwDdrCKPSM3BFBNn5YdL084JB40PsFnahQGhyippnSln3fUoCQm2+69Gky4qH2MGWmJvmXnebjEVCau0EPoL0LwPhKJUbYD97PxsQ1MGzkBIvVz/rxoCSOZIv4EwBn36ZjMYX6DaaQeUzgjJHsL0DPGhBg7wIlzG7XOnhcTQqnN2jmUsxp3QboZCRKjDgPAZn8r6N7E/uy2JDdjszQJwI5L4mmeThe63g3a5CooTUkeMdDts8HekEZsnX3i9SGsBR/ChVUkCMpF7bWaa5EoX2NBVdTRcJLtUMWS+l7Y4JQ/Fw6Tczbq9ySuh/QxEmPrXnhGqAM4nE/A4zlQnLayVolXDlxdxhfoKP/7jnzQ9D3NyqUW292yn9fd31Yom7Ij0rg9dVwFhbBaH4uOmYgE+Zuth7FGDaaSeFLuBmTa19ce7i4RC63lErvuy9FTIqrcev8w9c+xNh6Xoinuxf4/2BIVsPm8q8i8KewcDyaQmgY5N20Etl+eyGyjHtD7EEP0vMaNM9/fs52vrFyHjvlU6jz8OSSDYFFssUXDePrUpW2BiaXnLOlFAItfC91Iur0= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(39850400004)(346002)(376002)(230922051799003)(82310400011)(1800799009)(451199024)(64100799003)(186009)(46966006)(36840700001)(26005)(6486002)(31686004)(6506007)(70586007)(70206006)(2616005)(316002)(83380400001)(44832011)(5660300002)(41300700001)(336012)(8676002)(4326008)(8936002)(53546011)(966005)(478600001)(6512007)(47076005)(2906002)(40480700001)(31696002)(82740400003)(356005)(81166007)(36860700001)(36756003)(86362001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 12:52:32.0715 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28f8c646-53c0-4d66-d32c-08dbcb221987 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5687 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 28/09/2023 13:18, Juraj Linkeš wrote: > Unify with C recommendations which allow line length of up to 100 > characters. > > Signed-off-by: Owen Hilyard > Signed-off-by: Juraj Linkeš > --- > .editorconfig | 2 +- > doc/doc_build/meson-private/meson.lock | 0 > doc/guides/contributing/coding_style.rst | 3 +++ > dts/pyproject.toml | 4 ++-- > 4 files changed, 6 insertions(+), 3 deletions(-) > create mode 100644 doc/doc_build/meson-private/meson.lock > > diff --git a/.editorconfig b/.editorconfig > index ab41c95085..1e7d74213f 100644 > --- a/.editorconfig > +++ b/.editorconfig > @@ -16,7 +16,7 @@ max_line_length = 100 > [*.py] > indent_style = space > indent_size = 4 > -max_line_length = 79 > +max_line_length = 100 > > [meson.build] > indent_style = space > diff --git a/doc/doc_build/meson-private/meson.lock b/doc/doc_build/meson-private/meson.lock > new file mode 100644 > index 0000000000..e69de29bb2 > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > index 648849899d..a42cd3d58d 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -880,6 +880,9 @@ All Python code should be compliant with > `PEP8 (Style Guide for Python Code) `_. > > The ``pep8`` tool can be used for testing compliance with the guidelines. > +Note that line lengths are acceptable up to 100 characters, which is in line with C recommendations. > + > +.. Presumably the bare ".." is some accidental leftover markup. > > Integrating with the Build System > --------------------------------- > diff --git a/dts/pyproject.toml b/dts/pyproject.toml > index 6762edfa6b..980ac3c7db 100644 > --- a/dts/pyproject.toml > +++ b/dts/pyproject.toml > @@ -41,7 +41,7 @@ build-backend = "poetry.core.masonry.api" > [tool.pylama] > linters = "mccabe,pycodestyle,pyflakes" > format = "pylint" > -max_line_length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length > +max_line_length = 100 > > [tool.mypy] > python_version = "3.10" > @@ -55,4 +55,4 @@ profile = "black" > [tool.black] > target-version = ['py310'] > include = '\.pyi?$' > -line-length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length > +line-length = 100 The rest looks good. Wholeheartedly support longer line length.