From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0089.outbound.protection.outlook.com [104.47.37.89]) by dpdk.org (Postfix) with ESMTP id 25BA4F72 for ; Fri, 25 Nov 2016 10:22:56 +0100 (CET) Received: from BN3PR0301CA0068.namprd03.prod.outlook.com (10.160.152.164) by DM5PR03MB2473.namprd03.prod.outlook.com (10.168.233.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.13; Fri, 25 Nov 2016 09:22:54 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::141) by BN3PR0301CA0068.outlook.office365.com (2a01:111:e400:401e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8 via Frontend Transport; Fri, 25 Nov 2016 09:22:54 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.734.4 via Frontend Transport; Fri, 25 Nov 2016 09:22:53 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:938; Count:13 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uAP9Mpeo004565; Fri, 25 Nov 2016 02:22:52 -0700 To: Ben Walker References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-2-git-send-email-benjamin.walker@intel.com> CC: From: Shreyansh Jain Message-ID: Date: Fri, 25 Nov 2016 14:55:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479931644-78960-2-git-send-email-benjamin.walker@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131245393738610782; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(336004)(3190300001)(339900001)(189002)(199003)(377454003)(24454002)(356003)(50466002)(5890100001)(8676002)(81156014)(31686004)(81166006)(83506001)(85426001)(189998001)(6666003)(2950100002)(7846002)(92566002)(6916009)(110136003)(64126003)(65826007)(229853002)(8936002)(104016004)(77096005)(105606002)(38730400001)(33646002)(68736007)(305945005)(54356999)(76176999)(47776003)(23746002)(65956001)(50986999)(4001350100001)(86362001)(65806001)(5660300001)(97736004)(69596002)(2906002)(230700001)(31696002)(36756003)(106466001)(626004)(4326007); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2473; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:I+OZ9lFa1HMUjCoixAZpeRE45Yd+DRse96uzYQd+CIrLMDUXhTMdTOfssSWUPXx7oRowHPKFvtCH6Vc3LJw0sXMOBT7EhpYpo2eG7gq+Xe690NTrcggCQi0XIZe+Rs0890OQXQNhSPLNwe059FRrXfp9OLknlFBHQ48jiMTtmb/j+yJKzYNs8XmRYSYRT2XqjG6LiIdVGpfLBC6IpkeYxXYTc8z5swwLKh89mGb8u7ESHQbLrqfvRWlmapyHmkyQaHXaGb0nNWgvEmJxxgKQxLuCi+OJu4cUvzIsPWdD8S2qMZfIZZhCBKkW90SqNXR647N/AClmJ8hLfxIEvUDfOZsL4rpGS+BI/QOy7p/EXx/NjNBviDDpsP86/6HEJmKW+S+oiO6t372pziSTGMdRh8d/GiieA6gr2wUp/9yP++BWH7IsUepKG/JTir2cK7cV8Gl0+HKOmbxuwsW2ToqZAKQhkU85Gcweove7W/44CS3eujuTOQ+D+KCh3BsUL5zhqa/KFnTME1mVWZf0rXUukRr80WlS1n8Qj81Bjgj1kEcicww1BXl7GrJ6I/qV0jcVFBDikovV5ACFZEXD/rU0dxCX8lhciFf4FApUKYH0kpLmKaR8SbRfmhhImoh/9kqVhkPx873B/Io2LIAG57Wr3l/EacwrQtWGbqNreHkYw94= X-MS-Office365-Filtering-Correlation-Id: 7045c1bb-7dfd-4564-d6ff-08d41514a2a6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR03MB2473; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 3:8fl0GJmwACH425h7lSHIEbhClKLgmaL3ytEDRB53mVyefOvqSSzFTiPyrhLcKICowYq6GbAAC8oZzr78PD+hI5VlX0Wb64bvL4+BXYe4egFCXUMiGVcbBvmFo7ZhToCTfMKEjJRTiKlIZfYAcyKoVrdkwNuVQjuEDT/rOlOAydCeTM4+RIvF8fdjMy0IzIL7OJflXT+NzNn4YvlaGAg6ieCB4ioF0a9BWWmkqJOUyF9ZzGn1Q8WdMih/hqJKpVMjLBA/4O/Ngo0GFSE9H+fTV51bIjo6vHiCMUYbQlqfXpNNkxJ+/m79V26vBHGnRdp+mKGAIYlpu2m6Adx32jcdyyrtPZRPp0qaXWrllt8ai0sBHWddX5YdkOjmeRBwr0xR; 25:CTMuhwQSdeIlFfu+zm9VrJfPeT8ajE9LEFGsYAMO37TFHUzgD9+f3KDMEh9HaPd1bCemEUiQvWiPs2SfNyq9rXjdoxHALLM+aoGZR60rUn4AOoGPpd4huEuNwf0207vhwG6eJ8dhTv2xq3mBJGFSqoIMzqrzX/bvE+ViEfWesPMPhbX7IndEhyo9qXd2vQMEJ08HdVOZRtHpU44PuXEEJ6a8uLolXovs25DJUlNKEpIXWxUmE+2h7Bmh9uSEqU6+VPnIuiJv7Vkj1qPZotTIXAFOjXB+4cIqGpTVQkbxoVOrNBLczz9kq3ygM9FO8I7tX2sArPuajvvQIg0ijZ0Z4wdvVRqbjfgeGj8J3pXANOB2TT7oz1ARaUxUn1FOIXWDJOUIdmoQ39CKBN4LNdvQmu7TMLfw7gludMyZ5c2rx2+G45lDDKgTDYGzjdZcHPF2yLdS8cKxeapFRedNLug7IA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 31:HYiHGQDeO/kdbiaTV2upol4yVJQC4K58iRPa0Ks3svp6g8IuLo31BxaR7Y+P3wLKeCuCp1lvU3Lh6n4jneDwrfdE3t+/OAkQ6WQwlnO00d/w0r8+QzAek5YvBw2eU+GXuK411efyUzrCUIMTu/26Elk9zA5JHWFGLaC7t7WCq24OgyvQtZQ/EsBCljtcF4tVSf3nMSPxkkwQhjO4yDAqeCWCYC5HypqZMs+jTiDZmRdlyH8uyWt/GJ1eAa+KGvUL3SNlHJtowa0dgqsqeBpuVA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123563025)(20161123556025)(20161123559025)(20161123561025)(20161123565025); SRVR:DM5PR03MB2473; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2473; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 4:RxuizLIcDuMhz9Nu5rbZeBgLZEetMrB3Z9jYMxKh8wdEuQZrKlj/zWny3ePxb7NlkIjVFkh8S0QuPpSwtxypfnVY3ynvNzzO/cWxuhHepTEPA6sv/h2lMZiGPn5oSt1xUfourISVGxkPaEPZQE0OAVrg/GiaoEiaYVf/GjChsFOs1skQsjGdqhDdwY/e1eUjm2jSnGcmilueSdFA+Jjo2O2xXCDf6Ztd5eSRrOrCRU1iUJMvV47oCfIX/dAX6UWRs6IW6LAJ5NSPf1D60gI3gaIvJuLASb5RtMksTRnqkva63eb/W4lBvIxDs6CFNSGhzJaQoG+SUj+jreT0LBFj48Nv6y72vAEy0SFccCNaccMvmdYGzUjt3P1uFJ8KRAVAR91XQNMPXWJc9ooxWASGiJ1bVepVSCyBIwgljdJ9hqcl+E2UHZhFKNJL9YKLSfiFn9xzltuHpXwFnwWvQvRbiKOX/hgHIL2dzfHmeM5Y0tL92BCXb0mZbuvU/e9sPPFHoNFHLAeuWXc0wb3AnnGWVpL15rK2npd6zlIvR+5vHm7dyCdJutCMPD5csofsSsR5Z41DJZiHcxf+FHJqdEXgR6PSggU87i4CzlhxLmnH8BGQxgUcjYzBjZmGK1iIQ5wMG1H2aI6rMHydu0KGcC29Ajb2p3K8Ly+xCz/JFdlCivXbamBXoQ7QY65M4VAebyWjAQ8SwVkNPbM31aSmv/PUFisvMJBem4c/E/pT1EVggPMPoCm1KklzzYOCxcTURSKr X-Forefront-PRVS: 01371B902F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2473; 23:gQ11dwRv1XbJxQMs4iz+wvaupgl9SSytXEWeX?= =?Windows-1252?Q?aBo3/7WGxyl5DrkXamLQcAXI1MBkD8STQKlETy+Haumj4OGpk/J2xRau?= =?Windows-1252?Q?rfEd9d/SIGBw4MgM/udlAuQiP4663YIWpazajmSTyyEWGRlmdrTBJREW?= =?Windows-1252?Q?F9nakG6QCUnI6d/6XmZig9IOPTEgnv9ynFiPTT3+wJjcodiySZ7Zbm1P?= =?Windows-1252?Q?ZsM0b7AV7tAI5uNNqjdIPmdC6mswwBeTpg05trSx5zG/tzmgG0qV3oyb?= =?Windows-1252?Q?4PsFmxWaT8Hdy1zGw3cYq+1MkSo87pf95n2V+PyAsj12z1HEQC4uEyNw?= =?Windows-1252?Q?b6FxjezammZJtgtCOY9J49KwE0rRpsQ3Iif8kEo6dg0nRAqC74NXUjE8?= =?Windows-1252?Q?i5HHT4idumjuEoqWwND0m9TABYUnKUqro1YQMCEiKefOZZKFViiifJp+?= =?Windows-1252?Q?806rAI/qESO9ufqwV4w4LXkGJwRAO3LoOfmx4ztktfzAGUZQSybN5Je2?= =?Windows-1252?Q?b9yanT1lG8OkG26fsJYXMkoHuydt6BGgRXB34PTe8bM9g31lzNrFBLSO?= =?Windows-1252?Q?lixahsVK3Y3xMyr+6Sfnja7D5UAYb/ZjB5XiCBm2SHkQ6Sg46pul+2bu?= =?Windows-1252?Q?ptbqzF9iFXRaUeICNs+HZ9KNwOl7s8RlIEEenk1BeH62mtLCUSyV0d7h?= =?Windows-1252?Q?OLvmco38KS6aaWzvuGMWq1MFOy6awjn+cVbl8e+aj1EiaJnlqiH8AVal?= =?Windows-1252?Q?8VfF+Cqab/HAl5sdFv/SWlTJN74N6EEh0kbHMnoUWpcAnkthYi3d0Wu+?= =?Windows-1252?Q?P/zUtHWFExcE0tfANEAOhQCAvbsN2tmyH6LMGsQAa+8+1T/0p+Z1wFeR?= =?Windows-1252?Q?YjLufPCl7NMyCKdMX5f0stYGwtoJiRGb/6brh9Z6hmS6Bposgw6F4+RW?= =?Windows-1252?Q?XKBMB1+b9unXLajlUs+l77py3SeMALD8Tc5pFGIikfpUhx3dXHndKfIr?= =?Windows-1252?Q?56G89pf1mCcIU9tGyiRZmkz1mxBlFA6vo8UpASHoCUDUP9jUBlQEZILn?= =?Windows-1252?Q?Ah3HajPkQ2eH2MM1qyS68ZgLdbIhRk3+9FkXP3a+7l4XRZwDzOWxLJZ+?= =?Windows-1252?Q?kjYT0DfW2puyF56Pdm/7HlhZ76xSoTF9KVsCMdt/O15Vj9rQRwlBenYp?= =?Windows-1252?Q?ezrrY2TR953xBnChwBv5DzLmFBQoRO1ISrlRF/87dkK3cHh+XmjexLhX?= =?Windows-1252?Q?h5uHMlVqmulpFOyw9VGKnViGuaAwq35gOkH5rTKDpT7ee5Pd6XU4RDsS?= =?Windows-1252?Q?MUy4Do8WgcLzPS3uDC2ekF6X1p8y0kX6e5Ia+Rpw+6/EAf87PgjzaOUW?= =?Windows-1252?Q?/fPRivRw51saDf6MuG9L1r25mgRNQrKYMjFyqb8NSiJDhhOWZUHPBpJC?= =?Windows-1252?Q?urrHXpJKv8GO8e7ynMB3kRRYT7EOxjE4ecpmbu5xYJaF5z0aN6IYzLsS?= =?Windows-1252?Q?W65Ook=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 6:BjhjL0QYXVald6sWUxv+tijdtZKvPTnwg3ooGhEiy/uSNeBH+UQCo03mTCTwUnzrf1i7px7yZvCHAt3+lkifgnAuphwTx6twgbdHytcOieFYTQtoZdedFhF3gN9pnWzIfJFMQGWugQ5wv859plnDlO7ctWPB+tmS//cRvFYBmkp1h4f8h1JvgvlBaZBDxpB9Gba5m9OzN0IdAeG8ph1YSeYmBtKOFQZ+JDvbK0LDXXMIJ4XYzUXi/pgcQuddSfMOkPBG7Be/3HqJVwNxeFcSqbOnqWQSbQHZqRAIrA1uaAgGYTSdUlKP0Qc37nvsDWpGMyZwUVSuj/Qu7/of4msDlPUCnCB3yegNe9JAOLf7O2J9Zyv666uSC/6FUkJNh2ZKmGofJVMArsBAHPvBBDTaEYgKt6zRMmMFIBq+TpPiiD/oplNosn4rdQ5ZY4awpiHZ; 5:pLSq6LmEELVta1MmcabC00zCGYE2PUhy7C6Pn4bPFH8OUqQzlXxhF8q9+2yjN7P1f6mTpTRy3N1hZJWcVh6Oi8Ek/xjdTEI5egrcI5oh8dC0oB7GXO7L++e+HqGwHlsjW2aZ4UCtC6+PkXjWfR+KdTRkWNEku6BP5X1MNzvFisuxddkFRvb7o1V7xeUuxZDS; 24:uC0z3uboH8xtiV9BPYhlIvVNSKroaJCYJaboF9UYaspbl/ZSjPVcuUeXp5WsCDmGxn2PVWHI+bhWiuypcTRPbUEcrErJ7tKXhVfY15dkJY0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 7:G/suFGiDIzSYHxk0UYZY7jRV4vNQF/JSja9+zlEqsN00lX67tj9tI/ZitMBPXjn62GgukFfVFcMaRBleFWClNNViFFdKRkEbElkcY3q/iCixkJ2494oBWLHATqo3az0kpGGcWBk20Oo8Eyoz3fU1PyWcKB7nrmGFO6cF8vA5uAmzma6ZL89qlLszZzTirsQZSRi62gVGc7DXRmBbox5CjiHYi90eqzVaDYnnZw5CjeX90KXDqaKmujnWKpIO7FqwWY5vV3JGZj7MPa/Xy5yLgQKCSamJwRbfVBqYjsypw5POOzMQ04NnWuS7Tnoq3b2Yp56kROrVnaKMni6e6nDHhArTFcLMEocc7jfo4aHiqt1ILl34BGUzE+1BIuMUb/MvlVXKaNHoJbHQ5p6XnOetquh4AJZJ1YBSuTJTJ+U7cKQ9mnRJZI9JnPP606wWUZaV84oenL28+aY0AF9E0miwZA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2016 09:22:53.6114 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2473 Subject: Re: [dpdk-dev] [PATCH v2 2/7] pci: Separate detaching ethernet ports from PCI devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 09:22:56 -0000 On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Attaching and detaching ethernet ports from an application > is not the same thing as physically removing a PCI device, > so clarify the flags indicating support. All PCI devices > are assumed to be physically removable, so no flag is > necessary in the PCI layer. > > Signed-off-by: Ben Walker > --- > doc/guides/prog_guide/port_hotplug_framework.rst | 2 +- > drivers/net/bnxt/bnxt_ethdev.c | 3 ++- > drivers/net/e1000/em_ethdev.c | 4 ++-- > drivers/net/e1000/igb_ethdev.c | 7 ++++--- > drivers/net/fm10k/fm10k_ethdev.c | 4 ++-- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- > drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++++--- > drivers/net/nfp/nfp_net.c | 4 ++-- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++- > drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +- > lib/librte_eal/common/include/rte_pci.h | 2 -- > lib/librte_ether/rte_ethdev.c | 2 -- > 14 files changed, 26 insertions(+), 24 deletions(-) > > diff --git a/doc/guides/prog_guide/port_hotplug_framework.rst b/doc/guides/prog_guide/port_hotplug_framework.rst > index 6e4436e..d68d08e 100644 > --- a/doc/guides/prog_guide/port_hotplug_framework.rst > +++ b/doc/guides/prog_guide/port_hotplug_framework.rst > @@ -106,5 +106,5 @@ Limitations > > * Not all PMDs support detaching feature. > To know whether a PMD can support detaching, search for the > - "RTE_PCI_DRV_DETACHABLE" flag in PMD implementation. If the flag is > + "RTE_ETH_DEV_DETAHABLE" flag in rte_eth_dev::data::dev_flags. If the flag is Incorrect spelling. Should be 'RTE_ETH_DEV_DETACHABLE'. > defined in the PMD, detaching is supported. > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 035fe07..a2100f6 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1051,6 +1051,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev) > RTE_LOG(INFO, PMD, "%s", bnxt_version); > > rte_eth_copy_pci_info(eth_dev, eth_dev->pci_dev); > + eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE; > bp = eth_dev->data->dev_private; > > if (bnxt_vf_pciid(eth_dev->pci_dev->id.device_id)) [...] - Shreyansh