From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: dev@dpdk.org
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: [dpdk-dev] [PATCH 1/2] acl: remove invalid test
Date: Wed, 18 Jan 2017 20:32:51 +0100 (CET) [thread overview]
Message-ID: <f99e97474e9c9a72b301c5d45781a7fc6fe04272.1484767464.git.mirq-linux@rere.qmqm.pl> (raw)
In-Reply-To: <cover.1484767464.git.mirq-linux@rere.qmqm.pl>
rte_acl_add_rules() has no way of checking rule size.
This was hidden because the test effectively checked that
adding a rule with userdata == 0 failed.
From: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
Signed-off-by: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
---
app/test/test_acl.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/app/test/test_acl.c b/app/test/test_acl.c
index 28955f08a..be744ec23 100644
--- a/app/test/test_acl.c
+++ b/app/test/test_acl.c
@@ -1515,26 +1515,6 @@ test_invalid_parameters(void)
/* free ACL context */
rte_acl_free(acx);
- /* set wrong rule_size so that adding any rules would fail */
- param.rule_size = RTE_ACL_IPV4VLAN_RULE_SZ + 4;
- acx = rte_acl_create(¶m);
- if (acx == NULL) {
- printf("Line %i: ACL context creation failed!\n", __LINE__);
- return -1;
- }
-
- /* try adding a rule with size different from context rule_size */
- result = rte_acl_ipv4vlan_add_rules(acx, &rule, 1);
- if (result == 0) {
- printf("Line %i: Adding an invalid sized rule "
- "should have failed!\n", __LINE__);
- rte_acl_free(acx);
- return -1;
- }
-
- /* free ACL context */
- rte_acl_free(acx);
-
/**
* rte_acl_ipv4vlan_build
--
2.11.0
next prev parent reply other threads:[~2017-01-18 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 19:32 [dpdk-dev] [PATCH 0/2] Enable zero verdicts in ACLs Michał Mirosław
2017-01-18 19:32 ` [dpdk-dev] [PATCH 2/2] acl: allow zero verdict Michał Mirosław
2017-01-18 19:32 ` Michał Mirosław [this message]
2017-01-19 11:57 ` [dpdk-dev] [PATCH 0/2] Enable zero verdicts in ACLs Ananyev, Konstantin
2017-01-30 10:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99e97474e9c9a72b301c5d45781a7fc6fe04272.1484767464.git.mirq-linux@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).