From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org,
Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name
Date: Thu, 7 Oct 2021 13:20:52 +0300 [thread overview]
Message-ID: <f9adb934-9ddd-f64c-c94a-fe3a17e47b4c@oktetlabs.ru> (raw)
In-Reply-To: <14586794.58kHr3nmNG@thomas>
On 10/6/21 12:56 AM, Thomas Monjalon wrote:
> 13/09/2021 13:26, Andrew Rybchenko:
>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>
>> Getting a list of representors from a representor does not make sense.
>> Instead, a parent device should be used.
>
> I don't understand which issue it is fixing.
> This function was not working before if not using the backer port?
The function, rte_eth_representor_id_get(), is used in
eth_representor_cmp() which is required in ethdev class
iterator to search ethdev port ID by name (representor case).
Before the patch the function is called on the representor
itself it tries to get representors info to match.
It was found by OvS+DPDK testing:
1. OvS hotplugs representor
2. OvS tries to find DPDK port ID for just hotplugged
representor and fails (if PMD does not provider
representors info on the representor itself)
> Is it fixing a specific PMD?
It is a generic fix for PMD which do *not* provide representors
info on the representor itself.
next prev parent reply other threads:[~2021-10-07 10:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 16:17 [dpdk-dev] [PATCH] " Andrew Rybchenko
2021-07-19 6:58 ` Xueming(Steven) Li
2021-07-19 8:46 ` Andrew Rybchenko
2021-07-19 11:54 ` Xueming(Steven) Li
2021-07-19 12:36 ` Andrew Rybchenko
2021-07-19 12:50 ` Xueming(Steven) Li
2021-07-20 8:59 ` Andrew Rybchenko
2021-07-29 4:13 ` Xueming(Steven) Li
2021-08-01 8:40 ` Andrew Rybchenko
2021-08-01 14:25 ` Xueming(Steven) Li
2021-07-29 4:20 ` Xueming(Steven) Li
2021-08-01 8:50 ` Andrew Rybchenko
2021-08-01 14:15 ` Xueming(Steven) Li
2021-08-18 14:00 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-08-27 9:18 ` Xueming(Steven) Li
2021-08-27 9:48 ` Viacheslav Galaktionov
2021-08-28 13:22 ` Xueming(Steven) Li
2021-08-29 8:23 ` Andrew Rybchenko
2021-08-29 12:17 ` Xueming(Steven) Li
2021-08-31 15:42 ` Andrew Rybchenko
2021-08-20 12:18 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2021-08-31 15:41 ` Andrew Rybchenko
2021-08-31 16:06 ` [dpdk-dev] [PATCH v4] " Andrew Rybchenko
2021-08-31 16:32 ` Wang, Haiyue
2021-08-31 16:37 ` Andrew Rybchenko
2021-09-01 5:15 ` Xing, Beilei
2021-09-01 14:55 ` Ferruh Yigit
2021-09-06 16:16 ` Viacheslav Galaktionov
2021-09-13 11:26 ` [dpdk-dev] [PATCH v5] " Andrew Rybchenko
2021-09-29 11:13 ` Singh, Aman Deep
2021-09-30 12:03 ` Andrew Rybchenko
2021-09-30 12:51 ` Singh, Aman Deep
2021-09-30 13:40 ` Andrew Rybchenko
2021-10-01 11:39 ` Andrew Rybchenko
2021-10-08 8:39 ` Xueming(Steven) Li
2021-10-05 21:56 ` Thomas Monjalon
2021-10-07 10:20 ` Andrew Rybchenko [this message]
2021-10-07 12:39 ` Thomas Monjalon
2021-10-08 9:27 ` [dpdk-dev] [PATCH v6] " Andrew Rybchenko
2021-10-11 7:56 ` Slava Ovsiienko
2021-10-11 12:30 ` [dpdk-dev] [PATCH v7] " Andrew Rybchenko
2021-10-11 12:53 ` [dpdk-dev] [PATCH v8] " Andrew Rybchenko
2021-10-12 15:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9adb934-9ddd-f64c-c94a-fe3a17e47b4c@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
--cc=matan@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=viacheslav.galaktionov@oktetlabs.ru \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).