From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3A23C4CE4 for ; Mon, 3 Sep 2018 18:57:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2018 09:57:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,325,1531810800"; d="scan'208";a="260361841" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by fmsmga006.fm.intel.com with ESMTP; 03 Sep 2018 09:56:55 -0700 To: Andrew Rybchenko , Gaetan Rivet Cc: dev@dpdk.org, Ian Dolzhansky References: <1535526966-32456-1-git-send-email-arybchenko@solarflare.com> <1535526966-32456-2-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 3 Sep 2018 17:56:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535526966-32456-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 16:57:35 -0000 On 8/29/2018 8:16 AM, Andrew Rybchenko wrote: > From: Ian Dolzhansky > > Signed-off-by: Ian Dolzhansky > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd/cmdline.c | 91 ++++++++++++++++++++++++++ > doc/guides/rel_notes/release_18_11.rst | 6 ++ > 2 files changed, 97 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 589121d69..f47ec99f1 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -883,6 +883,10 @@ static void cmd_help_long_parsed(void *parsed_result, > " Start/stop a rx/tx queue of port X. Only take effect" > " when port X is started\n\n" > > + "port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\n" > + " Switch on/off a deferred start of port X rx/tx queue. Only" > + " take effect when port X is stopped.\n\n" Overall looks good to me. But testpmd doc needs to be updated to add new command. doc/guides/testpmd_app_ug/testpmd_funcs.rst Also is there a way to see the current deferred_start status of a port, either with a specific command or as part of other command like "show port info"? If not does it make sense to have a way to see it?