From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0F81943075;
	Tue, 15 Aug 2023 20:35:27 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DCAE34114B;
	Tue, 15 Aug 2023 20:35:26 +0200 (CEST)
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mails.dpdk.org (Postfix) with ESMTP id 467A9410ED
 for <dev@dpdk.org>; Tue, 15 Aug 2023 20:35:26 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AB19E60D2E;
 Tue, 15 Aug 2023 18:35:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CE36C433C7;
 Tue, 15 Aug 2023 18:35:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1692124525;
 bh=XdHsgLIeeJ5Xt5sZqStjHss71tI+QIda2md9x/Y5Og4=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
 b=gUXpVbLcZrxZcCr4pmNSBuD5BxVDvJJgoeQP9KV91NhDAov4nlu9plZ/Raqf09WcM
 TEom/aLmNDX2cmtzWk+3IAVvlPVD+wcv3/y2Gg/UkAH6cMvuhvKInEFc8fRFQVfXw6
 E6jRzc5ZVRnGEWS/ClZph1c92jejRwvf+odC3urlWZA91BTpZrLHATxgiWQ0s/hhRe
 gjDMaECH+HBUCVaiYVyP3dx/ytw7Tg4LOiphRrTDJQ/NPN2RBuaHjEMPrwXd37hIoL
 lL4vtvlSE41Mx39tIpJpgQjJvrUEwLbAoxw1OI5JTJeARZo5V5yBjY0Wolrew0FJYH
 ZGhsTWBs/S1ZQ==
Message-ID: <f9d4e3db24aa5b192b0e85d24ace3e63c7f75a78.camel@kernel.org>
Subject: Re: [PATCH v4 2/8] eal: fixes for re-initialization issues
From: Sinan Kaya <okaya@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Graham Whyte <grwhyte@microsoft.com>
Date: Tue, 15 Aug 2023 14:35:23 -0400
In-Reply-To: <20230815104906.4e55df8b@hermes.local>
References: <20230815145023.1386003-1-okaya@kernel.org>
 <20230815145023.1386003-3-okaya@kernel.org>
 <20230815104906.4e55df8b@hermes.local>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, 2023-08-15 at 10:49 -0700, Stephen Hemminger wrote:
> >   
> > +     __atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);
> >        return 0;
> 
> 
> Interesting, other flags don't use atomic. Why here?
> 
> 
> 
> And is already set elsewhere?

Looking at the history, this variable used to be an atomic
variable. Later, it got replaced with a uint32_t and write
is done with __atomic_store_n instead. I followed other
examples in the same source code file.