From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57E53A0093; Thu, 5 May 2022 16:31:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 154004014F; Thu, 5 May 2022 16:31:35 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by mails.dpdk.org (Postfix) with ESMTP id 2B1B540042 for ; Thu, 5 May 2022 16:31:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651761092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5PO8GE0kr1ZRFlbOFdyYAPHPAqq88jQnXtrCewSkcU=; b=iNQ3uWQde2kX31XizmhTLxXTyXhYKKUn0/qj78AG3pAAqh/pb3DKP/FIsXsksj9+QaQ/X6 hLiFeWSfWMYHt9GUqh6a0veChY/1motne0s6rmogbwKpsvwgozJCiS6tbTznMcF6GF5wYu Lpt+J53uAvS9mIkonackOGt2z/jg2Cs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-148-h5ZOHUqcN_u2EDcPoaFesQ-1; Thu, 05 May 2022 10:31:30 -0400 X-MC-Unique: h5ZOHUqcN_u2EDcPoaFesQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 761933C1022C; Thu, 5 May 2022 14:31:11 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCF7C416157; Thu, 5 May 2022 14:31:10 +0000 (UTC) Message-ID: Date: Thu, 5 May 2022 16:31:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: David Marchand , dev@dpdk.org Cc: chenbo.xia@intel.com References: <20220425125431.26464-1-david.marchand@redhat.com> <20220425125431.26464-2-david.marchand@redhat.com> From: Maxime Coquelin Subject: Re: [PATCH 2/2] vhost: validate fds attached to messages In-Reply-To: <20220425125431.26464-2-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/25/22 14:54, David Marchand wrote: > Some message handlers do not expect any file descriptor attached as > ancillary data. > Provide a common way to enforce this by adding a accepts_fd boolean in > the message handler structure. When a message handler sets accepts_fd to > true, it is responsible for calling validate_msg_fds with a right > expected file descriptor count. > This will avoid leaking some file descriptor by mistake when adding > support for new vhost user message types. > > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 145 ++++++++++++----------------------------- > 1 file changed, 43 insertions(+), 102 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime