From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E32F1A04DC; Mon, 26 Oct 2020 14:35:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4FC72BAA; Mon, 26 Oct 2020 14:35:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id AF5A32B9D for ; Mon, 26 Oct 2020 14:35:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603719308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HzRCHlmYhWtaMdcbO+5HN11a2rg/AyAdKK0OaMX0p5M=; b=ZG13ZHloAgshsR+9kRwUvv1/N/Yaf+fNeAsrDmdPIxU5bZuwTeVr9cdg3qf7ox17F4jn2w dVs3RboBsL8IjWAtH0KyMDrJFYkd1xSPA0ygu305MOI3C6X9rspCAXYG940RHBAMghGLo1 e3hNRaa3OeKyArn/xHueO30UZOynevI= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-KoTKALtOMEmMtpLwRzYnVw-1; Mon, 26 Oct 2020 09:35:06 -0400 X-MC-Unique: KoTKALtOMEmMtpLwRzYnVw-1 Received: by mail-ot1-f71.google.com with SMTP id m24so3556104otk.23 for ; Mon, 26 Oct 2020 06:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=HzRCHlmYhWtaMdcbO+5HN11a2rg/AyAdKK0OaMX0p5M=; b=gvKd0HN2ZLBKZsbyD2nZS1D8S/7E6SahR5JVB3XAnWtMR1ClBaPc2I+DYzC3yTBfpz EazmgEunlM39PGQO/88ipiv8tPxaUzQ1fFhBRlYuHC63QKCzkdE59cM9Moqc/j8AOY6a c8+FN4+iCL2loOntO0cTtBjaXW162YgG2cu8N2sWrNA+9Ms9QbPVkT/wQE5l9e/pW/aT VzlewA8wFpjzz1os7zJVcxo5brb6j5rXIImG3sAYZoWW+4At1Gq7emFYH0GVfyG4jGfb kXHRcBz+yhl2Jmfv7Eh9utOyw0ZjFE34mvjdAyOlX/uMYB5gXghZVA6iDV7QpHXZNM7B I7ng== X-Gm-Message-State: AOAM532MOkFcRsk81dCWZzWxWxi7U0w1G+ZVTlmmULy8vDraC8fG8SZt lPCwwjgRJ+Sg8VHlIm+l4PX6QkteWEj1bCbRO9kJy2LhdbVp3OOZCdza+XzgxvMBz59DyZuS9w5 CEL8= X-Received: by 2002:a9d:694c:: with SMTP id p12mr13630816oto.290.1603719305855; Mon, 26 Oct 2020 06:35:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1ORbaIUoOulWNKYR8ZoFMoDl/xEvd6pCKxmRnDUWTSei0UFnCGVxWdmlZD9CaQKGHIQQHag== X-Received: by 2002:a9d:694c:: with SMTP id p12mr13630804oto.290.1603719305608; Mon, 26 Oct 2020 06:35:05 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id c128sm1961543oob.23.2020.10.26.06.35.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 06:35:05 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, akhil.goyal@nxp.com Cc: david.marchand@redhat.com References: <1603496581-35966-1-git-send-email-nicolas.chautru@intel.com> <1603496581-35966-6-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: Date: Mon, 26 Oct 2020 06:35:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1603496581-35966-6-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 5/7] app/bbdev: skip bler ut when compression is used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/23/20 4:42 PM, Nicolas Chautru wrote: > bler test results are not valid when LLR compression > is used or for loopback scenarios. Skipping these. > > Signed-off-by: Nicolas Chautru > Acked-by: Aidan Goddard > Acked-by: Dave Burley > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 39f06db..a15ea69 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -3719,7 +3719,11 @@ typedef int (test_case_function)(struct active_device *ad, > RTE_ALIGN(sizeof(struct thread_params) * num_lcores, > RTE_CACHE_LINE_SIZE)); > > - if (test_vector.op_type == RTE_BBDEV_OP_LDPC_DEC) > + if ((test_vector.op_type == RTE_BBDEV_OP_LDPC_DEC) && > + !check_bit(test_vector.ldpc_dec.op_flags, > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK) > + && !check_bit(test_vector.ldpc_dec.op_flags, > + RTE_BBDEV_LDPC_LLR_COMPRESSION)) > bler_function = bler_pmd_lcore_ldpc_dec; > else > return TEST_SKIPPED; Looks ok. Reviewed-by: Tom Rix