From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7D20A0527; Mon, 9 Nov 2020 10:32:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDEFD592C; Mon, 9 Nov 2020 10:32:47 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id 581435916 for ; Mon, 9 Nov 2020 10:32:46 +0100 (CET) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CV5Pc3z8Qz15THd for ; Mon, 9 Nov 2020 17:32:36 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Mon, 9 Nov 2020 17:32:34 +0800 To: Ferruh Yigit CC: , References: <1604586194-29523-1-git-send-email-oulijun@huawei.com> <1604634716-43484-1-git-send-email-oulijun@huawei.com> <1604634716-43484-4-git-send-email-oulijun@huawei.com> <3cdc7009-177b-0323-4577-37c7fb2aa04f@intel.com> From: oulijun Message-ID: Date: Mon, 9 Nov 2020 17:32:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <3cdc7009-177b-0323-4577-37c7fb2aa04f@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/11/7 0:44, Ferruh Yigit 写道: > On 11/6/2020 3:51 AM, Lijun Ou wrote: >> From: Hongbo Zheng >> >> Here adjusts some code style for making the lines more >> compact and removes some static check tool warnings. >> >> Signed-off-by: Hongbo Zheng >> Signed-off-by: Lijun Ou >> --- >> V1->V2: >> - fix checkpatch warning >> --- >> drivers/net/hns3/hns3_cmd.c | 1 - >> drivers/net/hns3/hns3_ethdev.c | 6 +- >> drivers/net/hns3/hns3_ethdev.h | 1 - >> drivers/net/hns3/hns3_flow.c | 37 +- >> drivers/net/hns3/hns3_intr.c | 873 >> +++++++++++++++++++++++++++-------------- >> drivers/net/hns3/hns3_rxtx.c | 1 - >> drivers/net/hns3/hns3_stats.c | 1 - >> 7 files changed, 597 insertions(+), 323 deletions(-) > > This is a big(ish) patch with just whitespace changes, looks like > related to the personal preferences. > This will create noise in the git history, and unnecessary conflict in > backporting patches. > > I know it is tempting to fix here or there :), but lets fix those when > updating those lines for a functional change, and drop this patch. > . Requirements for some static check tools: When struct and union members are initialized, each member is initialized on a separate line. We think this requirement can be a better code style. We can split the just whitespace changes with the above requirements? because the Redundant blank lines alarms. >