From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 314D4A00C4;
	Thu, 28 Jul 2022 13:32:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CDCC040151;
	Thu, 28 Jul 2022 13:32:48 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E5F4E4014F
 for <dev@dpdk.org>; Thu, 28 Jul 2022 13:32:47 +0200 (CEST)
Received: from [192.168.1.38] (unknown [188.170.75.116])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2851AC6;
 Thu, 28 Jul 2022 14:32:47 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2851AC6
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1659007967;
 bh=tb39YfUdt32X0GBpS3OaaWjoVKcyMKGzpRf0V2izIi0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=Tc8TYI8pie2lBVjsy277Ut2chvQHlRymIUWH3fnAnfyL8J3vXXBOuWtNLn4jRbrmf
 we7qTqwGmFAx3519bhZWT/3LMocnXU4xr92sQfH7i1FBPFoZxQUXMvjhTQlU7pt51e
 VJDfaTmfF+7WzaMZNC/IlePo5klXJWg4Z3G3TlGE=
Message-ID: <fa77362f-2b7e-329b-7956-45083ae34137@oktetlabs.ru>
Date: Thu, 28 Jul 2022 14:32:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 2/5] common/sfc_efx/base: update MCDI headers
Content-Language: en-US
To: abhimanyu.saini@xilinx.com, dev@dpdk.org
Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com,
 Abhimanyu Saini <absaini@amd.com>
References: <20220714084451.38375-1-asaini@xilinx.com>
 <20220714134804.60495-1-asaini@xilinx.com>
 <20220714134804.60495-3-asaini@xilinx.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20220714134804.60495-3-asaini@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 7/14/22 16:48, abhimanyu.saini@xilinx.com wrote:
> From: Abhimanyu Saini <absaini@amd.com>
> 
> Regenerate MCDI headers from smartnic_registry:72940ad

since smartnic_registry is not publicly available, it does not make
sense to refer to its changeset in the patch description.
I think you should put update goal here. Which MCDI fields do you
want to pick up?

> 
> Signed-off-by: Abhimanyu Saini <absaini@amd.com>

Other than that
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>