From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0DF64A0C45;
Wed, 22 Sep 2021 11:27:14 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 91915411A8;
Wed, 22 Sep 2021 11:27:13 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by mails.dpdk.org (Postfix) with ESMTP id D2ADF41196
for <dev@dpdk.org>; Wed, 22 Sep 2021 11:27:11 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="203710610"
X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="203710610"
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Sep 2021 02:27:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="702143337"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by fmsmga006.fm.intel.com with ESMTP; 22 Sep 2021 02:27:04 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 22 Sep 2021 02:26:47 -0700
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 22 Sep 2021 02:26:46 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 02:26:46 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Wed, 22 Sep 2021 02:26:43 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=lO5V0a5c2P1QxEuLlXyASlkRSt2accvTl9+jgGD6xtROjlc45/evFVU0a1Ht3n5kMrrPAvRvC2+iHuZBlLv9yjJdn2t52b17JwFVf/FlLkyJB4QImVbnPI/+1E+IVRYILcu11uetK/bRwHM0pB6yQsYc4ZQ4nzpmsIvuXpOXzhRuGAsVlF45w5k3taGCL0+2msVzKINJ+GiMA/NvMCcxoALLhyYQhCmuA6oB2mktAc4HgYcS1B0Mj7RfOmv0HHbFmtwxEHe3OUGOhXDudWKJ7wY57ZAwP6SQNvAvlNHv4xw4n7AfyRD4JIWcZPfEg9LWQ+pRoYYkI62zbs/MtxP2hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=4tFmxbGXUXW/YBLj8fEYe2G5lWIQUg9d12P6HeXxYBk=;
b=cekOCjFRXh7bhju/KjXFJWg5qIbQu5/+WIEzW5SyIrrJuxt6Qm7IGfC6gVODYxfFt2Lyg2xnhIDdYNKlwL1NswWtVz3AhA2OCe2vJe3sFyJ8prXJE9eYdwYZPQu0zu5tG7iYYVJWqx1V8rrpkemUegj4ZmUswwlEHOElzfh9drbFPPcKpHjch/Mil0ksPls4ARMrK6ltqMgO8aenuBwaSq1GUsBZpe0blCAvjytuxei/M6m9s4Ccsk++dELqEQT/f9b4lhUcBTbXDeeLT/zH5Bj3PLqsio3q4o1QyyKWJ9xRHQeA4u3W9XGWB7ELHv6GeDwzCYULisBIwZmRbMiUQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=4tFmxbGXUXW/YBLj8fEYe2G5lWIQUg9d12P6HeXxYBk=;
b=YzlN2C+0ad4xgk3ZcWNRj/naxp1Bh/AeGnnRpgwnilYtgaQ1BqE77QipIdrD6FFeWqXUbHdSl6gJkeioGWX8MUvelPCHdPdLBbSojBVomyTycl+99JyA0egpf1ibVSw0dBOSYV9rGCY3T25Rqc8MtNBdgWX3HPLK7EKRfetE5f4=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by PH0PR11MB5016.namprd11.prod.outlook.com (2603:10b6:510:32::23)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Wed, 22 Sep
2021 09:26:42 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.014; Wed, 22 Sep 2021
09:26:42 +0000
To: "Xia, Chenbo" <chenbo.xia@intel.com>, "Burakov, Anatoly"
<anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>
<MN2PR11MB40634F02503B5A4FA742EAC59CA29@MN2PR11MB4063.namprd11.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <fa84b4ae-021d-b50a-0343-8acd8abab440@intel.com>
Date: Wed, 22 Sep 2021 10:26:36 +0100
In-Reply-To: <MN2PR11MB40634F02503B5A4FA742EAC59CA29@MN2PR11MB4063.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: DB9PR05CA0024.eurprd05.prod.outlook.com
(2603:10a6:10:1da::29) To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
DB9PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:10:1da::29) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4523.14 via Frontend Transport; Wed, 22 Sep 2021 09:26:41 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c7f567e9-932d-4876-1651-08d97dab16a8
X-MS-TrafficTypeDiagnostic: PH0PR11MB5016:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR11MB5016807F395E83FBC8DA5F3C95A29@PH0PR11MB5016.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Kw8Ixcx120vdG1WU9sbLoPvpvGTgxT91Ayuaukuxv+R9FCTub03r4hH/nDpt7Z+Jf62Uod94LdVu5hcMobHy6/Td4QckFDbovBAcRfhJYCpvvInavz0mRc2JjCANyswyJTxLxndl1474mxxKWTsT5oWi0vaZ1ov8kUb88kq480OHceJ5mt5PqU0uMh1zgSV1z4Z8TIhl55CCqSt/5adh2TezshY3ecbm908LrWGMS5ATs9FrZKQSeTDKwpL/vFzNg9q7R6A9EFOHssQ243ngHefjv7yob0Qe7Hkn1FOAteEH7LXKQySGhDQHqDm4Q9cxgLxNo6tevUpxsY1wJvXfAVHye0/7GCLWpKWwNDTSwIIS3JZRBplXhODgoa+MKjHJCQSVfcf3mYegLYv0b3lNGSRtz19X/AvCDCUSbjJd4gQQ0krRg0wWa4PpuVd0KoonDnzB3be7id7FvZ90riFnfkvZo+kh1y01ZJA3uegW//ncEfFtpl05lZPpCGnOwRDDPFvbsd49wAH08DgFepAc9pptJYIh9GdsOG/+z1Zf5fx+id1IhfJQgGn9LIjqTX7AihGQKgTcwSVYbz2G4TInz7PZxP4lKB54mhBCDlNrfs7OInJN+AkUyiQPP5Qpr4ew3c3Zg1KRFpvek85gN/UmLqIlK7ZspBJqa32cqEm7krjpdiyrM8a9xQH8IpsCikOYbZ/uieqNKC4NDMsGdd+6ObCXtmlJ2zLESme0h2vLSkCqhPJQCRp2/49AThDfTw35uHDeM2tMKVPyVJ4EpDbHDTS5Zgb9veM1iHa1XE9jTsE=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(110136005)(44832011)(508600001)(86362001)(2906002)(16576012)(31696002)(316002)(36756003)(5660300002)(6666004)(83380400001)(53546011)(8936002)(38100700002)(31686004)(26005)(8676002)(966005)(956004)(66946007)(186003)(66476007)(66556008)(6486002)(2616005)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjE5Q1VyOWM2T3NiZm0vR1pld3F3ejd2SXVGc3E2WmdzTHBYZTVLeVhWZnF3?=
=?utf-8?B?OERlSDVGVDhRSExESGJmOXhYamExaVlFaEg1UXVUQVpKWHpPdHBhencrRUZU?=
=?utf-8?B?akNCMVU2ZE1JV3g0REN4VzJ2b25wT1FDWStuRmlDT3IvMml3Vm9aa1ZqV3RS?=
=?utf-8?B?RE1Ob1BxRU9vazA4SHBCb1RVdllkMFcvSGxGU1BoRmJVcVFhZG1rbU1zeFlH?=
=?utf-8?B?VUtVRE1CV0kyNnIyU1paMXNkQlZld2l1NVJGNEtVV25HNzRqUE5sSUExdU5B?=
=?utf-8?B?QklzOWxveVhsRWRFRVpQQlRuMXNxRXI2L0NBa2l0V2FkVlBnNktYN3BNLzVX?=
=?utf-8?B?bWQ4OVM1WkxFeHpRMkVkYnRkK1RKTzF4M3c4Vld0SlpQRncwalJQMDY1NmtC?=
=?utf-8?B?d3l6WmJiOUVrV3Y0WnpOTjZUR1RRZnRyeUpUdHkzZldJbWI2WHM4OGV3M3Y4?=
=?utf-8?B?emcyODNkQ0hESVZoQXlqL1RyaEgrbXRFTzdVaUdFeFV5S0Zhb2V3UXVmZWxM?=
=?utf-8?B?ZFJXTy92bnYyY2FxeW1iL3lkQWg1TThWQktFRWVXbnNFZmxBYW0yYzB0bU9h?=
=?utf-8?B?WkZHZUg5bThHVjlFNStBcTROc3RNSlpmSnZKVmtkUkNPbk5Pcm1OSzhOWDlx?=
=?utf-8?B?bW1jckY4bE5OK1VwVGpaZTB4NVJJSE5rQVQ5U3pRVi81OFhkemFpVzM5NThi?=
=?utf-8?B?enlFdWlNRXNJQlVodmxmdFUxMWovSUZDYU5yNHJBMXNsZUlFazZnOEhldGpm?=
=?utf-8?B?SjlmOGsvR28wV2pEd0hDUit1OTZjM0NrRjV2eGtMay81eFViWkhqb2VNODhn?=
=?utf-8?B?YmdlNFhlaUdNVmhlZ0lDbERsSHY3bWxxMVNHcC9vcVN6elY3VW5VSm5vWUR4?=
=?utf-8?B?K1c1RUI5QWNOV2hHTi94cUNaMkEyRVlzUjkrS3ZzWnluQlpTQjhkMW8za0k2?=
=?utf-8?B?aitwV05Lc0xvelVBNmQzOTlEeVpSeXNmZG9uSHZRNHpBZitpRVlpQnBVbW1N?=
=?utf-8?B?ZlBiMkV3ZG5JeFh0Y3ZzZWNJUlh4ckIrbU1sYzU5R3BOY04weHI3MVRrelpI?=
=?utf-8?B?ZmRyMHJSQkpSOUNZRFh1bm9ydWJKM3prZjNZaEZ3ZWNRbVNETUJNdmxlNm1o?=
=?utf-8?B?Snc4b2FZenNXeGg5V3hBMHFLWkNRR0R3SjJoeU5MV3BxYmtyNHNvYmFsaEwr?=
=?utf-8?B?eUdWRkppL1ZOYldPeG1aYUlDdGxENlpEZExlcXVBVlF2M0lCYmFrLzBRNFlH?=
=?utf-8?B?NUFCMjBHYUFaUDBLbkxDVUxiY3BSU3hJUnJ4T1k4K2xyWXEwUGxNMUhiemFq?=
=?utf-8?B?d2VoMVFvRVoya3BKVGwva2UzYk1Ma3BhTFd4dzJYUHhPQU9WVEFJeFlZamQ4?=
=?utf-8?B?elliR1oxRitaU1Y1cG0rS0IrLzZ5M1liMmhmNDJud25oMXk2SFBNRmw3K3Fa?=
=?utf-8?B?YnNWZnVoUkQ3eXY4b2I3bHZpT2g5a2R1UUk3M2VTWHNLTnJ5WEZaS2NtQWNh?=
=?utf-8?B?cHZYZjFEa2xxelp2Ui9zNFh5a1YrRzhwSHExU3plTktYaWJmL2FyTzVoaUJp?=
=?utf-8?B?MDBlVUJKd1lzUjc3SGVhZ2hUSU5WdWZMQXBxcnFnTHVrSXhjaENrVVFndWkr?=
=?utf-8?B?WXdPZlFvc3JHKzdiNW1HbUFnOHFTZ1JMaTJLMmlXM0xKQVE1K1pTamNFcG9X?=
=?utf-8?B?L0EySzJGTzFhMnR1ZVN1Q2Y0ZUNEbTFRU3IvQUd3dFhSWFMvb2VBdEMzbG5t?=
=?utf-8?Q?PeYynYlhnYq3rRugS1oOosAHkFLzo+8E2HWZ5BY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7f567e9-932d-4876-1651-08d97dab16a8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 09:26:42.4412 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 39UUpVJ0jy76ljUyRbwtL8wKfSRsPeZmiH/WLh7J90Zf4CrXp+9wRKiwdcKatrEYAx5N80+V6gkRWQ6IdX5OIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5016
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values
consistent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/22/2021 4:30 AM, Xia, Chenbo wrote:
> Hi Anatoly,
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
>> Sent: Thursday, September 16, 2021 6:37 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
>>
>> Currently, when VFIO support is not compiled, FreeBSD and Linux have
>> different return values. Fix Linux implementation to follow FreeBSD one.
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>>
>> Notes:
>> Current minimum support Linux kernel is 4.4, and Meson build file sets the
>
> Do you mean currently DPDK support linux >= 4.4? I am not aware of this, could you
> show me where it is defined?
>
https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst?h=v21.08#n124
Commit d2feae68bf30 ("doc: update minimum supported Linux kernel")
> And do we need backport? As 'return -1' does not align with the API doxygen.
>
> Thanks,
> Chenbo
>
>> RTE_EAL_VFIO config option to `true` simply because we are compiling for
>> Linux.
>> So, it looks like VFIO support is pretty much assumed on Linux, so i think
>> we
>> can safely drop the fallback dummy implementation from Linux altogether?
>>
>> lib/eal/linux/eal_vfio.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
>> index 25add2fa5d..b9e4d3ad3c 100644
>> --- a/lib/eal/linux/eal_vfio.c
>> +++ b/lib/eal/linux/eal_vfio.c
>> @@ -2111,19 +2111,19 @@ rte_vfio_enable(__rte_unused const char *modname)
>> int
>> rte_vfio_is_enabled(__rte_unused const char *modname)
>> {
>> - return -1;
>> + return 0;
>> }
>>
>> int
>> rte_vfio_noiommu_is_enabled(void)
>> {
>> - return -1;
>> + return 0;
>> }
>>
>> int
>> rte_vfio_clear_group(__rte_unused int vfio_group_fd)
>> {
>> - return -1;
>> + return 0;
>> }
>>
>> int
>> --
>> 2.25.1
>