From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process
Date: Fri, 2 Apr 2021 17:23:10 +0100 [thread overview]
Message-ID: <fa9da386-41be-8a22-9d44-9ef1106d40d3@intel.com> (raw)
In-Reply-To: <CALBAE1MEceU37-2MQ5ZBsR5P5auuU-FE1TpF5htP7JWx1setcA@mail.gmail.com>
On 02-Apr-21 2:43 PM, Jerin Jacob wrote:
> On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> A common problem on the DPDK mailing list is lack of reviewers for
>> patches. This script is intended to help with that problem, by picking
>> a random commit author from our git history, and adding a Reviewed-by:
>> tag. This can be added to e.g. commit-msg git hook, like so:
>>
>> # add reviewer to commit message
>> $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>>
>> Now all DPDK code will definitely be well reviewed!
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas@monjalon.net>
>
> Looks like shuf aliased to "git shortlog --numbered --summary | head -n 1"
>
>> ---
>> devtools/get-reviewer.sh | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100755 devtools/get-reviewer.sh
>>
>> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
>> new file mode 100755
>> index 0000000000..f4b07c9862
>> --- /dev/null
>> +++ b/devtools/get-reviewer.sh
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +
>> +# find a reviewer for the code
>> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
>
> Leaving the fun part aside,
>
> Looks like we can really improve the situation by
> doing git annotate(to get the original author) of couple lines below
> and above current patch
> that changes lines.
>
> Thoughts?
>
>
>> --
>> 2.25.1
>>
Original author or the person unlucky enough to have been the latest one
to modify the lines in question? :)
It could be useful, but IMO it'll also result in a lot of noise. People
already seem to be very generous with CC's so i don't think *letting
people know* is the issue; finding time to review is.
--
Thanks,
Anatoly
prev parent reply other threads:[~2021-04-02 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:05 Anatoly Burakov
2021-04-01 9:50 ` Gaëtan Rivet
2021-04-01 12:05 ` Burakov, Anatoly
2021-04-02 13:43 ` Jerin Jacob
2021-04-02 16:23 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9da386-41be-8a22-9d44-9ef1106d40d3@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).