From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B528A0548; Fri, 2 Apr 2021 18:23:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84E8414112B; Fri, 2 Apr 2021 18:23:18 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id EDC75141121 for ; Fri, 2 Apr 2021 18:23:16 +0200 (CEST) IronPort-SDR: x0wnRNQIEPSkl/AI6hNwNuk5ZfUN1b1YYTY5j0TNupxDHyDDzv+4LHXhhmVo62J8Ui4kN8EK3g yk7W4OjgLHqw== X-IronPort-AV: E=McAfee;i="6000,8403,9942"; a="180024908" X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="180024908" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 09:23:15 -0700 IronPort-SDR: wSKgFB6+qgoL2tcQGnrsDQ1+mBINfKAfUtbjQvgGbG47t57hc57mhLdJFgVwDUAoydIPrZm78h c7aPI4y/hOSg== X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="419720863" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.214.195]) ([10.213.214.195]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 09:23:14 -0700 To: Jerin Jacob , Thomas Monjalon , David Marchand , "Richardson, Bruce" Cc: dpdk-dev References: <20210401090516.209155-1-anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 2 Apr 2021 17:23:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02-Apr-21 2:43 PM, Jerin Jacob wrote: > On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov > wrote: >> >> A common problem on the DPDK mailing list is lack of reviewers for >> patches. This script is intended to help with that problem, by picking >> a random commit author from our git history, and adding a Reviewed-by: >> tag. This can be added to e.g. commit-msg git hook, like so: >> >> # add reviewer to commit message >> $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1 >> >> Now all DPDK code will definitely be well reviewed! >> >> Signed-off-by: Anatoly Burakov >> Rеviеwеd-by: Thоmas Mоnjаlоn > > Looks like shuf aliased to "git shortlog --numbered --summary | head -n 1" > >> --- >> devtools/get-reviewer.sh | 4 ++++ >> 1 file changed, 4 insertions(+) >> create mode 100755 devtools/get-reviewer.sh >> >> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh >> new file mode 100755 >> index 0000000000..f4b07c9862 >> --- /dev/null >> +++ b/devtools/get-reviewer.sh >> @@ -0,0 +1,4 @@ >> +#!/bin/sh >> + >> +# find a reviewer for the code >> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1 > > Leaving the fun part aside, > > Looks like we can really improve the situation by > doing git annotate(to get the original author) of couple lines below > and above current patch > that changes lines. > > Thoughts? > > >> -- >> 2.25.1 >> Original author or the person unlucky enough to have been the latest one to modify the lines in question? :) It could be useful, but IMO it'll also result in a lot of noise. People already seem to be very generous with CC's so i don't think *letting people know* is the issue; finding time to review is. -- Thanks, Anatoly