From: David Christensen <drc@linux.vnet.ibm.com>
To: dev@dpdk.org, david.marchand@redhat.com
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings
Date: Wed, 8 Sep 2021 10:42:45 -0700 [thread overview]
Message-ID: <fac05c53-bdbd-6273-195b-48fbb2c4cd7a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210902221514.3215704-1-drc@linux.vnet.ibm.com>
> Suppress gcc warning "warning: writing 16 bytes into a region of
> size 0" for users of the POWER rte_memcpy() function. Existing
> rte_memcpy() code takes different code paths based on the actual
> size of the move so the warning is already addressed. See also
> commit b5b3ea803e47 ("eal/x86: ignore gcc 10 stringop-overflow warnings")
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> v2:
> - update copyright year
> - rebase for 21.11-rc0
David M,
Any chance of getting this approved in the 21.11 cycle? Patch was
originally submitted on 6/23, is only applicable to PPC architecture,
and has no functional impact because it only disables warnings.
Patchwork reports a performance test regression on x86 systems:
http://patches.dpdk.org/project/dpdk/patch/20210902221514.3215704-1-drc@linux.vnet.ibm.com/
But I don't see how that is possible. Applying the patch on a local x86
system results in identical x86 binaries with and without the patch
applied. It would appear that the test-to-test performance variations
exceed the failure threshold on the CI setup.
Dave
next prev parent reply other threads:[~2021-09-08 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 16:12 David Christensen
2021-07-05 9:28 ` David Marchand
2021-07-12 19:35 ` David Christensen
2021-07-28 17:49 ` [dpdk-dev] [dpdk-stable] " David Christensen
2021-09-02 22:15 ` [dpdk-dev] " David Christensen
2021-09-08 17:42 ` David Christensen [this message]
2021-09-13 7:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac05c53-bdbd-6273-195b-48fbb2c4cd7a@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).