From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <spinler@cesnet.cz>, <dev@dpdk.org>
Subject: Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build
Date: Mon, 14 Feb 2022 13:36:49 +0000 [thread overview]
Message-ID: <facbcc73-af10-a7a8-d818-23805951d776@intel.com> (raw)
In-Reply-To: <20220214112541.29782-1-spinler@cesnet.cz>
On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote:
> From: Martin Spinler <spinler@cesnet.cz>
>
> The driver uses some FDT manipulation functions from libfdt.
> Let the build system check for libfdt package.
>
I don't see 'libfdt.h' included by the driver, where/how libfdt
is used?
Also what do you think to document this external dependency
and its usage in the driver documentation?
> Signed-off-by: Martin Spinler <spinler@cesnet.cz>
> ---
> drivers/net/nfb/meson.build | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build
> index bb5f66a09a..c080c06bf9 100644
> --- a/drivers/net/nfb/meson.build
> +++ b/drivers/net/nfb/meson.build
> @@ -9,6 +9,12 @@ if is_windows
> subdir_done()
> endif
>
> +if has_libfdt == 0
> + build = false
> + reason = 'missing dependency, "libfdt"'
> + subdir_done()
> +endif
> +
> dep = dependency('netcope-common', required: false, method: 'pkg-config')
> reason = 'missing dependency, "libnfb"'
> build = dep.found()
next prev parent reply other threads:[~2022-02-14 13:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:25 spinler
2022-02-14 11:25 ` [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions spinler
2022-02-14 13:34 ` Ferruh Yigit
2022-02-14 16:52 ` Martin Spinler
2022-02-14 11:25 ` [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst spinler
2022-02-14 13:35 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:34 ` Ferruh Yigit
2022-02-14 11:25 ` [PATCH 4/6] drivers/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-14 11:25 ` [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching spinler
2022-02-14 13:36 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 11:25 ` [PATCH 6/6] drivers/nfb: add support for more MAC addresses spinler
2022-02-14 13:37 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:54 ` Ferruh Yigit
2022-02-15 13:02 ` Martin Spinler
2022-02-14 13:36 ` Ferruh Yigit [this message]
2022-02-14 16:53 ` [PATCH 1/6] net/nfb: add missing libfdt dependency for build Martin Spinler
2022-02-15 12:55 ` [PATCH v2 0/5] " spinler
2022-02-15 12:55 ` [PATCH v2 1/5] net/nfb: fix array indexes in deinit functions spinler
2022-02-15 12:55 ` [PATCH v2 2/5] net/nfb: do not report zero-sized TX burst spinler
2022-02-15 12:55 ` [PATCH v2 3/5] net/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-15 12:55 ` [PATCH v2 4/5] net/nfb: fix multicast/promiscuous mode switching spinler
2022-02-15 12:55 ` [PATCH v2 5/5] net/nfb: add support for more MAC addresses spinler
2022-02-15 13:55 ` [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build Ferruh Yigit
2022-02-15 13:57 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=facbcc73-af10-a7a8-d818-23805951d776@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=spinler@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).