From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D64504416A; Thu, 6 Jun 2024 15:21:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3B46410F1; Thu, 6 Jun 2024 15:21:22 +0200 (CEST) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mails.dpdk.org (Postfix) with ESMTP id F0D88402E7 for ; Thu, 6 Jun 2024 15:21:21 +0200 (CEST) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a68a9a4e9a6so96276866b.3 for ; Thu, 06 Jun 2024 06:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1717680081; x=1718284881; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uCjym8wx7rfwi7liDm/WEflDrnQABHmy676AhtaXO9c=; b=qE3nNGZufFG7uZ45agNOUEQoI2xwzPHvSUvMfIK6PHH51qpnQloOOJXE3wCE1S46T/ lyobmI5EmYpKjL7tDPmXGztB+xFqXtRiX9Oh9Qqd0VOdOR5ocKvCmqRp5iUyyIBAStDc NnPh6QNxE1ymgVauBlr7f4Wcfl9OJPKlF2qSd6mPp93TX2XBOSu0quu0dpFfHrCMBEQv ieY0c+uEarGphjJPStHOG+DVl0SKXwQHHvG3wqGxMzvqqa6FR2cavFtEmmV6JoC1Sglv OKQBHscWzXakWnkmO4CrPvlyuHFvOgXqQ2+NGFWtMI8+cEWgvzbg1fTudBfaTjtSS787 C5aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717680081; x=1718284881; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uCjym8wx7rfwi7liDm/WEflDrnQABHmy676AhtaXO9c=; b=bnVMjZUJepWH3bI9enVq9JQaquVQUAWuvMK6wOERSF7xB6rIeL4ORcpV50g7yZXqGy yrWL0w5Cf4bWmUSH/q400OVksNunnCMWDeucudKYPxBMzhYcOaSHP/xrUNb71bh8GLcb pEbq9bL42Rsf1KT3rZnbJoAookL8AZg1/Ar8RIFiFCkayybkx95RJxm0i4Cy8NAiWIIT IItDftpPERuOsDCw+yK7mKAMEQnKFmCG0otXjL/gVBOIgyjHP6TzoSJ8+C39SrcU4kPj ucCqBUJmiE0tG26plzeoqTyN639DwBW3R+d5X0f62158r2y3rEKqj5YkiXCuDdCDb1x5 FpXQ== X-Forwarded-Encrypted: i=1; AJvYcCWrvrfTz9xjbuyEq9jTjS0gEeq2Dedni8leBO5Gw9NX6fYdPAPUMEALi63Qwq69U/i8yZrHW1nxjgLPs4A= X-Gm-Message-State: AOJu0YxzdBBzsLZfJCr0ipCuO2lhxII21u0KrnEhF1ZkyZRhYy9o9Dsx iWILf5m4ZBUpnJQq1F4qNfpSD3mOzD5QD0l5YFTVMQgCHH62/bBoz1TJhGHa7ss= X-Google-Smtp-Source: AGHT+IFO6Mrs8IOtUVVk4+n/bxo6fUKl1l0oaJUHaBiuH3TENHCcu5sdRfl1zYhIr0DBMn/IsAYkVw== X-Received: by 2002:a17:906:390e:b0:a68:fd49:ab9e with SMTP id a640c23a62f3a-a699f88b01bmr392536166b.36.1717680081416; Thu, 06 Jun 2024 06:21:21 -0700 (PDT) Received: from [10.12.0.152] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c8070eaf7sm99097366b.172.2024.06.06.06.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 06:21:20 -0700 (PDT) Message-ID: Date: Thu, 6 Jun 2024 15:21:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] dts: remove module-wide imports To: Luca Vizzarro , dev@dpdk.org Cc: Jeremy Spewock , Paul Szczepanek References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240509112057.1167947-1-luca.vizzarro@arm.com> <20240509112057.1167947-5-luca.vizzarro@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240509112057.1167947-5-luca.vizzarro@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9. 5. 2024 13:20, Luca Vizzarro wrote: > Remove the imports in the testbed_model and remote_session modules init > file, to avoid the initialisation of unneeded modules, thus removing or > limiting the risk of circular dependencies. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/framework/remote_session/__init__.py | 5 +---- > dts/framework/runner.py | 4 +++- > dts/framework/test_suite.py | 5 ++++- > dts/framework/testbed_model/__init__.py | 7 ------- > dts/framework/testbed_model/os_session.py | 4 ++-- > dts/framework/testbed_model/sut_node.py | 2 +- > dts/framework/testbed_model/traffic_generator/scapy.py | 2 +- > dts/tests/TestSuite_hello_world.py | 2 +- > dts/tests/TestSuite_smoke_tests.py | 2 +- > 9 files changed, 14 insertions(+), 19 deletions(-) > > diff --git a/dts/framework/testbed_model/__init__.py b/dts/framework/testbed_model/__init__.py > index 6086512ca2..4f8a58c039 100644 > --- a/dts/framework/testbed_model/__init__.py > +++ b/dts/framework/testbed_model/__init__.py > @@ -19,10 +19,3 @@ > """ > > # pylama:ignore=W0611 There's no reason to leave this in now. It may not be needed in dts/framework/remote_session/__init__.py as well. > - > -from .cpu import LogicalCoreCount, LogicalCoreCountFilter, LogicalCoreList > -from .node import Node > -from .port import Port, PortLink > -from .sut_node import SutNode > -from .tg_node import TGNode > -from .virtual_device import VirtualDevice