From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5043545D39;
Mon, 18 Nov 2024 18:14:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D56AE40698;
Mon, 18 Nov 2024 18:14:08 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by mails.dpdk.org (Postfix) with ESMTP id 3AA8940290
for <dev@dpdk.org>; Mon, 18 Nov 2024 18:14:08 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B7A0165C;
Mon, 18 Nov 2024 09:14:37 -0800 (PST)
Received: from [192.168.50.107] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id
545553F6A8; Mon, 18 Nov 2024 09:14:06 -0800 (PST)
Message-ID: <fadcc7d5-7a65-488b-81e2-842958528eaa@arm.com>
Date: Mon, 18 Nov 2024 17:14:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/6] dts: Self-Discovering Architecture Change
Content-Language: en-GB
To: Nicholas Pratte <npratte@iol.unh.edu>, probb@iol.unh.edu,
dmarx@iol.unh.edu, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
juraj.linkes@pantheon.tech
Cc: dev@dpdk.org
References: <20240613201831.9748-3-npratte@iol.unh.edu>
<20240705171341.23894-8-npratte@iol.unh.edu>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <20240705171341.23894-8-npratte@iol.unh.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Here again I am on the same level as Juraj. Repeating my previous
comments on commit subject and Bugzilla ID.
Moreover, the subject should be of imperative form according to the
contributing guidelines. In other words, the first word is always an
imperative verb. Something like this could work:
dts: enable self-discovering architecture
About the commit body indicating uncertainty ("I believe..."), there
shouldn't be space for uncertainty on the tree, but just backed-up
facts. If you are uncertain about something, make sure to find out if
the statement stands true and provide the reasoning around it.
You can find out if the call is a standard by looking up the manual[1].
In this case it doesn't mention anything except of being related to the
syscall[2], which is indeed backed up by the POSIX.1 standard. But you
can attempt to compare it to any other POSIX OS and draw some
conclusions. For example FreeBSD's manual[3], explicitly states that
their command is conform to the POSIX.2 standard. And you'll notice that
FreeBSD's has more options than Linux's. The conclusion I can gather
here is that Linux's version is not entirely conform and implements only
a subset. For our usage, this is good enough as it still falls under the
POSIX umbrella. Therefore, you can change your paragraph into something
like:
The POSIX-compliant options of the command `uname` are used
to determine the system architecture.
Hope this helps!
Best,
Luca
[1] https://man7.org/linux/man-pages/man1/uname.1.html
[2] https://man7.org/linux/man-pages/man2/uname.2.html
[3] https://man.freebsd.org/cgi/man.cgi?uname