From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E27B1A034E; Wed, 9 Feb 2022 20:07:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D784E41155; Wed, 9 Feb 2022 20:07:40 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 49A1640140; Wed, 9 Feb 2022 20:07:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644433658; x=1675969658; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ipfAR5ekhM+4sqRQiipkuiXIvlRCRm4G0EzDG4ft8yM=; b=dfSDHpJkejfncyMvu3NStTC6QnzIzp0HlWs77e+lbfnPGmaXMWz1CM7w +vvNiZS/kAIaO9PRW4ajMssy85tTOK1k9+1UkEOpgAhdRTEOY9lKn4rGG 8dps4GPwLlL901+x5ASM5ESbKvzG6YsVv5vWkv21XhdbxQ4hVLQUC9I2n lg2WQwMjo8mBAGrlC7w8BOWRZp51THZt3q7lW8WycTFtGziEDsGrPtikv +V83uY1AW6riyJ7RDIiFYWNDXyj1GZ8O2QDQPaJ7x7bLdG+uM3vi+YVyu WYpoCCyGP3KbyALm5b83SkhHKZ5jqM5SfHTd9z20ZjsQZ/ysYy4jbjUNe g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="248142851" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="248142851" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 11:07:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="482454071" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2022 11:07:37 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 11:07:36 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 11:07:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 11:07:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNSFAYXmGEJA/gY1FCUFW6iyJJ1s5qqhRP7big4hM0PpLh+hYlVMV5sy/V4Wpz8EFiSYiKZe9QdDpXiUW9lHLSctY4FZ1vZSIfVs7yPVBNegTh6aquVTNHV0w78pqQyZ1NMbi2aTCpMS0Qe2fj5gT2RKzD8MHfKoq5oL+uwi9Mg4oInQC9bYuH/pBUyV7wU0LbPIU3Ql0svH4lIVgN7A9IPDr8k2DfgjV3HzGF9PvxduE5VNQt0iyFKbvHnnfpBEvP8DiML81Y+fv0+E8TT6Rkde+JYz+9dR28euWGgfSfUaJS7maANTfFpR7i1+ZGC77hAZyh3ZNzwBUktyenWiAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YFU3+J/fGGIJkXva5aZGitnAsrBLEgmc5OTJkJXxaEk=; b=SUkjLJl1M7bKqfx8+ZxZxfzdohoW10QdLwJLj7L6Aos3C0gXw2+qHWkYoh0ptYHQXOpX2UFWaiAOlrEhqAx72ZXXpMAjSr45Tpvr6yoODRNnnMVwkGGvyMx8Rn3XM/rTGbJ7naaAjB60s+5pAmaws8AcoNS1zATwo9D0dwFrA+Bxg8mJ48eJOJYzXvK07qz5UQtcTCKROtLwTIsRFrwAqodC5ByDreYC32xsCeDgCeePHkPB7ELleoLOlC6I6YFq/J3EV+LEoTRYkQMU4+B1D5bjd0refW5+fgJtRifrz5mSCNlMc4vIrDFSlrq2u5a0y+BfKz7F5bkbEVea/81Vtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:07:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:07:34 +0000 Message-ID: Date: Wed, 9 Feb 2022 19:07:30 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20220209104213.602728-1-jiawenwu@trustnetic.com> <20220209104213.602728-4-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH v2 03/12] net/ngbe: fix Tx pending X-User: ferruhy In-Reply-To: <20220209104213.602728-4-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR06CA0059.eurprd06.prod.outlook.com (2603:10a6:10:120::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44df36bc-0787-4f34-6076-08d9ebff6df3 X-MS-TrafficTypeDiagnostic: DM6PR11MB4593:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:862; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2M0ZKJwarplE+ULCsTfKa2udoDa07q6KcF+groQxacXMcdSMBTW+JLGYBojMQTWNhmajTLDVxfj3xlUFIwKFXhxHYLLJhHYvblnJnNpQxfyu4w9R+Br1SJiC7sJe1zLOX8GJnyEjMdEAHfW5xECedvYfnLCRRTf6YVRpLaPGBbTGNkdPBQ5Se6mFNBhNBIOH6aYw1a32DUdDenEsY73G2fiU//Tk557jFYF508TgBLjlodsL9hyQpswmFhRdHtsffhS4717RAZ1U8Veh43kAVBYu9wVhVaykqAaBJq88lDO/oNjEtJpPNoSXqfb1weEyVrqYvOxEtjw6l32tY3dYYvvI0xSJxSmMu0pArWS51mo7gDJ8Udf+jCGc0wplmsoH50MhVEvZ4+y2RBtONWQCq9ew29qOgSlcxMJWm2oXdw/y94EsJaHBzXumjX9EB948yGT3LcwJOmCedf99rQVKyN/pp0iPKEvK+ML3wiBsugr6bkMR4CCAtko5bqK65dnTpfWKSq2zbvDDOkP4g0gJnml+uhGMc7e4bxoowHBhrbA3a4tb7cL6tjrwqkPlHIXxrFwDxnucTDwn9YX0Z5JM63+2BTFVNUgpW92FEMvbAC1TCQC0UcPjmFuFdmNb8KRoF13i7IO1lA3qRmo8b3MkQc6SkOmS/zBXJr+5jGc60fbTYPsPWUA/7yzXLR0cH3Y9p3smzV3O8SLIUAUP/iq6PA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(8676002)(36756003)(83380400001)(31686004)(6666004)(186003)(6506007)(316002)(31696002)(86362001)(66946007)(4326008)(26005)(66476007)(66556008)(82960400001)(4744005)(38100700002)(44832011)(53546011)(6512007)(5660300002)(6486002)(8936002)(55236004)(2906002)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnV0d0x2Tk5LeVY2aEpLTzdpOEg0VEMyMVRLTS94RXE5ZG1sSHdlQzlYS3Nh?= =?utf-8?B?MTlEZW5WcEQ0dHRLR2phQW1JNzd0QVlnUTIvTHZzNmFlTUxibGRiT2hqUEt2?= =?utf-8?B?R05GRlZYZXYxUHg4Wk9rdUNIb0Y4Zm5ma082MXgrWGxqNE9td1NqWW9SUkVB?= =?utf-8?B?N1ZhWnBuajdqYUVaUkJiSERoMjBlK3EvYVNEK0loNkdSTi9tbm51dytOWHh1?= =?utf-8?B?N3Y0MkFWeVYzSkxHWEZ2M2hUV0h2YjBGaE9BcFVDaHR6SmRIb0ZmdXA3cnlt?= =?utf-8?B?U0YwTnJBYkFFVDdiZjVVSFJvSzBReFowU0NBOG5jbHM5UjVIMHdtMnFzc0ZF?= =?utf-8?B?YXVWcEszUTE5bHp4emZRL2tZRmRuaEpRMlV3UngrSlBBM1ppRnVDTU5GWjNo?= =?utf-8?B?d2hReWpOeWh4eEx1SjBod09RRnpndm54N2FBalpoMlBDTzl6ekpSWTBGMlBH?= =?utf-8?B?L1RrZnA5MWhadCtYd1lCUHBKZzkrelY2SGJuVFNkdElKYUdLTEpIazJSaFYw?= =?utf-8?B?UmVuM3RqQmZSdWVRcDZvR3NsN1ZQODV6R0d5UTdNR1Jsclk1ZlR3eXJ1YjFJ?= =?utf-8?B?bDQ0R0VCL0VmYXV4dVIrK0J3UVY4cEtsVVpHWUhkNG0xZWtGTkJTRGpQL0Ev?= =?utf-8?B?QVd2b2VOZS9zSmU1dnJlS1daWVBscWJUeEVBd0p2NDBUb1czMnM1QndXZ09C?= =?utf-8?B?UHBxSXRqMS9oa3JCTTNRN2J4aDdyYVdGQmVaUEpzUWwrZ2Z3aTNyNFdtemlZ?= =?utf-8?B?UnVKVzEwU3JEYTVxWVc0Q2F1MlZtTU8xQVBJOWk5SENnWFN3VnJtZk9sbmFm?= =?utf-8?B?dGNFa21YNURuYjRXUkgyZWtsUE9GK2xRb1pzU050b2JINnVqTmx3SU5la2Zj?= =?utf-8?B?dFJmdVlVOUJBRytsQ0RzVFVaSEJOMzlhNGl6Lzl2T3E3aENCaC9Ocys3KzZn?= =?utf-8?B?Y3JiTzNuWEgrVlFmeVQ1eVMycS9ONUtITHdQaUY3SXhHRFVlVlJJVFFkdjNx?= =?utf-8?B?czZsT3RWSHJ0U3NXeVdtRlpTK3l3cjRWNHpJUk12QnJNWEs2d1pCYUFhTlhR?= =?utf-8?B?R2JUclBMMkhKTHVCWHc4WWswRUVQWmYzZnNoT3hiM1hRZXMyalkxYXA3L0dT?= =?utf-8?B?QU1jaWg4ZHlhZFBUSS9MWDJEdS92cTNJajl2VnIwb28zZ0R2VU13YTg2MS93?= =?utf-8?B?bXhuN29JcjVtSlI5WGxvS1JjS2FTWTNibjVuVzVTem1sOWtwdTk4ZDNCc0l4?= =?utf-8?B?YXcyYmRDc1VyQ2JlZ2N4UUJSbWVvaWJsZjdpL3B6cUtsSFN4QVNTaE5kNkx2?= =?utf-8?B?anMzTEJSN1dFSHhad1BYRG13aUJUaWd5ZDcyRzllZzZWVng2TGw4czdtR1BK?= =?utf-8?B?ejMyZ24zZjNQOVIxSndaMDhoUjJGR1k3SythQnc3cHRsOEhTQ0tzRVNkdndL?= =?utf-8?B?SzBRaTU1S1FrZHIwdXRTNEVuNXFKMmZTQzhKV2h3YXIrV1dhQVlmQWIvcTJ4?= =?utf-8?B?YzgwbnBybytSQ21GcWxESEI1ZzFwdStURVUybUl6dmdDLzRsS2VhelhMbHBW?= =?utf-8?B?THV4Q2E0aWkvd0VqYldac0YydVFUczZOZjFOOXlCVUVWZW9iS1pYelZkNDhw?= =?utf-8?B?TXNqeXRNcGdRU0czOXowdUlZb2xCb1llTkh5M2Y2enJYR29nVDc3NGVFQjdi?= =?utf-8?B?TjRKVFJreXNMN1hFTm1wZjB2N0grelE0MkFXc3BwZXd6YlJzNnYwRkQrQzBI?= =?utf-8?B?MFUrZCtNeTlKcHFSMmh2WFNwODF2ODYyd2hySzNsNVBtUzZnK0RtNEpRR1Rm?= =?utf-8?B?akYwRjVWS3JXc2RZbzNLWlN3TjNKWFpDWUkyYUZaRFI3SUFxSlFMUWtSd0dt?= =?utf-8?B?Qm1wdk13YVpRaUZvREVBYlMwTDBqRHNranlIajZvNGlpL3FnMU1hL2dOc1J5?= =?utf-8?B?a0lYU3RKQjNLTk5CU0dOYnc5VE9JKzJNenY1M0lFZU9OK1RWd1R3aktjNG5k?= =?utf-8?B?bC9POENBKzV5NS9BbEZHMkFFeWloNzBsWU1vN2IvM1ZQbllkR3lrYkV4TytB?= =?utf-8?B?VVZ3RS9XS1lMSXVLczA1MHBhaHJrN0s0RnFVZ09VSHlaT3ZRNnpkbTBLUjh3?= =?utf-8?B?YjhTL2dMd0o2VHZYNFpxUk55VmxLOThra2J1V1B4V2dMZFBBTFhOQk41WG9u?= =?utf-8?Q?rZppHuKVj6A6vROfRnjgvwo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 44df36bc-0787-4f34-6076-08d9ebff6df3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:07:34.6003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6PlCNco+27Zv96TGHnelUs1ECKeaM5RptGkOV09KERXe0u7tyfd/zqvkRidR5LihJX9rA2qsOl460sWag6ac6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4593 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 10:42 AM, Jiawen Wu wrote: > Add commands requesting firmware to enable or disable PCIe bus master. > Disable PCIe master access to clear BME when stop hardware, and verify > there are no pending requests. > > Move disabling Tx queue after disabling PCIe bus master, to ensure that > there are no packets left to cause Tx hang. > Thanks for update, what do you think about following title: net/ngbe: fix Tx hang on queue disable > Fixes: 78710873c2f3 ("net/ngbe: add HW initialization") > Cc:stable@dpdk.org > > Signed-off-by: Jiawen Wu