From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 868C441D73; Thu, 2 Mar 2023 13:30:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C0D940E2D; Thu, 2 Mar 2023 13:30:23 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 452A040E09 for ; Thu, 2 Mar 2023 13:30:22 +0100 (CET) Received: from dggpeml100023.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PS9NV6n5LznWbR; Thu, 2 Mar 2023 20:27:38 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by dggpeml100023.china.huawei.com (7.185.36.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 20:30:19 +0800 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.021; Thu, 2 Mar 2023 13:30:17 +0100 From: Konstantin Ananyev To: Fengchengwen , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "Ajit Khaparde" , Somnath Kotur CC: "dev@dpdk.org" Subject: RE: [PATCH 4/5] net/bnxt: use fp ops setup function Thread-Topic: [PATCH 4/5] net/bnxt: use fp ops setup function Thread-Index: AQHZS+uwrrTPA+4mDkmog2lcLJ1r9a7nbI0w Date: Thu, 2 Mar 2023 12:30:17 +0000 Message-ID: References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-5-fengchengwen@huawei.com> In-Reply-To: <20230301030610.49468-5-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Use rte_eth_fp_ops_setup() instead of directly manipulating > rte_eth_fp_ops variable. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > --- > drivers/net/bnxt/bnxt_cpr.c | 5 +---- > drivers/net/bnxt/bnxt_ethdev.c | 5 +---- > 2 files changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c > index 3950840600..a3f33c24c3 100644 > --- a/drivers/net/bnxt/bnxt_cpr.c > +++ b/drivers/net/bnxt/bnxt_cpr.c > @@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev) > eth_dev->rx_pkt_burst =3D rte_eth_pkt_burst_dummy; > eth_dev->tx_pkt_burst =3D rte_eth_pkt_burst_dummy; I am not that familiar with bnxt driver, but shouldn't we set here other optional fp_ops (descripto_status, etc.) to some dummy values OR to n= ull values? =20 >=20 > - rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =3D > - eth_dev->rx_pkt_burst; > - rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =3D > - eth_dev->tx_pkt_burst; > + rte_eth_fp_ops_setup(eth_dev); > rte_mb(); >=20 > /* Allow time for threads to exit the real burst functions. */ > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index 4083a69d02..d6064ceea4 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4374,10 +4374,7 @@ static void bnxt_dev_recover(void *arg) > if (rc) > goto err_start; >=20 > - rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =3D > - bp->eth_dev->rx_pkt_burst; > - rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =3D > - bp->eth_dev->tx_pkt_burst; > + rte_eth_fp_ops_setup(bp->eth_dev); > rte_mb(); >=20 > PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n", > -- > 2.17.1