From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7C4B869C3 for ; Tue, 7 Feb 2017 11:32:47 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2017 02:32:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="222274229" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 07 Feb 2017 02:32:33 -0800 To: Qi Zhang , jingjing.wu@intel.com, helin.zhang@intel.com, Yuanhan Liu References: <1486164969-2566-1-git-send-email-qi.z.zhang@intel.com> <736135ef-b9cf-cd6e-1dfc-ecba9d63e114@intel.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Tue, 7 Feb 2017 10:32:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <736135ef-b9cf-cd6e-1dfc-ecba9d63e114@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix wrong device flag setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 10:32:47 -0000 On 2/7/2017 10:24 AM, Ferruh Yigit wrote: > On 2/3/2017 11:36 PM, Qi Zhang wrote: >> dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after >> rte_eth_copy_pci_info. >> >> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices") >> >> Signed-off-by: Qi Zhang >> --- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/e1000/igb_ethdev.c | 4 ++-- >> drivers/net/fm10k/fm10k_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- >> drivers/net/nfp/nfp_net.c | 2 +- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- >> 8 files changed, 10 insertions(+), 10 deletions(-) >> > > Hi Qi, > > Thanks for the fix. > > Is following missed, or intentionally excluded: > > drivers/net/e1000/em_ethdev.c > drivers/net/virtio/virtio_ethdev.c Hi Yuanhan, I saw while checking for this, there can be an issue in virtio for this path, can you please check: eth_virtio_dev_init() set-some-eth_dev-dev_flags virtio_init_device() rte_eth_copy_pci_info() eth_dev->data->dev_flags = 0; <---- Reset previous flags Regards, ferruh