From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5A1C345967;
	Thu, 12 Sep 2024 06:07:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D645040657;
	Thu, 12 Sep 2024 06:07:32 +0200 (CEST)
Received: from lf-2-14.ptr.blmpb.com (lf-2-14.ptr.blmpb.com [101.36.218.14])
 by mails.dpdk.org (Postfix) with ESMTP id 492C140654
 for <dev@dpdk.org>; Thu, 12 Sep 2024 06:07:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 s=feishu2403070942; d=yunsilicon.com; t=1726114038; h=from:subject:
 mime-version:from:date:message-id:subject:to:cc:reply-to:content-type:
 mime-version:in-reply-to:message-id;
 bh=mWgfkcvBi1jsKfzoZqu3YYueC4JRbyTk0TDV2/IwaGs=;
 b=joYgLVR0LS7QaO5g8NTd0UZaa17+n01pwcbRtVuuozNwuSftvIQCc6KPufYoU8Qpnq8CQ8
 ucNrePkAe9Q1qsulmndhdABeuI5imMUT6jYKG7eVbiZFuqt5yqTiu5jBUzT82IK8xmiPD6
 S0Wy0NduHgvT8Ygxf1KQhEaSOYNxHz0u9GJgKN2LAEsTq98BXw+zIdrdNTOuPT9ryblv7B
 19QYYCloQ7ykv90YhUIFalS2GM9gITJMQan36uI5lezs+WDxPdJ+hOsg659Wetm0ty1gb6
 2vXnYURFq9m8GrG7rluWAYtFLllFlv0XqNsMYTcU5OkqgCMx2do8iqLCDEJjPA==
Received: from [127.0.0.1] ([180.158.103.102]) by smtp.feishu.cn with ESMTPS;
 Thu, 12 Sep 2024 12:07:16 +0800
X-Lms-Return-Path: <lba+266e268f5+a9c6b3+dpdk.org+wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>
From: "WanRenyong" <wanry@yunsilicon.com>
Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface
Date: Thu, 12 Sep 2024 12:07:15 +0800
Mime-Version: 1.0
X-Original-From: WanRenyong <wanry@yunsilicon.com>
References: <20240911020740.3950704-6-wanry@yunsilicon.com>
 <20240910204842.6e965a48@hermes.local>
In-Reply-To: <20240910204842.6e965a48@hermes.local>
User-Agent: Mozilla Thunderbird
To: "Stephen Hemminger" <stephen@networkplumber.org>
Message-Id: <fb70a79c-f339-44d7-9e55-80d79bf120f0@yunsilicon.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/11 11:48, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> +	hdr =3D rte_zmalloc(NULL, alloc_len, RTE_CACHE_LINE_SIZE);
>> +	if (hdr =3D=3D NULL) {
>> +		PMD_DRV_LOG(ERR, "Failed to allocate xsc ioctl cmd memory");
>> +		return -ENOMEM;
>> +	}
>> +
> This is local to function, use malloc() not rte_zmalloc().
> It doesn't need to come from hugepages.

Hello, Stephen,

Thanks for you review,=C2=A0 will fix it in next version.

--=20
Thanks,
WanRenyong