From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01hn0204.outbound.protection.outlook.com [104.47.0.204]) by dpdk.org (Postfix) with ESMTP id E266F4C9C for ; Fri, 23 Feb 2018 11:03:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R5gXIPCyr4OxZuOWmECvhgy9O3IBkVx4LnSIGDlZ0IY=; b=uDRGqIiusGc+bxKcNrvtPeGatduhb0rXPPE9OrOQacyDVelmbF7Gs5s5qbUhQlbbJ8dMngkC84mP7LAcvsXJTAKbxuRySMOQpBOGSWTdzP9JcBPopxsl46zee/RSFuzXLA23aPTM4uHUUmybiLiC4dQgBJgdbXn2AKFHT89qY4I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [10.232.133.65] (192.88.169.1) by DB4PR04MB0765.eurprd04.prod.outlook.com (2a01:111:e400:984d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Fri, 23 Feb 2018 10:03:06 +0000 To: Thomas Monjalon Cc: dev@dpdk.org, mvarlese@suse.de References: <1519329652.2458.5.camel@suse.de> <20180222225308.16972-2-thomas@monjalon.net> <1759755.H60iFR18bq@xps> From: Hemant Agrawal Message-ID: Date: Fri, 23 Feb 2018 15:32:55 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1759755.H60iFR18bq@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: PN1PR01CA0117.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::33) To DB4PR04MB0765.eurprd04.prod.outlook.com (2a01:111:e400:984d::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9b6ef921-9ba0-4e37-81ab-08d57aa4a343 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:DB4PR04MB0765; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 3:wdOA0YGNVPZZ1e97IQ1UxU1B+QEaoYcg7xpDgJeUtpWlQfHzw1G1xUzPhfO88/x+2Xad5p/FoWnSU1PAg6NvxcBsVOo2hJY3OTlsBNI2J8wW2AYTfeiXxFOi+9ItV9VnqlUtK4T+TKVwZoLlDa842UDCizBhuago6MSFuw/7QtcW2cTfEd2urYN2jcEMZUimzGeKuQ5XArQ1XN7gnYkMQROGsuPcnFdkRFxkoidQbiGIqfAoyZuzLkHBxh8qshO2; 25:lj3sxsP/WPDn/19kgWq09CHXyviUIT0ThDWF5CTMNBf658d2o0ov+72zZmTAFGCgFYoGUYL0bUqoYVLxI+cWf+bKtJoBWKCiqsSoiCF/K9ce9QMYpg4vxiOrYu0uT8Qjxcw6LmQeTAUarvG9JMrUeAaJU/f5QBbNLMa4OtQ8DYlFFCT/pSwl/exl7sEH95r83Uy1+eWOhhPFiKgiCmyOjdk51MZ+okbI3gbzEklY/rxqQFz0Y8o964gVkZQ0BLCeX1mIgxiKGvHPqS5jE2Xaff88YlIjEa/zMwf8lwF33IJ8W6RHduD8OQk8NSk51px/QZ1CxofFi/p300Amdcv16kzsPGIfwaLUh3ngCdpzTvY=; 31:l4M/I/ps+dV2cMymMKJdmwEXzo4xzklQ2au8JxzKghinBCTc+Iawmo62aWgaN+5TRJOs8DyPcSAdIaCJUSPV7fTI0fVYbOt0DYsLSg3RnCPRB3xgDAU6N0QyvGMo818Q0XB5ELMdXvZYK9Mxd2kp7ipwcVZF2L/xloZVXGu80ssv1dU2L1CqBX6/HruMxdvBqFQbWSGo/0E1I9JJe5fciSEhh1ZOHpPzwFdijc/f92w= X-MS-TrafficTypeDiagnostic: DB4PR04MB0765: X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 20:mUm0yx3y5Ze7abd6s08rytTjpXmhChSswtD4/FrYUyCMdZSDTzGiegSm9hGAb09KCsfRWm7gtF0FtX1lrFF0yqXcTOCfNox3gl7EWFI7R4wRGZUfo1o9iUdbSjp0NOPOIoipnzZxHPtzrO83nuqH8+SmFVasGTaigD4JFMQGiAJd8gkUAs74EnMb/F2aZDLTZ2iZnHPzYFflFcunV76XbNZ9pc1tbKgLA5YeQsJTG+pqVBsVlwlw/Dm9EJ+uDGHPicR9YRcNsWNEfq1eLo7k30JVrSQlwD+ktbk5J8dnyjYGOkTGeT/mnYWrPjy3BZLR3e7ueKp89z69wGdzgF9jOdwcj6K1bxLtpLAuWWChPtx7VKm0swS+xg996XKzZzGqTXRAq1FLYWEmL8Zz4hpn3YC36pJKGNMDocdCt2/8NcKaar8UtqEKKctccYTr/O6rbkwadDksxrnIbIbwaY230jUQPa4m1Fe+hfcRhBZ1g/RBBUU6v1Oe1wfAxkS3S4QP; 4:Hfeq7TSh1KHePx7FiwSbNNX2TTAEGrp+pmCcts+PiEB2MzROcsXgBNPqVsQqSe/Hzi59fQcfA2AQfgLFnKlwplCtR6VrdTs2w2xMr5/wLhBNcA4Fb784T17TBbs1+C194Xg5LVMF6OiunFnGOpBHOWxp2LLJeFcYspvfjovbNaSj3P5p8a3xZup6I1qMByVGtJL5CncVmt1rhGBoNnEQKGtC6fRG8BxFvczkOPBc6GRA/pb2zasgCKCuRBi2kuyjaIuesQr5j7Z1c6PnbLBdUNc+Ve3JoEXR6HaHWGiEtAsZuPWthHVm2s+NQ2qYe8ae X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(66839620246622); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3231101)(2232076)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:DB4PR04MB0765; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0765; X-Forefront-PRVS: 0592A9FDE6 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6049001)(39380400002)(366004)(346002)(376002)(39860400002)(396003)(189003)(199004)(53546011)(52116002)(106356001)(7736002)(36756003)(6116002)(81166006)(2486003)(3846002)(316002)(65956001)(478600001)(81156014)(8676002)(8936002)(65806001)(105586002)(47776003)(93886005)(66066001)(68736007)(229853002)(86362001)(31696002)(50466002)(26005)(186003)(2950100002)(6916009)(53936002)(230700001)(6666003)(6486002)(58126008)(16576012)(386003)(16526019)(25786009)(77096007)(65826007)(23676004)(97736004)(52146003)(305945005)(4326008)(64126003)(2906002)(5660300001)(31686004)(76176011)(6246003)(59450400001)(67846002)(59010400001); DIR:OUT; SFP:1501; SCL:5; SRVR:DB4PR04MB0765; H:[10.232.133.65]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA0TUIwNzY1OzIzOjlialVXSU1jQkpXRjJCelI0RDE2RHMxT0Qx?= =?utf-8?B?dXYrTlEzOUVnZzg3TUpneTZ6MDNRVExwdzBnVlhlUXdYcFhMcDdTaGhzVjZM?= =?utf-8?B?aGNsRU51YU9zU3hhcDJzU0Q1T1JvRmlIbHlYV3d0bVFnZEpWWndEaXBkbmRs?= =?utf-8?B?VEZwN3YrSUgwazU2d0JxUEkrVTYvc0E4QVoxRjZXZkp0cHQwaFVuWTloOUVP?= =?utf-8?B?SzNyQmU2eXRIWVQ3bS9KalRTNWtIdllBa0t6MmoyNnE1MVN0SWdlOTdwZmVV?= =?utf-8?B?bjcwYVVFS29CMGtkYjJRbEtNaTBpSEFzRCsrWmxRN0hlQ0IwT3lzZlZKQzVn?= =?utf-8?B?MnFtdXZPMnp3TUErY3pqTENuLzNpcmYreitXcU1xRk5xVUZJV3kybnJ0K0VU?= =?utf-8?B?Yk9OVno2S1hLdk9tWTNTNnVXN0s5Zlhpek5DdllZWmJLdGxER3p2VUEzTThr?= =?utf-8?B?c0h6aTA3RVdsMnhrcEJnM2Y0czM5WWhzbTMrVlM1bGRGV2VFellqbDRFVXk5?= =?utf-8?B?M3ArcFJEVHpGWmh2dXkxUzExZnlDM3duYUoydU5kaXV6M0pzWXRabkNrODRF?= =?utf-8?B?SVdsa1E5dWpBbkZvSDFOMENxNU5WajIyNUNoOElXTE5UY0UvenFwcFcrWWJ0?= =?utf-8?B?UG84eG11WHJnRHdPVGh6SVlzUDAyWHJ6T3lIcnJpa3o0ODYyN1lQWGtaUGMy?= =?utf-8?B?eVZXOFlxUmZwTjhPY3duT2FTWGNSa0w5UzJ5Rk9QZ1BtMHRTMFV1ZXY4WDIr?= =?utf-8?B?Z1JQUWN3WEJPMXVLbm9zelpLZHV0L0FEV002UFdIeHhpUlpEcFdhcEprQTJY?= =?utf-8?B?OTNFMDdaZkpHbzFtMHpSYmx2aDFmVlp1RU05aWY0cFhyYWlxdUloVnpjMDdR?= =?utf-8?B?d1dpUHhGWm4vM29TWTNHb0ZKYjNqSU9nVkFUN1hmTEcrL2tHUmg0cVJEcmhO?= =?utf-8?B?cy9hOTI3S2tuaWpkYzUyOXRXOHdiNU1OQndWRExVR1B4K1ZDRlMweStlTEg0?= =?utf-8?B?R1ZQWGJKR3p3cG5xSDZjVDEwK3F3NEo2dEJNbWpnY1R5SEZVYmJUREFnelVm?= =?utf-8?B?VktkOGhKTlBMKzZuWVdTV2hjS1JiRnRpWXBSODJHdUpVWnFmOG91cE5haGVT?= =?utf-8?B?dzJPQ1hVcnpzVHJVS3Z2QnFDVU05dm96K05qM2V4c0lBanBqNG1yL3JLTEd2?= =?utf-8?B?MXozbUxDRkF3WUZwYWlKTEQ2MUN4OURrY2UzcnIvYXUzNU1kVWZnNXNDN1ky?= =?utf-8?B?dEtudGhyZ0V2dDg2a0pVOWJnV256bVpQa3MwTER0NncrQ2dEaG94SG5tQytw?= =?utf-8?B?NjgvTzBvdG9NRktCcEFzYnQvVzU2cVF5RUVNdVN0MUFtNnJjRHpXNXlTQXpt?= =?utf-8?B?Ym1kbTZ1UmJGZkovS0cwZTRTL2Nmb2hkWDd4ZTg4Zi9kNDhYZnczTGFYU0Iv?= =?utf-8?B?U2haSWxlaVIzVCtacWo4MXNXNUIzdU9sWnJSbnJ5TUlxWU1MallxSEJxVHZT?= =?utf-8?B?K1lqWDBjNkZDQ3lObXZ0ODY5dDVKTHRNUlQ2dERoK2VoY2RaeDJlaGUrVHJU?= =?utf-8?B?THgwcVRGeVVDdGdjeVFmZXZmNkJXOHhkZE9VVnZDNlpaNjZBN0RJOGdaYi9Y?= =?utf-8?B?V2RSWnN2RnVONGF3TUxxb0dBRGJmbmV4YmhSdjFMUTVGMlZSSi95c3Q0R0xO?= =?utf-8?B?YmJUM0FYQVJkaTdieGoyTHdqZTh1Q1RZQndBQTd3VlVNc3FxYkVkbDQzZWxt?= =?utf-8?B?L0h4cndUeEM2RWRvem9HdXZyZC9hRi9XMGsrZlJXQ1JlWW9KKy9UbkNVVzVp?= =?utf-8?B?OHc4eTV6NFRPKzZ3ampqdWpKVzZNT1EzOFJoeUl4QWNmcjM1RFBVSnU2WHIw?= =?utf-8?B?VUtCcDZGcVhQT29mSy94U2c1OUh0RUdQY3VFRFhsKzQ3YzFCN0J3UkZBODUz?= =?utf-8?B?QzJVczQ5ZUc5c2o3ekFyU0t2bVNEMXhwdjZkNjVlWmNydkVROWNDWWgyR1RD?= =?utf-8?Q?Wt5b1L?= X-Microsoft-Antispam-Message-Info: jtIv2azCyrv6Mugw9xxXOmyZ+cUo+/P5t34/GLW82PImQ1Wgwu8qKFrtb9VvYaH0HgrIs1DmrFDajO8juL9a8vmEQ83l58yLFwn3cB6u63fIRyPf5Mf8iZaeWxEOwm0/dt/p5RCx2rHrgGnciz0+cnfuVa41FIs4jUBqML7EGu0= X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 6:CwWJJ3b8TvTTFhDLNk5eqQPiZyKPYGx8Z/I+yZVAhYDZHe9qGOsmqI66Mm8tClIg0+gBUuMZjvskX2UVxYsXBqspsnNoxu7r8vQnzolJJQ+Y/vUzqgOLx9bSoUUJEuodYtA1LnuSsGFTURGY4C7RyNFzYaat1uZL4tJK0DGFpt/1hTHHkEGTmfq/nJo1YCBbDXgodrODNoixr1PGtQTw5/gUB9nLd1Wbc4zny7qQiusRRT18pRGHHK4w8F9Jb2oz1uu/YJtOciqgbi1AmKtjIJK2kM2Rwh7aZkbKV3mJ332PDHoiAepx5689qxnYhOOw5zvAM0854v+N5zDYtYccLjkJB4696VYwKbvGa8YbNWU=; 5:zisFqom/1o2B5Cs1UZp7cCUXQBT+7THg7TLtPlX+wDUrcXAN8T0UzsIjazXVgSK/XV275mTKkxRs8xTohdw12XtYxzLIKGXGKTTFKFgEFwtJsslNyQ+IyW6DIDQSsawZuXAHO5HXyPZA68FRzs7M8P9QLMvBkalIfGMLdzUo3lw=; 24:3VXYqUg6pEl75lRxXcuheVZxyhJfIihyiVIk5XA04ALJj7FRRzyaJpUeuy9bSvhXarvuH9cH8o05g0YHfSZu+Q==; 7:wl+eyId+6Gk8q3xiEaMZQzLrWe7H0Fl1c/lMgpakBw0RpyzUoz7dVYfMH/7oMb2q9Abt+sOXEITTrUkJ1IuOLON6IcOMWREnJsFiRfMXRsqMS/wQ3TIs/GUddW8cyjEV34RSexvWLChpPlf9kLMm0JFXH2HRxrP8IV0GVSaj0mr88YLZlt+NdKcPTNhRNfrPHyyb8Bf0ROjuRRdI9dJOO21kclKZqqTH/KuT8fMxbdLlR4lc6x2c4GRhzm5sj3E8 SpamDiagnosticOutput: 1:22 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2018 10:03:06.7472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b6ef921-9ba0-4e37-81ab-08d57aa4a343 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0765 Subject: Re: [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 10:03:09 -0000 On 2/23/2018 2:55 PM, Thomas Monjalon wrote: > 23/02/2018 07:25, Hemant Agrawal: >> Hi Thomas, >> On 2/23/2018 4:23 AM, Thomas Monjalon wrote: >>> The bus and mempool dependencies should be declared after the PMD >>> libraries needing them. >>> >>> Moreover there is no need to disable the PMDs at the Makefile level, >>> in case the dependencies are not met. >>> Such dependencies should be handled at configuration time. >>> >>> The other side effect of this clean-up is to take into account >>> the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> mk/rte.app.mk | 20 ++++---------------- >>> 1 file changed, 4 insertions(+), 16 deletions(-) >> >> This patch looks good, however I think we (NXP) need to also set some >> dependency check in makefile to avoid dpaaX PMD compilations, if bus is >> not available. I am working on a patch for the same. > > Why do you think such check is necessary? > If the PMD is enable but not the bus, it is a configuration error. > A good configuration system would resolve it automatically, > but currently we do the configuration manually, so the user must fix > its configuration file. > I agree with your comment. That is the ideal approach. However, just to make it convenient and to support cases like VFIO disable, I have added few checks in my v2.