From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30
Date: Fri, 5 Jul 2019 00:01:45 +0100 [thread overview]
Message-ID: <fbd22aa2-fbca-4ca3-9f14-9e9c16b25bd5@intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DC1484@IRSMSX108.ger.corp.intel.com>
On 7/3/2019 4:23 PM, Iremonger, Bernard wrote:
>
> <snip>
>>> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue
>>> rule failure on fedora30
>>>
>>> On 06/25, Haiyue Wang wrote:
>>>> Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB,
>>>> otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg->
>>>> offset = 5912737, arg->size = 0', this caused the parse failure.
>>>>
>>>> If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code
>>>> for assgining 'offset & size' will be missed for some gcc optimization.
>>>>
>>>> parse_vc_action_rss_queue
>>>> 29c5: c5 f9 ef c0 vpxor %xmm0,%xmm0,%xmm0
>>>> 29c9: 43 8d 44 24 68 lea 0x68(%r12,%r12,1),%eax
>>>> 29ce: 48 c7 44 24 20 00 00 movq $0x0,0x20(%rsp)
>>>> 29d5: 00 00
>>>> 29d7: c5 f8 29 44 24 10 vmovaps %xmm0,0x10(%rsp)
>>>> 29dd: 89 44 24 18 mov %eax,0x18(%rsp)
>>>> 29e1: 48 63 83 0c 01 00 00 movslq 0x10c(%rbx),%rax
>>>> 29e8: c7 44 24 1c 02 00 00 movl $0x2,0x1c(%rsp)
>>>> 29ef: 00
>>>> 29f0: c5 f8 29 04 24 vmovaps %xmm0,(%rsp)
>>>>
>>>> The above assembly code is from this modification with:
>>>> gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC)
>>>> Fedora release 30 (Thirty)
>>>> 5.1.11-300.fc30.x86_64
>>>
>>> Do you mean without your patch, the above assembly code (for assgining
>>> offset & size) is missing, after apply this patch, it would show up?
>>>
>> Yes.
>>>>
>>>> Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action
>>>> configuration")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> <snip>
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> Acked-by: Bernard Iremonge <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-07-04 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:38 [dpdk-dev] " Haiyue Wang
2019-07-02 13:00 ` Ye Xiaolong
2019-07-02 6:21 ` Wang, Haiyue
2019-07-03 15:23 ` Iremonger, Bernard
2019-07-04 23:01 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbd22aa2-fbca-4ca3-9f14-9e9c16b25bd5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).