From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B86BA034F; Wed, 31 Mar 2021 23:19:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BFE3140EB8; Wed, 31 Mar 2021 23:19:46 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mails.dpdk.org (Postfix) with ESMTP id 8CCB0140EB7 for ; Wed, 31 Mar 2021 23:19:44 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo1808146wmq.4 for ; Wed, 31 Mar 2021 14:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=iCx7cP6FI3sPelg9mY5guCnfIemxw6Fymr+RUaEKWuY=; b=tsnRlTUNDYisXI/M4Vtvs28lq+RAO+iYQJrHwqfBJuSgUTE56TjBu1GA/FoFdpfHds 5IRXyUk72/8Oim1R75WT+lJ8Hi4AINo7AHhcaOakBfvFqOsiMuOcFuiCb4u3YCaGfyA4 +rzsgjzys60v871KFV957jRYqw4UNDHPNg5Z4jo1xPPqnwhAA9dGzf9qS6D9Qtqcl3uk l/JOgxo1AQWmyotk1lA0l2jthWW6Xda3rDwsF0P9e8ijSwcaC1tVy4h8SlATHOcK/HAe Zk2WSZG/VC2jcJF/3S9B85K9zCFixZvdVCo78yTxA5NtyjIg3SqW4wE/sr6xZJqzgbpe HvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iCx7cP6FI3sPelg9mY5guCnfIemxw6Fymr+RUaEKWuY=; b=uCK5ezUhK6fqrj6SNuHS7dU2PdNc4e/rgntelFMuE9z6uN2L/Q77Jp1cde2E9pWbbU 1zX6Rk6OaPQuRsjy/i0H3XvdLUG4jePzmRdki0KAytkFiFotBbgw/3MbsU1JB3JlMfCH VROx2lTHVCG+b7JrbsHHA+/dH9fbShYgDDfNIMg0eYaY0BxpPrQ7pjG0/2iUu0Z154vu y3S8H8dXDhb+5DfGNYSy9QZl00qjhfdZyRz48TkQzojKcAt6QNtVEtsk98/aKuQ/HIpY ptZX2Qn8rg/cxJfdTFT0QJoL/mEp1typ0gm21vtOmyp45wmkXqwbGY5p86Vhajb/HLDx 24vw== X-Gm-Message-State: AOAM533e546wnD1dk42dxE4vHTL4jyLPPk8RXIJNTbF2gYyLjP9xpamP RmoRUyvFASF0A7QZzdr6R6mHLA== X-Google-Smtp-Source: ABdhPJxgN/7wZ0g+RCYEKcfOYVgaEzLNneWnx/6aUfuA3zwvcOTkCwPHLWJw1Z3nrS2IIx8c7vt82g== X-Received: by 2002:a1c:4986:: with SMTP id w128mr4844673wma.37.1617225584203; Wed, 31 Mar 2021 14:19:44 -0700 (PDT) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id o7sm6522050wrs.16.2021.03.31.14.19.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 14:19:43 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Tal Shnaiderman , Narcisa Ana Maria Vasile , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "dmitry.kozliuk@gmail.com" , "khot@microsoft.com" , "navasile@microsoft.com" , "dmitrym@microsoft.com" , "roretzla@microsoft.com" , "ocardona@microsoft.com" Cc: "bruce.richardson@intel.com" , "david.marchand@redhat.com" , "pallavi.kadam@intel.com" References: <1616802771-31578-10-git-send-email-navasile@linux.microsoft.com> <1617057640-24301-1-git-send-email-navasile@linux.microsoft.com> <1617057640-24301-4-git-send-email-navasile@linux.microsoft.com> Message-ID: Date: Wed, 31 Mar 2021 22:19:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Also, I don't think this is a thread specific function, other implementations can use it in the future, maybe move it to rte_windows.h? I'd suggest that it's probably better suited to a .c file rather than a header.  As an example of what it might end up like see https://github.com/wpdk/wpdk/blob/master/src/error.c Regards, Nick