From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6B6F1A0547;
	Tue, 19 Oct 2021 19:23:57 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 58961410E7;
	Tue, 19 Oct 2021 19:23:57 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D99FD40683
 for <dev@dpdk.org>; Tue, 19 Oct 2021 19:23:55 +0200 (CEST)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 83FBB7F508;
 Tue, 19 Oct 2021 20:23:55 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 83FBB7F508
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634664235;
 bh=Wzf0LpMnb0u7wvnlM2qj1U0m46W24EGw164FDhJUxa8=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=EtAFiRt3dxKuaMM9zBgWRWFV+GVpOEcimtlDuoexGCDzJD1q7Zeiw+8KMkgbeiLkx
 2mS83SWBldAKQ8K+eWMR5A/kLvm0/ABugaGegAgdGxWm7jzo45+a7m4kf3hogXuIqz
 QIMdsbqBpSuqTcEIMjDBJ2PeDxbVG08QjyOT7le0=
To: Olivier Matz <olivier.matz@6wind.com>
Cc: David Marchand <david.marchand@redhat.com>, Ray Kinsella <mdr@ashroe.eu>, 
 dev@dpdk.org
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-7-andrew.rybchenko@oktetlabs.ru>
 <YW7wbj/SqS1U2JOK@platinum>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <fc0aaad4-6f78-25d5-aa7a-3f41fd248b11@oktetlabs.ru>
Date: Tue, 19 Oct 2021 20:23:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YW7wbj/SqS1U2JOK@platinum>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 6/6] mempool: deprecate unused defines
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 7:21 PM, Olivier Matz wrote:
> On Tue, Oct 19, 2021 at 01:08:45PM +0300, Andrew Rybchenko wrote:
>> MEMPOOL_PG_NUM_DEFAULT and MEMPOOL_PG_SHIFT_MAX are not used.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> Fixes: fd943c764a63 ("mempool: deprecate xmem functions") ?

I think it is good idea. Without Cc to stable.

> 
>> --- a/lib/mempool/rte_mempool.h
>> +++ b/lib/mempool/rte_mempool.h
>> @@ -116,10 +116,11 @@ struct rte_mempool_objsz {
>>   /* "MP_<name>" */
>>   #define	RTE_MEMPOOL_MZ_FORMAT	RTE_MEMPOOL_MZ_PREFIX "%s"
>>   
>> -#define	MEMPOOL_PG_SHIFT_MAX	(sizeof(uintptr_t) * CHAR_BIT - 1)
>> +#define	MEMPOOL_PG_SHIFT_MAX \
>> +	RTE_DEPRECATED(sizeof(uintptr_t) * CHAR_BIT - 1)
>>   
>> -/** Mempool over one chunk of physically continuous memory */
>> -#define	MEMPOOL_PG_NUM_DEFAULT	1
>> +/** Deprecated. Mempool over one chunk of physically continuous memory */
>> +#define	MEMPOOL_PG_NUM_DEFAULT	RTE_DEPRECATED(1)
>>   
> 
> Same comment than previous patches here.
> 
> 
> Thanks Andrew for this series!

Thanks a lot for the review.