From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CDA74A034F;
	Wed, 31 Mar 2021 18:46:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5A41B140EF8;
	Wed, 31 Mar 2021 18:46:03 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mails.dpdk.org (Postfix) with ESMTP id 220BD140EF6
 for <dev@dpdk.org>; Wed, 31 Mar 2021 18:46:01 +0200 (CEST)
IronPort-SDR: hSAXaxw/oa8Ui0dIKI+XxVJIglbmMuvqxC8u7AwqlGQqL4QEJfDUKnRVmq2gVevxeOrC2RZFl+
 Ve+sADkcCt/Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="192070768"
X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="192070768"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 31 Mar 2021 09:45:58 -0700
IronPort-SDR: XfznCj9K4T/O3AKicxQwl6IuVt3kTljXdfgTNswzKQl4p8KJ5UYDrfqzl2FRAQf3JUTQj1RoJG
 rFcwQIIapLdg==
X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="445790747"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.249.9])
 ([10.213.249.9])
 by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 31 Mar 2021 09:45:54 -0700
To: Keiichi Watanabe <keiichiw@chromium.org>, dev@dpdk.org
Cc: dgreid@chromium.org, chirantan@chromium.org,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
 Neil Horman <nhorman@tuxdriver.com>,
 David Marchand <david.marchand@redhat.com>
References: <20210322072257.2017227-1-keiichiw@chromium.org>
 <20210322072257.2017227-2-keiichiw@chromium.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <fc19ce20-18b1-2ee6-75b3-1e0feb951c1e@intel.com>
Date: Wed, 31 Mar 2021 17:45:50 +0100
MIME-Version: 1.0
In-Reply-To: <20210322072257.2017227-2-keiichiw@chromium.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated
 protocol features
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/22/2021 7:22 AM, Keiichi Watanabe wrote:
> Add rte_vhost_get_negotiated_protocol_features, which returns a set of
> enabled protocol features.
> 
> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>

<...>

> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map
> index 9183d6f2f..95c4c0990 100644
> --- a/lib/librte_vhost/version.map
> +++ b/lib/librte_vhost/version.map
> @@ -63,6 +63,7 @@ EXPERIMENTAL {
>   	rte_vhost_va_from_guest_pa;
>   	rte_vhost_extern_callback_register;
>   	rte_vhost_driver_set_protocol_features;
> +	rte_vhost_get_negotiated_protocol_features;
>   	rte_vhost_set_inflight_desc_split;
>   	rte_vhost_set_inflight_desc_packed;
>   	rte_vhost_set_last_inflight_io_split;

Added the release version that experimental API is added as comment in next-net, 
like following:

  +++ b/lib/librte_vhost/version.map
  @@ -76,4 +76,7 @@ EXPERIMENTAL {
          rte_vhost_async_channel_unregister;
          rte_vhost_submit_enqueue_burst;
          rte_vhost_poll_enqueue_completed;
  +
  +       # added in 21.05
  +       rte_vhost_get_negotiated_protocol_features;
   };


We are doing this already in many libraries [1], this helps us easily observe 
how long an API is staying as experimental in a library.

[1]: https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407