From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0112A034F; Mon, 19 Jul 2021 10:30:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE7E04069D; Mon, 19 Jul 2021 10:30:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 883A14068B for ; Mon, 19 Jul 2021 10:30:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626683422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S7Q0pgKlwPSX/mClr4j5I6sWW0iviWXE881z0Ekb7/k=; b=bq+nqhYIGLsu5gRqKmiF8tHRZdnwTmiGDoDF/veAe3anSztrmxkTlYUtu2FuDAQCJ5PHWR TNFgHXTfnWrhoz4DAWYFgrsneWgJpn2fnIHgaXJTTObolVgrKQGhaNUolRNJcUKuxV4iZc Ddrz6jgaA+HwXmz4gxQ6r68WuFm9Paw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-kJagUVTKOsCA5u1JFsuyAw-1; Mon, 19 Jul 2021 04:30:18 -0400 X-MC-Unique: kJagUVTKOsCA5u1JFsuyAw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F1C2100C662; Mon, 19 Jul 2021 08:30:17 +0000 (UTC) Received: from [10.36.110.26] (unknown [10.36.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 947D3380; Mon, 19 Jul 2021 08:30:15 +0000 (UTC) To: Cheng Jiang , Chenbo.Xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yong.liu@intel.com, yvonnex.yang@intel.com, stable@dpdk.org References: <20210708095801.23973-1-cheng1.jiang@intel.com> From: Maxime Coquelin Message-ID: Date: Mon, 19 Jul 2021 10:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708095801.23973-1-cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix refill order in packed ring datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/8/21 11:58 AM, Cheng Jiang wrote: > The front-end should refill the descriptor with the mbuf indicated by > the buff_id rather then the index of used descriptor. Back-end may > return buffers out of order if async copy mode is enabled. > > When initializing rxq, refill the descriptors in order as buff_id is > not available at that time. > > Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") > Cc: stable@dpdk.org > > Signed-off-by: Cheng Jiang > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks, Maxime