From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D260A0567; Wed, 10 Mar 2021 17:44:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12EE040F35; Wed, 10 Mar 2021 17:44:35 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A36C94069F for ; Wed, 10 Mar 2021 17:44:32 +0100 (CET) IronPort-SDR: Hc3vjyw42pFfuZVQIa48HZ0TvDYvBC6Vn913AsWCUdqQXoUNxhbj1Qwt8pUiTrDygugJ2VRouw WVQYwHory1JQ== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="188546591" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="188546591" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:44:31 -0800 IronPort-SDR: 6C4QmlW5mZcmY9cmFb4zuK7fFe5jcsIffT0BGD817Ha7PQMbhizvulTf1hizh9uSddZQorgd3K lAfd3B3orP1A== X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="509729553" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.209]) ([10.213.226.209]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:44:22 -0800 To: Ed Czeck Cc: dev@dpdk.org, Shepard Siegel , John Miller , Bruce Richardson References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-5-ed.czeck@atomicrules.com> <3f558b98-66d1-ce63-9ee0-90364cd51146@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 10 Mar 2021 16:44:09 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2021 3:02 PM, Ed Czeck wrote: > On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: >> >> On 3/9/2021 4:08 PM, Ed Czeck wrote: >>> In this commit we generalize the movement of user-specified >>> meta data between mbufs and FPGA AXIS tuser fields using >>> user-defined hook functions. >>> >>> - Previous use of PMD dynfields are removed >>> - Hook function added to ark_user_ext >>> - Add hook function calls in Rx and Tx paths >>> - Update guide with example of hook function use >>> - Add release notes >>> >>> Signed-off-by: Ed Czeck >>> --- >>> v3: >>> - split function rename to separate commit >>> >>> v4: >>> - reorder patches renaming before adding >> >> <...> >> >>> diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map >>> index 954bea679..4a76d1d52 100644 >>> --- a/drivers/net/ark/version.map >>> +++ b/drivers/net/ark/version.map >>> @@ -1,10 +1,3 @@ >>> DPDK_21 { >>> local: *; >>> }; >>> - >>> -EXPERIMENTAL { >>> - global: >>> - >>> - rte_pmd_ark_tx_userdata_dynfield_offset; >>> - rte_pmd_ark_rx_userdata_dynfield_offset; >>> -}; >>> >> >> Since there is no more public APIs by driver, I think it should stop installing >> the header, and remove it from 'meson.build' file, and remove the header from >> API documentation, 'doc/api/doxy-api-index.md'. >> >> I can see the header needs to be used by the extension developer, but that is >> still kind of PMD, the public headers are installed for the application developers. >> >> Still there is a desire to install the required headers for PMD developers, as >> far as I know Bruce is working on it, cc'ed. This header can be installed as >> part of that effort. >> >> Thanks, >> ferruh > > The function prototypes in the header are required by the extension > developer, hence > they need to be accessible in an installed file. Placing them in > rte_pmd-ark.h seems > like the existing solution. If there is a better location or solution > for publishing these > definitions, I have not found it yet. Please advise if I should change > this in some way. > I slightly remember we had same discussion before. Installed public headers are for application usage, but for ark PMD the header is for the PMD extension development. Currently there is no similar usage or requirement. 'rte_pmd-ark.h' seems installed last release because of the public object it had for dynamic mbuf, which should be accessed by application. Now since those objects are gone and the content of the header is changed, it is not for applications anymore, hence I think it shouldn't be installed. As far as I can see the PMD extensions are very much related to the FPGA implementation, so the header is not for everyone to use to develop new code, I expect whoever needs the 'rte_pmd-ark.h' should have the source code already, instead of using the header from installed system path. I think overall it is good to add doxygen comments and dpdk prefix to the extension symbols, but still they shouldn't be part of the API documentation.