DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>,
	dev@dpdk.org
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix uninitialized variable
Date: Thu, 16 Jul 2020 17:14:57 +0100	[thread overview]
Message-ID: <fc57562a-1dec-9434-c97a-96ff736fc735@intel.com> (raw)
In-Reply-To: <f862f3e3-87d2-fcf1-2191-0eff94e3bb3d@redhat.com>

On 7/15/2020 7:32 AM, Adrian Moreno wrote:
> 
> On 7/14/20 1:03 PM, Chenbo Xia wrote:
>> This patch fixes an issue that uninitialized has_reply_ack
>> is used for setting message flags.
>>
>> Coverity issue: 360834
>> Fixes: c60208dd6384 ("net/virtio-user: support reply-ack")
>>
>> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>> ---
>>  drivers/net/virtio/virtio_user/vhost_user.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c
>> index 631d0e353..ad48bafd4 100644
>> --- a/drivers/net/virtio/virtio_user/vhost_user.c
>> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
>> @@ -254,7 +254,7 @@ vhost_user_sock(struct virtio_user_dev *dev,
>>  	struct vhost_user_msg msg;
>>  	struct vhost_vring_file *file = 0;
>>  	int need_reply = 0;
>> -	int has_reply_ack;
>> +	int has_reply_ack = 0;
>>  	int fds[VHOST_MEMORY_MAX_NREGIONS];
>>  	int fd_num = 0;
>>  	int len;
>>
> 
> Acked-by: Adrián Moreno <amorenoz@redhat.com>
> 

Applied to dpdk-next-net/master, thanks.

      reply	other threads:[~2020-07-16 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 11:03 Chenbo Xia
2020-07-15  6:32 ` Adrian Moreno
2020-07-16 16:14   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc57562a-1dec-9434-c97a-96ff736fc735@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=amorenoz@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).