From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB171A054A; Wed, 7 Sep 2022 11:12:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAC82400D6; Wed, 7 Sep 2022 11:12:42 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2057.outbound.protection.outlook.com [40.107.101.57]) by mails.dpdk.org (Postfix) with ESMTP id 66C4C40042 for ; Wed, 7 Sep 2022 11:12:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9CKculd4QUTze2jg339Yljf1UkGMEWa5p1mxcKArSyZ6No0rihyNKq75fIVFN5KAm652iaUbSi+a9XP1pq/mvK8zZBIBQBngNWH1LDMZu7fkXuwLRjIe7ltsG8H+G3FqrqcE+/aoX8tNVDe9IX7Q3EhRMIU82Pg6Pcwzhm+KolDBT+T2lroQTDehxVZtrhDt4OlyCceeczKQ5hu84x53Mn/Mn/NmDdSZh/qnsTdQmlmyzGQz62Ie6T7b78IIFMbfJLixPbfX724e+EUaJ6OPlss13pY6hzFza7aU807oJM4owkoGwjEX0R1z8hb9HdvWenUMOwCI6CR7cH+byNUjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wNfBSodrEXmalbdzInfAhyh1atUPbWYq3pEWA+Sl0o0=; b=CC0kFO5Tg9De/KdWaEQH2If+k3+Uzv/B/zj8Tbfrq2ASNPBosk0cwyGILCyAf94MjES7r3SvLxW1wM4vtFHJOZMhe7RuSVKbMf/u9d9f36IL/wEz7xg9eDeOMgNpRZU/1KZvir3GaKKSHCcultUqU40lL1EyM1TzQkEhYL+Q+TwbewbkUC7PXsgBWpHY+TaCddFWXYWFBcW2OfS1I5PXDnariYW8yrNY/IjRaCJRWP2f0ezWsRL68cjKaxg7W70Pd/66Qsaqk0edw3isH7+5RYqyZvDX3zWo+sXD21tMzrkCQlMgY4dZ/Aa+QaH08XWv9xV8WMnRInNppFSS8T3PSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=microsoft.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wNfBSodrEXmalbdzInfAhyh1atUPbWYq3pEWA+Sl0o0=; b=qYRrTXDjGLGhNwwFZzSxU7CO8Kx3HW6LbaY5512etze0hphVev+Jymm5i5jBaYPCjZmwGGNifZQv/bARhYU7FktL4LIBBMTrToaXTXIOTKG7BqfLtwWLG1WxrgkZarhLjRBYCCOgiY4lqE3Q0iq0NpTFCoa4iE0NUgPl5Q6byC4= Received: from SA9P221CA0001.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::6) by BN6PR02MB3201.namprd02.prod.outlook.com (2603:10b6:405:61::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 09:12:37 +0000 Received: from SN1NAM02FT0004.eop-nam02.prod.protection.outlook.com (2603:10b6:806:25:cafe::5c) by SA9P221CA0001.outlook.office365.com (2603:10b6:806:25::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 7 Sep 2022 09:12:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0004.mail.protection.outlook.com (10.97.4.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 09:12:35 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 7 Sep 2022 10:12:34 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 7 Sep 2022 10:12:34 +0100 Envelope-to: longli@microsoft.com, dev@dpdk.org, sharmaajay@microsoft.com, sthemmin@microsoft.com Received: from [10.71.194.74] (port=37220) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVr6o-0005kc-2E; Wed, 07 Sep 2022 10:12:34 +0100 Message-ID: Date: Wed, 7 Sep 2022 10:12:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Content-Language: en-US To: Long Li CC: "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0004:EE_|BN6PR02MB3201:EE_ X-MS-Office365-Filtering-Correlation-Id: adb33109-a5ae-4396-93d6-08da90b11aad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S0qSq4pFtINJQW5QXZcNYNwlUcylFYIfrElb2H4oALzi6P8t8mJFhLs4sx9TBB7dtRwppMtcrcuQJpEBDcNYIha0B29KilRMksbJU7KIfk8MLDyJjt7yVIrvJdLldkyTRp7cq3GzyD51O53SEpxcBe2xLDOuSNSO1+EpVfrxm7Yl1A0EIJoOkeIL9JFsPVQZUlpsZMcOjyiegErTf++7v+cbBkFcVnjI5QBNTW19rfb/zPzVS4rOrBjpYLrOuiDHUBBql4VZ6OdYYyAS+v66bEJ7Gfv3GtYv4XWR2VdE1cWAE6SeL6pmEYilBFCmh+klxnPT3TL5goAIEiyDWpzwlzhtkunXuxJf35kqM3UUCOcdPn30wzhlAGqc76HE9CMY4xzcTaWFWClTs3JjOOvtlzNWFEf5FQ1HdbqYtZA+JUwDXh7P9DbO5iWgC3Gug7ZQqX+YTT/XPflMzISCz5Sk305t2xaUhFrbF/5Y6iaYt52rwdyg6/KPvtts5BqlZJWvoyk8zTmZeQGspEyPIjgY7ZXMpYmTWdOdrk+aHILQEEclcy2IMKSOJAUeZeXIFdgaIk7qlnQEJptOdZX7F88tdM2CqJyjmlKi7paDOMOaAqhg9y6lYnv+GAmkl0UisaANXvu7ypsQmEqUG3LRET9pdXL1ggN+WKn7xw8YWGtQ5/YW7Xrr11jNmysNxxIWtZbKn/eTSm892CcBEkM4ZAO2C5Uj/8vg0hNWk6jx5bkBtFrUnn4tP7LptFwkF82nkdO2VZ0LSm9aKD08WjXhnXIUmVFSmy+KxaqhiTEMRIx3l2p+GiTwgJt/TdKkO9ydDH6vtUxV4Uo+/9efup6v9PF7sabFrnojP9MsJH196mXt9G1nEOUsoKG1COLTskfQiDjB X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:ErrorRetry; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(396003)(40470700004)(46966006)(36840700001)(2906002)(53546011)(82740400003)(5660300002)(81166007)(26005)(47076005)(44832011)(966005)(478600001)(41300700001)(45080400002)(83380400001)(31686004)(8936002)(36756003)(356005)(82310400005)(36860700001)(8676002)(31696002)(186003)(54906003)(4326008)(426003)(70206006)(70586007)(40480700001)(40460700003)(336012)(316002)(6916009)(9786002)(2616005)(50156003)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 09:12:35.4884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: adb33109-a5ae-4396-93d6-08da90b11aad X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0004.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3201 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/7/2022 3:41 AM, Long Li wrote: > >> Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment >> and doc >> >>> Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build >>> environment and doc >>> >>> On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: >>> >>>> >>>> From: Long Li >>>> >>>> MANA is a PCI device. It uses IB verbs to access hardware through >>>> the kernel RDMA layer. This patch introduces build environment and >>>> basic device probe functions. >>>> >>>> Signed-off-by: Long Li >>>> --- >>>> Change log: >>>> v2: >>>> Fix typos. >>>> Make the driver build only on x86-64 and Linux. >>>> Remove unused header files. >>>> Change port definition to uint16_t or uint8_t (for IB). >>>> Use getline() in place of fgets() to read and truncate a line. >>>> v3: >>>> Add meson build check for required functions from RDMA direct verb >>>> header file >>>> v4: >>>> Remove extra "\n" in logging code. >>>> Use "r" in place of "rb" in fopen() to read text files. >>>> v7: >>>> Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. >>>> >>> >>> Can you please check review comments on v4 [1], they seem still valid >>> in this version. >>> I didn't go through other patches, but can you please double check >>> comments on all v4 patches? >> >> Sorry it was an oversight. Will remove all the "\n" and double check. > > Are you referring to " Remove extra "\n" in logging code." In the comment? > > There are two places "\n" are used, DRV_LOG() and PMD_INIT_LOG() in mana.h. I think they are okay as there is a single "\n" on each output line. > > Please let me know if I missed anything. > Not referring specific to '\n', there are multiple comments there. Can you please double check the email or archive link, comments are all inline? https://inbox.dpdk.org/dev/859e95d9-2483-b017-6daa-0852317b4a72@xilinx.com/ >> >>> >>> >>> [1] >>> >> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Finbo >>> x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- >>> >> 0852317b4a72%40xilinx.com%2F&data=05%7C01%7Clongli%40microsoft >>> .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab2d >> 7c >>> >> d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3 >>> >> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 >>> %3D%7C3000%7C%7C%7C&sdata=4CHI9uw%2B0MwJtVjamECVZWvU >> Yq >>> BCitq7STstFNPNIN8%3D&reserved=0 >